From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38F53207656 for ; Tue, 18 Mar 2025 11:18:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742296715; cv=none; b=axhThsdVx2iraKvRIGfS4e/MuMFOLPaefRxbnVXYmU/Ce0rmKe9O1VEqDaBycN/5xdGGIVT4+7uKYycxqcemQOl13D+XCm5ov2QweDcKhBQE+/R4MLbrT79g5KokYfpubCQlqguES+HSW9DlaXIaGuPpse9PX/iXC0bsRbRpgl0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742296715; c=relaxed/simple; bh=9+PrmrUjfFAWCW/HPllIyFpklnzaITx4qiWJpoMwG7U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l1DnGdwD1s1IaehmAbNWH1Id/+rCqAcE8fo5qBPSwuH0YdfOIzF+JeVzT9zJBHku8zFJvOCV74gjZ5zr3SLhXrAZddnhfKqo4yCpzU7S/2i6IlPMDRGIlOWllK0P2co2wpnHi/MUBwldrGLrX333M30mZ0qSxMMn2fwTeaCQeCs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=f/p23EQD; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=5QEjgjp+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=f/p23EQD; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=5QEjgjp+; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="f/p23EQD"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="5QEjgjp+"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="f/p23EQD"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="5QEjgjp+" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5DAB621CDB; Tue, 18 Mar 2025 11:18:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1742296708; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vYSHjYrlGD5MyoKBWExXGbVVVeHGXdjCPlKheBUw2IM=; b=f/p23EQDZKFHwMf6yQXvLyqOkoOELCd87EU3qwYleOMJGpLQM1zbUPncxgja9XCeM3iDDW SFLTXcUfaIMfvBWxIxg7rWH1OZ0q8jRC+znsZwkEsCzyLQSIITmAb6vKc2xmftss4eklaz g06BbCINDOsuxpiWk/i3nqmdjsiVep4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1742296708; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vYSHjYrlGD5MyoKBWExXGbVVVeHGXdjCPlKheBUw2IM=; b=5QEjgjp+DKYf09zXt+RHehaDpNACADQVrp+15I03+L0T0MUhijDkgoK7cRdioopfh1Lr+x sKA0w2l77E1SndCA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="f/p23EQD"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=5QEjgjp+ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1742296708; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vYSHjYrlGD5MyoKBWExXGbVVVeHGXdjCPlKheBUw2IM=; b=f/p23EQDZKFHwMf6yQXvLyqOkoOELCd87EU3qwYleOMJGpLQM1zbUPncxgja9XCeM3iDDW SFLTXcUfaIMfvBWxIxg7rWH1OZ0q8jRC+znsZwkEsCzyLQSIITmAb6vKc2xmftss4eklaz g06BbCINDOsuxpiWk/i3nqmdjsiVep4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1742296708; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vYSHjYrlGD5MyoKBWExXGbVVVeHGXdjCPlKheBUw2IM=; b=5QEjgjp+DKYf09zXt+RHehaDpNACADQVrp+15I03+L0T0MUhijDkgoK7cRdioopfh1Lr+x sKA0w2l77E1SndCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 461AC139D2; Tue, 18 Mar 2025 11:18:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XvmwEIRW2WfoRwAAD6G6ig (envelope-from ); Tue, 18 Mar 2025 11:18:28 +0000 Message-ID: Date: Tue, 18 Mar 2025 12:18:28 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 14/18] nvmet-fc: take tgtport reference only once To: Daniel Wagner , James Smart , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Cc: Keith Busch , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250318-nvmet-fcloop-v3-0-05fec0fc02f6@kernel.org> <20250318-nvmet-fcloop-v3-14-05fec0fc02f6@kernel.org> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20250318-nvmet-fcloop-v3-14-05fec0fc02f6@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 5DAB621CDB X-Spam-Score: -4.51 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[8]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim,suse.de:mid,suse.de:email] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO X-Spam-Level: On 3/18/25 11:40, Daniel Wagner wrote: > The reference counting code can be simplified. Instead taking a tgtport > refrerence at the beginning of nvmet_fc_alloc_hostport and put it back > if not a new hostport object is allocated, only take it when a new > hostport object is allocated. > > Signed-off-by: Daniel Wagner > --- > drivers/nvme/target/fc.c | 24 +++++++++--------------- > 1 file changed, 9 insertions(+), 15 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich