mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mateusz Jończyk" <mat.jonczyk@o2.pl>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Oliver Neukum <oneukum@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org,
	usb-storage@lists.one-eyed-alien.net,
	linux-kernel@vger.kernel.org,
	smartmontools-support@listi.jpberlin.de,
	Christian Franke <Christian.Franke@t-online.de>
Subject: Re: [PATCH] usb: uas: expose US_FL_NO_ATA_1X in sysfs as deny_ata_passthrough
Date: Sun, 15 Nov 2026 19:26:29 +0100	[thread overview]
Message-ID: <ae7ce6c0-d1ad-459d-a526-1d52fbb445b6@o2.pl> (raw)
In-Reply-To: <1e731b43-93ad-4230-833a-df6949c7d4c6@rowland.harvard.edu>

W dniu 15.11.2026 o 16:52, Alan Stern pisze:
> On Sun, Nov 15, 2026 at 01:40:46PM +0100, Mateusz Jończyk wrote:
>> The uas driver blocks access to ATA passthrough commands for some
>> devices it considers buggy (via the US_FL_NO_ATA_1X flag in
>> unusual_uas.h and uas_detect.h). However, it does not expose any
>> meaningful information whether the command was blocked by the driver or
>> is genuinly not supported by the hardware. This creates a problem for
>> the smartmontools program and makes it difficult for it to provide a
>> useful error message (with instructions to disable UAS on the drive to
>> get SMART readings).
>>
>> So, expose the information in sysfs as deny_ata_passthrough. Other
>> quirks may be added in the future if there is any demand.
>>
>> Link: https://www.smartmontools.org/wiki/SAT-with-UAS-Linux
>> Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
> Why was this change made to uas but not to usb-storage?  Was it because
> some devices can handle ATA passthrough commands over the Bulk-Only
> transport but not over the UAS transport?  Note that the
> US_FL_NO_ATA_1X flag applies to both transports.
>
> Alan Stern

There are only very few devices that cannot handle ATA passthrough commands
over the Bulk-Only transfer (and with them it's impossible to get ATA
passthrough by disabling UAS). But that's a fair point, will fix it in v2.

Considering the US_FL_NO_ATA_1X flag:

- I suspect that many more devices would accept the ATA passthrough 
commands in
   UAS mode if these would be issued in isolation (if uas_queuecommand_lck()
   would stop all other transfers while doing them). After all, Windows
   apparently does not carry such quirks for modern devices. I do not 
have the
   hardware to test, though.

- Since 2017, it is set unequivocally for all Seagate drives, even 
though most
   likely modern drives / firmware versions do not need it. I do not see 
a way
   out, though.

Greetings,

Mateusz


      reply	other threads:[~2026-11-15 18:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 12:40 Mateusz Jończyk
2026-11-15 15:52 ` Alan Stern
2026-11-15 18:26   ` Mateusz Jończyk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae7ce6c0-d1ad-459d-a526-1d52fbb445b6@o2.pl \
    --to=mat.jonczyk@o2.pl \
    --cc=Christian.Franke@t-online.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=smartmontools-support@listi.jpberlin.de \
    --cc=stern@rowland.harvard.edu \
    --cc=usb-storage@lists.one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®