From: Andrew Lunn <andrew@lunn.ch>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk,
linux-kernel@vger.kernel.org, o.rempel@pengutronix.de
Subject: Re: [PATCH net-next 2/3] net: ag71xx: use devm for of_mdiobus_register
Date: Mon, 12 Aug 2024 23:27:59 +0200 [thread overview]
Message-ID: <ae818694-e697-41cc-a731-73cd50dd7d99@lunn.ch> (raw)
In-Reply-To: <20240812190700.14270-3-rosenp@gmail.com>
On Mon, Aug 12, 2024 at 12:06:52PM -0700, Rosen Penev wrote:
> Allows removing ag71xx_mdio_remove.
>
> Removed local mii_bus variable and assign struct members directly.
> Easier to reason about.
This mixes up two different things, making the patch harder to
review. Ideally you want lots of little patches, each doing one thing,
and being obviously correct.
Is ag->mii_bus actually used anywhere, outside of ag71xx_mdio_probe()?
Often swapping to devm_ means the driver does not need to keep hold of
the resources. So i actually think you can remove ag->mii_bus. This
might of been more obvious if you had first swapped to
devm_of_mdiobus_register() without the other changes mixed in.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2024-08-12 21:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 19:06 [PATCH net-next 0/3] use more devm Rosen Penev
2024-08-12 19:06 ` [PATCH net-next 1/3] net: ag71xx: use devm_clk_get_enabled Rosen Penev
2024-08-12 20:48 ` Daniel Golle
2024-08-12 21:08 ` Rosen Penev
2024-08-12 19:06 ` [PATCH net-next 2/3] net: ag71xx: use devm for of_mdiobus_register Rosen Penev
2024-08-12 20:48 ` Daniel Golle
2024-08-12 21:27 ` Andrew Lunn [this message]
2024-08-12 21:35 ` Rosen Penev
2024-08-12 21:42 ` Andrew Lunn
2024-08-13 2:50 ` Rosen Penev
2024-08-12 23:35 ` Rosen Penev
2024-08-13 10:52 ` Simon Horman
2024-08-12 19:06 ` [PATCH net-next 3/3] net: ag71xx: use devm for register_netdev Rosen Penev
2024-08-12 20:49 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae818694-e697-41cc-a731-73cd50dd7d99@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®