From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793723112; b=cQr0MyeiHq/x/SNv4ZwJR4xiB6JtZx1Zfa8SJI1NtpKkNBzBrNomLN9rF+u6KpVUvETx PoYZ4IGJFISJGB/4wyenVeyqybNBWFziga2uKCqM3zZqW8NFMI+LbjN4tx1akbkxr6aDQ T/paLKq90UfM3ACTsdy1rjmZDwAOkdX+tVVSUAvvALoiFeHL9pLB03eRs7yiEtCBB0zoi zisbytAvubYYIzI8e0AckImr4Pj4gGumtfLvsndXZYeqEOTL0CdAQCUAty0q64v4D56q7 VtiPaKn2DB2rQ/Xogv/4QI9QvAm4rV3eTLla0DmyMSP/0lK2wgIypaYvnDsRgqjCR9g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793723112; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=tE53mJP8e3yfIaR1ey1Z14MPWDz6kEM9Vpvw5x6rx3k=; b=mmbMu+gCDglPQ2dyLLaC6tz+gHsdw6Lj7ArWhsLoAbCvswX/t11ZR7eJRfTXOxXkmO36 BxO9HW4Erq0n1Qk31Z3Mls+/20T5n7bwkAyDJj85ZDki3It3yBIAZtamhwfJBwqXTTuwL igkwObsQx79Jt5dWzOP81kYVI6NOACuD+kPN4nrNDCTB2Vybu8oNzpOzWJ7b4EaM6eStV kY/M9Fxn7dXUsdlgFP4oMeCf2rLIErl4swv/y/3ZLLLZPEYTpAoAAn+LwaZV/QUP4IY6z 2ObrGxyvKSHAcQR+1ukpTbF81zi65ZNNkPeMjG4gp3PdqrXxdNJeKP1wWPNeHrCUk5g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=GcEj3cmz; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CE44606A328; Tue, 3 Nov 2026 16:25:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=GcEj3cmz Received: by smtp.kernel.org (Postfix) with ESMTPSA id D07211F00A1F; Tue, 3 Nov 2026 16:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793723111; bh=tE53mJP8e3yfIaR1ey1Z14MPWDz6kEM9Vpvw5x6rx3k=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=GcEj3cmzbXb4U0frxQu4gW6/ltlFA+NJX84JBJ56sTJFIKecsTS04Kgx0ZKPBUZEy P0KkCxb7o4I4e2ZDg43ql/WmLE7Vb9VxnNRbsZFsrP0ziQGASDxnmUh5FF6JKJpgqM asrvNRTZCB5JVWYvbbwKMeV2QP136PSX2fVGr6dtcd2cNcU8sQLiiA4N4DeAuiwF2R k7MMr7ljY3pxrCdEPvDNaKIBQlv7WMbR4cj7G9/TSb0zCxH33+k845Op6TJznd48b2 pnnFf4rq82AlNvgT5QqCW8irdLfmDmFaC4oeCR7ajudbPnvWrJn9u40t33EdMd5mcK 6VYM4og4+0sVA== Message-ID: Date: Tue, 3 Nov 2026 17:25:04 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: uffd-wp-mremap: keep the THP sizes in unsigned long To: Sasha Levin , Andrew Morton Cc: Mike Rapoport , Peter Xu , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261103150232.291827-1-sashal@kernel.org> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20261103150232.291827-1-sashal@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/3/26 16:02, Sasha Levin wrote: > Commit 0020a1f5ca36 ("selftests/mm: hugepage_settings: use unsigned long > in detect_hugetlb_page_size") changed the sizes of the test cases to > unsigned long, but left thpsizes and detect_thp_sizes() with size_t. On > 32-bit architectures size_t is unsigned int, and gcc 14 rejects the test > cases that point at thpsizes: > > uffd-wp-mremap.c:299:26: error: initialization of 'long unsigned int *' from incompatible pointer type 'size_t *' {aka 'unsigned int *'} [-Wincompatible-pointer-types] > > Use unsigned long for the THP sizes as well. > > Fixes: 0020a1f5ca36 ("selftests/mm: hugepage_settings: use unsigned long in detect_hugetlb_page_size") > Signed-off-by: Sasha Levin > --- > KernelCI's 32-bit arm kselftest builds hit this. Built the mm selftests > with gcc 14 and gcc 16 -m32 (four errors in this file before, none > after) and natively with gcc and clang (no change). An i386 build with > clang runs and detects the THP sizes as before, up to the point where > the test needs root. > > tools/testing/selftests/mm/uffd-wp-mremap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/mm/uffd-wp-mremap.c b/tools/testing/selftests/mm/uffd-wp-mremap.c > index c48eaab8e75cf..fb5582ec5b201 100644 > --- a/tools/testing/selftests/mm/uffd-wp-mremap.c > +++ b/tools/testing/selftests/mm/uffd-wp-mremap.c > @@ -15,7 +15,7 @@ static int pagemap_fd; > static int nr_pagesizes = 1; > static unsigned long pagesize; > static int nr_thpsizes; > -static size_t thpsizes[20]; > +static unsigned long thpsizes[20]; > static int nr_hugetlbsizes; > static unsigned long hugetlbsizes[10]; > > @@ -30,7 +30,7 @@ static void check_uffd_wp_feature_supported(void) > ksft_exit_skip("uffd-wp feature not supported\n"); > } > > -static int detect_thp_sizes(size_t sizes[], int max) > +static int detect_thp_sizes(unsigned long sizes[], int max) > { > int count = 0; > unsigned long orders; Reviewed-by: David Hildenbrand (Arm) -- Cheers, David