From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 399E8230BDB for ; Fri, 19 Dec 2025 23:25:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766186710; cv=none; b=mo1YX5T5sXONhgyaYXc/U5RVbRKTC460WogL9z4j218Qcuc6G2TqE/GQ0uyFAfpyAKYm5cp8vA9NUZfW1ph8LD1etPLTRLKqTfh05XPpZ0whjd0vPJNRpWnANJoRc4EQ911kh8aFioA7nsSNqRw50DeYDSsHNtyVHT0/KcVhqx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766186710; c=relaxed/simple; bh=kqYAQZ609rJygFWC7CbHOEHNatKsPADzGjHUdHPU3XE=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=liV0/AYLth586t5fjjNu5OoYzom2tM9OlTOyqtQzpTGzb9wqJXBRvsNBdNerSoE7zWd04SR2KFYltaCpjQlL8tPpBDGytiqUPl7CP48lXMtjumJ5MsjwUdrBLtY3ORVxPzy6JUddILVnwq5+XuxJZDq7/d35R/SeMoTNYH815s8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZCuIhseD; arc=none smtp.client-ip=209.85.215.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZCuIhseD" Received: by mail-pg1-f194.google.com with SMTP id 41be03b00d2f7-c05d66dbab2so2351203a12.0 for ; Fri, 19 Dec 2025 15:25:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766186707; x=1766791507; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=Xjhz9NvSIj1nkwStS3EsBbpnWvjG3hzX9yFNjSmaNpQ=; b=ZCuIhseDaQNaHGHn1/I64ifjGnGD+TkARYa0g6cVisWZaFicT5cXVwFKF5iKdsPnT9 Q1x8LdfikfmhcuR1cISSmH31+ymX9AcU2wfB868uWAQlFaIw0X/90MaZTndE3vXNH0qK p+qwYHUazp0UAhl0b0dFUAlhhQt+9l9iukyctSjBGejt267q6nhozfoCeOOZYBoL297C rlzoRMlrIXvI1jB/BaD1PwtFJ5QWygfSK1ikVNgs1YqQ00hu38LdpO7BiYH6axM886lK ClsS3Z6Xw3ytq6G8Z8PqOxEMrcP3AsbPwFUaVMzviTJSLu1fwyHG8wxjKtu46OYLrr91 j+bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766186707; x=1766791507; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Xjhz9NvSIj1nkwStS3EsBbpnWvjG3hzX9yFNjSmaNpQ=; b=MnlRu44fktgFrFZa2SdjorpRNGz/muVEXcQvyvh4vtmMevOMnG4HMaO67GCXGpEYJR 8JxQKSFuTMreRl3izp6mNpe5fygavz3n947nwGIQ9Y51dTrz7thLmrVXLPEP3Kkg5U0T phbuCFtGIqYaKmWcwDUNbPsEWVXs/qpvIMwkEIbtW8NOrFWViRK9Rmz5NHfYGvrsuB8j LQxEXt7zyZdJY0I3KisyjnA512YAXs4dloX8qdTRgOSyaSXVWpYV6mPQz+zkeGthULxT RHRyL/uAPsw/SMFljnpo2xC57idxP99K9SKgtRLvPiejIHOala+HdkmIQoIATSD8EG/G 0OKQ== X-Forwarded-Encrypted: i=1; AJvYcCXWlULmWmHRS0i2IVStz6vuvvDipSzL+71s62z5KeG+RiLLyBcD1Sd3YcSzNc3+o7LqLDVp+HhYRqCNhoU=@vger.kernel.org X-Gm-Message-State: AOJu0YwPE2IVyYyXJ+9fgrooctdpKOZ8OZxPmlygFtwVzmeeofgrbYIk oRaJpGaaE1IlUy+T9ffo9O+aKkmN2vYD3PObbVOgXYiHWrqwqUoMEfj85HAGUcoVeIw= X-Gm-Gg: AY/fxX4dhzxghKT+ySMZ0zzsqUdvMVMkJxUIn8w4CJNeB6Y1NMALed927+KVOaG0mUj Ae1O+saNN2VAqcTgS3ha/soM1jB9pJvuj1ULYA1qUAK6rezLoZbH8vpyF4Gf/9rTkkVKcRU3BAr 3k17ZK7GHcwbvs1J0iU1xUHk6n6q6+lHT9LCo/vE6hBCGOgUz6mkJ2lIb5osJvM60xVqyndLf/a bUh7WrjegPVA6D7wmpHbFMwBHH4Dlgjer8AnYHA2/D+Wa/q5dH6rLNg7VLfezBKlpp6T/WH26YM NsP2P0H/wHsUkjw8otD2uKd61iV0cwNODnYp7boAMnt9f56SRTdBKn1JqsKDn9Ds2XGvvRHDs42 mfME7Z6vHZdPFatLXxy7glpbcAcyk+FoPphfXP2Vx8/4T6oyc1kQ/i7AY1tmLjfPG7dpGk/tUyp 1rlEFaCbGndnRYuIiNfyjeDZ1+0Zfax1FJS1xvgHRvAO/w9cNmZftI163KRKFpM27/9Qp2M/tJB vOM+vlXvBGPeBZWJgsXbFA++TTUuuLRx45v1IcBC3iTLAArVhGGKEBuStSP39bBpgbfnxfbQ7CF YXA= X-Google-Smtp-Source: AGHT+IFD9VEfhTkWGAUJ+KrkgUpiheofAxrSZVwNtEffu0+8gx+hrdlGu9tKXSDKwQO+mDr4xt9mXg== X-Received: by 2002:a05:7022:3a83:b0:11c:b397:2657 with SMTP id a92af1059eb24-121722be81emr4954809c88.22.1766180747284; Fri, 19 Dec 2025 13:45:47 -0800 (PST) Received: from ?IPV6:2a00:79e0:2e7c:8:5874:79f3:80da:a7a3? ([2a00:79e0:2e7c:8:5874:79f3:80da:a7a3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b05fe99410sm10260116eec.2.2025.12.19.13.45.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Dec 2025 13:45:46 -0800 (PST) Message-ID: Date: Fri, 19 Dec 2025 14:45:45 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Bart Van Assche Subject: Re: [PATCH v5 08/36] locking/rwlock, spinlock: Support Clang's context analysis To: Peter Zijlstra , Marco Elver Cc: Boqun Feng , Ingo Molnar , Will Deacon , "David S. Miller" , Luc Van Oostenryck , Chris Li , "Paul E. McKenney" , Alexander Potapenko , Arnd Bergmann , Christoph Hellwig , Dmitry Vyukov , Eric Dumazet , Frederic Weisbecker , Greg Kroah-Hartman , Herbert Xu , Ian Rogers , Jann Horn , Joel Fernandes , Johannes Berg , Jonathan Corbet , Josh Triplett , Justin Stitt , Kees Cook , Kentaro Takeda , Lukas Bulwahn , Mark Rutland , Mathieu Desnoyers , Miguel Ojeda , Nathan Chancellor , Neeraj Upadhyay , Nick Desaulniers , Steven Rostedt , Tetsuo Handa , Thomas Gleixner , Thomas Graf , Uladzislau Rezki , Waiman Long , kasan-dev@googlegroups.com, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-sparse@vger.kernel.org, linux-wireless@vger.kernel.org, llvm@lists.linux.dev, rcu@vger.kernel.org References: <20251219154418.3592607-1-elver@google.com> <20251219154418.3592607-9-elver@google.com> <17723ae6-9611-4731-905c-60dab9fb7102@acm.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/19/25 1:02 PM, Marco Elver wrote: > On Fri, 19 Dec 2025 at 21:26, Bart Van Assche wrote: >> On 12/19/25 7:39 AM, Marco Elver wrote: >>> - extern void do_raw_read_lock(rwlock_t *lock) __acquires(lock); >>> + extern void do_raw_read_lock(rwlock_t *lock) __acquires_shared(lock); >> >> Given the "one change per patch" rule, shouldn't the annotation fixes >> for rwlock operations be moved into a separate patch? >> >>> -typedef struct { >>> +context_lock_struct(rwlock) { >>> arch_rwlock_t raw_lock; >>> #ifdef CONFIG_DEBUG_SPINLOCK >>> unsigned int magic, owner_cpu; >>> @@ -31,7 +31,8 @@ typedef struct { >>> #ifdef CONFIG_DEBUG_LOCK_ALLOC >>> struct lockdep_map dep_map; >>> #endif >>> -} rwlock_t; >>> +}; >>> +typedef struct rwlock rwlock_t; >> >> This change introduces a new globally visible "struct rwlock". Although >> I haven't found any existing "struct rwlock" definitions, maybe it's a >> good idea to use a more unique name instead. > > This doesn't actually introduce a new globally visible "struct > rwlock", it's already the case before. > An inlined struct definition in a typedef is available by its struct > name, so this is not introducing a new name > (https://godbolt.org/z/Y1jf66e1M). Please take another look. The godbolt example follows the pattern "typedef struct name { ... } name_t;". The "name" part is missing from the rwlock_t definition. This is why I wrote that the above code introduces a new global struct name. Bart.