mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	Rob Clark <robdclark@chromium.org>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/7] drm/msm/gem: Split out submit_unpin_objects() helper
Date: Sun, 3 Dec 2023 13:31:31 +0200	[thread overview]
Message-ID: <ae97ebc2-83d6-4f37-9b69-6a52303b0084@linaro.org> (raw)
In-Reply-To: <20231121003935.5868-5-robdclark@gmail.com>

On 21/11/2023 02:38, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
> 
> Untangle unpinning from unlock/unref loop.  The unpin only happens in
> error paths so it is easier to decouple from the normal unlock path.
> 
> Since we never have an intermediate state where a subset of buffers
> are pinned (ie. we never bail out of the pin or unpin loops) we can
> replace the bo state flag bit with a global flag in the submit.
> 
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
>   drivers/gpu/drm/msm/msm_gem.h        |  6 +++---
>   drivers/gpu/drm/msm/msm_gem_submit.c | 22 +++++++++++++++++-----
>   drivers/gpu/drm/msm/msm_ringbuffer.c |  3 ++-
>   3 files changed, 22 insertions(+), 9 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry


  reply	other threads:[~2023-12-03 11:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-21  0:38 [PATCH v2 0/7] drm/msm/gem: drm_exec conversion Rob Clark
2023-11-21  0:38 ` [PATCH v2 1/7] drm/msm/gem: Remove "valid" tracking Rob Clark
2023-12-03 11:28   ` Dmitry Baryshkov
2023-11-21  0:38 ` [PATCH v2 2/7] drm/msm/gem: Remove submit_unlock_unpin_bo() Rob Clark
2023-11-21  0:38 ` [PATCH v2 3/7] drm/msm/gem: Don't queue job to sched in error cases Rob Clark
2023-11-21  0:38 ` [PATCH v2 4/7] drm/msm/gem: Split out submit_unpin_objects() helper Rob Clark
2023-12-03 11:31   ` Dmitry Baryshkov [this message]
2023-11-21  0:38 ` [PATCH v2 5/7] drm/msm/gem: Cleanup submit_cleanup_bo() Rob Clark
2023-12-03 11:29   ` Dmitry Baryshkov
2023-11-21  0:38 ` [PATCH v2 6/7] drm/exec: Pass in initial # of objects Rob Clark
2023-11-21  0:38 ` [PATCH v2 7/7] drm/msm/gem: Convert to drm_exec Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae97ebc2-83d6-4f37-9b69-6a52303b0084@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@chromium.org \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®