mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@mailbox.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-usb@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: usb: dwc3: Document Renesas R-Car Gen5 DWC3 xHCI USB controller
Date: Tue, 18 Aug 2026 18:02:57 +0200	[thread overview]
Message-ID: <ae9bbbb7-0baa-4431-8a81-0b38a6228f10@mailbox.org> (raw)
In-Reply-To: <20260817-uakari-of-mysterious-nirvana-a1d0da@quoll>

On 8/17/26 9:00 AM, Krzysztof Kozlowski wrote:

[...]

>> +  clocks:
>> +    maxItems: 1
>> +
>> +  dr_mode:
> 
> We don't accept properties with underscores, unless this is coming from
> existing schema but I do not see snps,dwc referenced in the binding.

As suggested later in this thread, ref: snps,dwc3-common.yaml makes this 
whole thing go away, so fixed in V4, thanks .

>> +    enum: [ host, otg, peripheral ]
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  maximum-speed:
> 
> Again, where is the property defined?

usb.yaml , which is pulled in via snps,dwc3-common.yaml in V4 and this 
is dropped.

>> +    enum: [ super-speed-plus, super-speed, high-speed ]
>> +
>> +  phys:
>> +    minItems: 1
>> +    maxItems: 2
> 
> Why is this flexible?

The SoC has four controller instances, two instances only have USB 2.0 
PHY connected to them, and two have both USB 2.0 and USB 3.2 PHYs .

>> +  phy-names:
>> +    minItems: 1
>> +    items:
>> +      - const: usb2-phy
> 
> phy is redundant. Are you implementing completely new bindings which
> have nothing in common with all others?
No, and both phys and phy-names is dropped by pulling in 
snps,dwc3-common.yaml , thanks !

      parent reply	other threads:[~2026-08-18 16:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11  5:09 Marek Vasut
2026-08-11  5:09 ` [PATCH v3 2/2] usb: dwc3: dwc3-generic-plat: Add Renesas R-Car Gen5 DWC3 xHCI USB controller glue Marek Vasut
2026-08-17  7:00 ` [PATCH v3 1/2] dt-bindings: usb: dwc3: Document Renesas R-Car Gen5 DWC3 xHCI USB controller Krzysztof Kozlowski
2026-08-17  7:06   ` Geert Uytterhoeven
2026-08-17  7:13     ` Krzysztof Kozlowski
2026-08-18 16:02   ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae9bbbb7-0baa-4431-8a81-0b38a6228f10@mailbox.org \
    --to=marek.vasut@mailbox.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®