From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9742C26B0B7 for ; Tue, 9 Dec 2025 06:41:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765262511; cv=none; b=CHzYzL3VFQ1RytagQ+WRtAKoYH7CWDrM+mZfFhvkbUTV/EBT9m2iBG441R8dKe155b55O6HzP5IzhdDljPlLjHJ0srKwO4LZxc05h/YeppRl1+LC5ZoCI3I1qJjLbnROPfmF2y7ngDpovkS4Dg+g0yBaIJeQCDxBdqcYhMP+Jv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765262511; c=relaxed/simple; bh=KH6hWSgvjuS0F9qErjJBEDopbbcsLU2q5He+sFKe4vk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rQeueSXP3Z5Q0QJhO1Iq4LA1I37L0p7Bk9DPJoa3m5Mqc2fZVPvhBTbGTvGiPKOcXcau3Wzps+q0DuJQES+AackgWId4ueBE3Axm7EoL0ksXkS/J2NqVCs4wPgvQjhm1jNQHYzeu0FU9gWmxVxvq/XKkBd7t4pGe3k6yWHsJgRU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aDTdNil6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YA/y5ngK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aDTdNil6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YA/y5ngK" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B8NWwBW2005132 for ; Tue, 9 Dec 2025 06:41:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6yuaVMOqG7XZlR/VK/ZkhoEx8/ZaLkTsrEEAnpbVHiA=; b=aDTdNil6MLQnvVkY DVxCZBt+zRG8/JbDQQOp5SyJl9K8uvGMrHc/NelSktwZ5f02wa/hf/p+11NNN981 6pLRjSxmZT3IDe8UWbrk5IWc8/AVNRzv3AFEn+VkYB9IRllvOQ5OBDe2j8JEokOY RmxpDBH1Vwv5fwRyEngc7V/YvuXxHEk5KDqXiUTSuyC0drsnOyzqvLHpIkkX49pv 84fbTXiY8SnxzeyY2qo0rKTZLAKMD2Q0XEOMP4P5WuVaVh403ZFGCuuFr8DFZYxx Mi/4Zm8fPrUtJ3D1/5HLkORu5AqG9fOmF7BjhUevAGWRsi1D9AvqZXH+tfBbXan4 8u3PJg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ax30c9w5f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Dec 2025 06:41:47 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-29806c42760so158274355ad.2 for ; Mon, 08 Dec 2025 22:41:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765262507; x=1765867307; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=6yuaVMOqG7XZlR/VK/ZkhoEx8/ZaLkTsrEEAnpbVHiA=; b=YA/y5ngKQPGI3N/3p7TZPao0kSz2y6/OwLwnwec6S0JhWfD9x5h4ECSbbyKK9sMMDc z/gVF13LVkdlFIhuWGwhi2LIABmTP51k34i3YUvU+p+Ay5E9TiONK0wrMoxa5Dr2N97j CKO4Z4f/rZO3gWwk63CplERhLfRe9ReHq0JPUgNAVD99DrPWgbZ4bZ5AmFKD7B8pkrOz 9tee3n/g8Ofu0IuLz0oylCpbxLX9V8XqnuHkjF2aBBFZZSfdxlJ0kynCrnl6dhJVk3nB lXc0bD1TGUSFkPVV6pFZfLB3Zac4sFJaO9hT8MtBs0hmFpAicpUukaRBwVilzAZJ3XSX DCww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765262507; x=1765867307; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=6yuaVMOqG7XZlR/VK/ZkhoEx8/ZaLkTsrEEAnpbVHiA=; b=iikRdCEgryd5WKdJdjhXduhpFfM5xdhOj6Wbkz0Tr+OlnvfeV3aE4yIbLNwZrK9NAf 6D8uCcJWGDv68ef9bzuqPkhEBM5Vsj1B7M5qxCGNl0BEZFM/i7kqFkTz7pGyyEgTCxor 6kIukPklDRJbT4B+8w+v+M4x7hjTApCrsmtELjZ9Bhp218tWQIUkRF8UfSPcSo1IR1nA bSc2lTMzQ4tqmxUNNn+hQbYWYbcUpxTcSCiDOApAfhurbq1XqpqkvluireWB47/t9F1/ 3ZPc9nlwQB5eKUfsMYPcxWbBZSvAJaWB1NMgUmotKKe1+AhNTD6TANm0vRziPdKS1V9m /xsA== X-Forwarded-Encrypted: i=1; AJvYcCWeFx2hfVJ2dBvKNmCmFh2DQX7f0AOy4KwRhedWqBzGJ+RzDodOwuyuNe4NeG2E46xy9cc0ogKeG3Rilsc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3r08NS3hxA5luhBGbT6jpwMO1cyBgcH3Yr9xqVFHL4Ajj+lYs fnP2EUj8e0GiiDibmXaD79z8Vti9hQxx6D127LF1LMT0KjaZ4JTQsJ3jW8ezUVDwLjIIZOlBc2M 6nremMfc20A10P0iAE7pSijAyUzytk8TKhDPaWA3ZdYMTbt8FliTEsp1T/2pT+Jp8WwE= X-Gm-Gg: ASbGncvYb/p3MJUnNmhppf9vjfnfyabrQzkmNxjrw2SOl842XJZA5tQ9EHkSMiU4/4l Wry9JtP2A8si3vsCxavSGHfUDWsI9uuV92iilA0YsCGRzh6rB0b1MFgPobsNxi0lqt5QRBHJz1k LOhjMwlefw3NTEjHTZTYPDpUCg9IJfwgE9ci2aBYXf37hZRdo6inltruy0Stn7pZSI1BlzmFzD5 tFN/JzAh5VlR1mjKYXMHC2CAMy35SeIw2vSKRynHI5xUSUJlFEhf6GSEvCMLDeXJ5JSISkMXUB2 zJO6Unz3QXQGFFdlj7JYa/l6sWJbogZb3LkqcB4a8E7O9HkLS8V1Jz/MpiBc6ZS8rsX5Z772O8/ wFanoER7sjFnRwFuf9A8YqDB2afjop+wUW6b44ZKQQlIkBwJRN+8BmP8zNszEWtmNSX5F84tGQ8 JFH3mHOA== X-Received: by 2002:a17:903:110c:b0:297:d777:a2d4 with SMTP id d9443c01a7336-29df5deb8d2mr98969915ad.46.1765262507332; Mon, 08 Dec 2025 22:41:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IFlJ3bhQJaIGrAlDle/xf7a85OGCK21q0KG73zyRN0EsK0D2i8F3BqBatBxs6R7FzEWL+jX6Q== X-Received: by 2002:a17:903:110c:b0:297:d777:a2d4 with SMTP id d9443c01a7336-29df5deb8d2mr98969725ad.46.1765262506838; Mon, 08 Dec 2025 22:41:46 -0800 (PST) Received: from [10.133.33.218] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29daeaaba2dsm146086505ad.69.2025.12.08.22.41.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Dec 2025 22:41:46 -0800 (PST) Message-ID: Date: Tue, 9 Dec 2025 14:41:40 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] arm64: dts: qcom: x1e80100: Add crypto engine To: Harshal Dev , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Val Packett , Stephan Gerhold , Abel Vesa , Udit Tiwari , Neeraj Soni References: <20251208-crypto_dt_node_x1e80100-v4-1-f5d03bb2c501@oss.qualcomm.com> From: Wenjia Zhang In-Reply-To: <20251208-crypto_dt_node_x1e80100-v4-1-f5d03bb2c501@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: makIqkKC2oCximc-IN7axVvq_dT0Z9iw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA5MDA0OSBTYWx0ZWRfX8lYr1rSOJb5F DWTltADWq+l++C/uArQrxDcvp+zlfebBuG7naxA5P8xvew5EmV+QtKEHTZmPnsqNf1zCYo1N0HM TxLmfkwu9hPYoAubzK+Nu4N5770zdzd/3JUhfIWwFHhf1wL/M8uQpsAcbHCpUaTXFAxQkbQYRWh sNewhRWypdwfqSiw9gCMbh1oXHvUpmvj6KzFaDvO45nYehY4A2w75CQ3xaks9MctVItfJCnRR9m tSTxSpgP2T5rc+6vhrARJmzyuJcXd0SZJ+bUo5nrEdeX3ZSJ7StBYg5vK4+bMqXHJ8fvDe8Kq2W oKwncZUmaF7Sj17FK4BN05BXJ/fmYYQ/UMUZFEneiawcW4yISG0jWNF2EEAkjMVpebvjMtauFLi KRfaZoftAvSSeFhUFf1nsaKAOyU3cA== X-Authority-Analysis: v=2.4 cv=F99at6hN c=1 sm=1 tr=0 ts=6937c4ac cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=dlRP-RK6hvslqa0QFKgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: makIqkKC2oCximc-IN7axVvq_dT0Z9iw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-09_01,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512090049 在 8/12/2025 下午8:32, Harshal Dev 写道: > On X Elite, there is a crypto engine IP block similar to ones found on > SM8x50 platforms. > > Describe the crypto engine and its BAM. > > Signed-off-by: Harshal Dev > --- > The dt-binding schema update for the x1e80100 compatible is here > (already merged): > > https://lore.kernel.org/all/20250213-dt-bindings-qcom-qce-x1e80100-v1-1-d17ef73a1c12@linaro.org/ > --- > Changes in v4: > - Updated iommu property to use 0x0 instead of 0x0000 in last cell. > - Updated dma-names property by listing one dma channel name per line. > - Use QCOM_ICC_TAG_ALWAYS symbol instead of 0 in the interconnects property. > - Link to v3: https://lore.kernel.org/r/20251127-crypto_dt_node_x1e80100-v3-1-29722003fe83@oss.qualcomm.com > --- > Changes in v3: > - Fixed num-channels and qcom,num-ees properties by updating them to 20 and 4 respectively. > - Link to v2: https://lore.kernel.org/all/20250221-x1e80100-crypto-v2-1-413ecf68dcd7@linaro.org > Changes in v2: > - Added EE and channels numbers in BAM node, like Stephan suggested. > - Added v1.7.4 compatible as well. > - Link to v1: https://lore.kernel.org/r/20250213-x1e80100-crypto-v1-1-f93afdd4025a@linaro.org > --- > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > index 51576d9c935d..0ae5242e98cb 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > @@ -3033,6 +3033,32 @@ usb_1_ss2_qmpphy_dp_in: endpoint { > }; > }; > > + cryptobam: dma-controller@1dc4000 { > + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; > + reg = <0x0 0x01dc4000 0x0 0x28000>; > + interrupts = ; > + #dma-cells = <1>; > + iommus = <&apps_smmu 0x480 0x0>, > + <&apps_smmu 0x481 0x0>; > + qcom,ee = <0>; > + qcom,controlled-remotely; > + num-channels = <20>; > + qcom,num-ees = <4>; > + }; > + > + crypto: crypto@1dfa000 { > + compatible = "qcom,x1e80100-qce", "qcom,sm8150-qce", "qcom,qce"; > + reg = <0x0 0x01dfa000 0x0 0x6000>; > + dmas = <&cryptobam 4>, <&cryptobam 5>; > + dma-names = "rx", > + "tx"; > + iommus = <&apps_smmu 0x480 0x0>, > + <&apps_smmu 0x481 0x0>; > + interconnects = <&aggre2_noc MASTER_CRYPTO QCOM_ICC_TAG_ALWAYS > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; > + interconnect-names = "memory"; > + }; > + > cnoc_main: interconnect@1500000 { > compatible = "qcom,x1e80100-cnoc-main"; > reg = <0 0x01500000 0 0x14400>; > > --- > base-commit: 765e56e41a5af2d456ddda6cbd617b9d3295ab4e > change-id: 20251127-crypto_dt_node_x1e80100-bcb1a2837b56 > > Best regards, Tested-by: Wenjia Zhang # on x1e80100 root@ubuntu:/usr/Testools# ./kcapi-convenience.sh [PASSED: 64-bit - 6.18.0-rc5] Convenience message digest operation =================================================================== Number of failures: 0 Regards, Wenjia