mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Michael Thayer <michael.thayer@oracle.com>,
	"Knut St . Osmundsen" <knut.osmundsen@oracle.com>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virt: Add vboxguest driver for Virtual Box Guest integration
Date: Wed, 4 Oct 2017 11:32:23 +0200	[thread overview]
Message-ID: <ae9f9825-ffa8-8727-a193-94cf9d56abf6@redhat.com> (raw)
In-Reply-To: <f462e363-328b-df74-56bb-c8731eae16ea@redhat.com>

Hi,

On 03-10-17 13:41, Hans de Goede wrote:

<snip>

>>> +#define CHECK_IOCTL_IN(req)                             \
>>> +do {                                         \
>>> +    if ((req)->Hdr.cbIn != (sizeof((req)->Hdr) + sizeof((req)->u.In)) || \
>>> +        (req)->Hdr.cbOut != sizeof((req)->Hdr))                 \
>>> +        return -EINVAL;                             \
>>> +} while (0)
>>
>> Make these things functions instead of macros.
> 
> Turning these into functions is a good idea I will do so for v2.

Correction, I forgot that the passed in "req" macro
argument has a different type with all the calls, so
these cannot be changed into functions because they
rely on sizeof on the specific type to do the size
checks.

Regards,

Hans

  parent reply	other threads:[~2017-10-04  9:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-03  9:21 [PATCH 0/1] " Hans de Goede
2017-10-03  9:21 ` [PATCH] " Hans de Goede
2017-10-03 10:04   ` Christoph Hellwig
2017-10-03 11:41     ` Hans de Goede
2017-10-03 12:40       ` Greg Kroah-Hartman
2017-10-04  9:32         ` Hans de Goede
2017-10-04  9:32       ` Hans de Goede [this message]
2017-10-04 10:11         ` Greg Kroah-Hartman
2017-10-04 10:23           ` Arnd Bergmann
2017-10-04 10:30             ` Greg Kroah-Hartman
2017-10-04 10:40               ` Hans de Goede
2017-10-04 14:34                 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae9f9825-ffa8-8727-a193-94cf9d56abf6@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=knut.osmundsen@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.thayer@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®