From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47675390CBA for ; Thu, 16 Apr 2026 21:11:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776373876; cv=none; b=E9OR/xm7FDAts9YSCu4s/Dw1seGXLWhEkF/TQiZbRp73wgzcn/QT3iy/CDc1d+rjHEdXqaPr1ODM7/d1FpkGGsqXLRAZKzYaTdt2p+EzJdwzz2UABbYTaiMjXvODj6ICWdjjk7aXcLsa1Vkfau3D3Lh3SvN7qLkia/lL07soSJk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776373876; c=relaxed/simple; bh=vM2pTl3oQ07zH2q7xfU4RWedwvGF2eYv3t6c6cn3grI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nnC5DVlyjFr1QQqwM3VCprvnCqtXcPYXxVWeMkwpPfkqDLVYqSwhTEvZzh6QGi3qjxMa0YlGZYnnXO1v0AfChOdIVF+loV7Ue9Se2k2dodqYBztXgoxLrVnD7EjUfzQbm51MhL3TA/zGE5hhC2gvpcDOyTIOB/a6lC/4JZTcedw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F+KfjQSn; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F+KfjQSn" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-43d03db7f87so5302384f8f.3 for ; Thu, 16 Apr 2026 14:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776373871; x=1776978671; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wVY+JkCF1HjvxGCLIBbX5MkwJ+xH0imUdXD/TgdOXrQ=; b=F+KfjQSn7iHIOMZIbGPyzogzTH2ot1bcxQ68ZeRRITpOG1zyRJarlJQv4ZGW27PkPa xbO14liyUwUvCN60gamudqJDy4c2slDHi7NiMtqx86TZvudL4GSLTXDN10lS3U4xHPkR GT0qce8EiMovF1LPZdrsW0cAtiv//hdOv9Ne/K/C1sEk6l681nPBbBzjj9U906mHaL6L LIh8rb8RFCL0PHXoZZblJZeVgEG8hQFOH51A3R+NLFHwuBDg8Z9iTzYg/f7uPVOwJ82m qiMeycjQ0ZZdInNLPQaxfhsb2X0HQKVyO5igYrP222PoyuzV0itGxcTjYlqCZvoHyO1B Frmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776373871; x=1776978671; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wVY+JkCF1HjvxGCLIBbX5MkwJ+xH0imUdXD/TgdOXrQ=; b=EDBI5DwOQVOIFtl7n5DhkCP9HpIum0jFDccyIMNipjwOJiClTQCD45JV5avjtYR1cM ztHuVs/EVdm213/qRVfrpKW1t922u84NqceKAUeth1Ld1j4smlfG9lRVS3z13kstNm4q +B0S0R6egRK3n27ybGNvwMLyd8Aby6a5Aoc5PuyufQvUkLAeWaa4eUEmaXlkMjchQ5RD uPUSOQqc8bxkg3ofh0aW4OdglGL8IxJqQELX2pCztJR0obe5WIdTI9vcOLGE7GVN5JNf yd3n166e8GUuEnWEhGe+XwMUdmcyu0XPdTO57jC7J/AKqklicc0xNtNPPUQ6icES/tz/ GBIQ== X-Forwarded-Encrypted: i=1; AFNElJ+TGtIQXv3WxmrMteocjDYRePb+Qf+sRMgMhkutKp8JTPqNuYClFhMT0ouM1i+UnIlDY/pa8UHRWGRyGlk=@vger.kernel.org X-Gm-Message-State: AOJu0YzkqAqnQmlofyzIy8Nhfh3JEqpMbHKCy/8FNO0LfvuUJL300Gpr F0nAP2UFX2SgK2tecwZPqeSTQO6QyB8NEFQ3UoMf+L6JQJDqP4KhAafw X-Gm-Gg: AeBDietRZgdguVHgzckvJYvFKMARZ7hYju5IsQ9JMy3J5h97UY2JBAQeDApgggTesxM QWE0cPXAqR3sCggEVuqvzwQrobcJLCeiP7cZVOYizDOCaKyU2npYcBMrM5l1D/0JOh5PhDnq0Rw 8fdFlkponxlAJiEObtXz2UOXGCQAd0KdsUFWxXtEI1R3dvyluPGmyOd/alS16qa652Yflhq8PFL i1/5t4EASe/UGW8BifVcwtz35Uvb90KgRMX1TygXnvam38FqjuCrnW//R/oJXW5nzL9SsrX6lUx vbQhC/VHo+oElZQvD9X6y2JhK0tsolAOMOIWUjKKIO0QIz848ouMy5PauI1rgZ59uP7KUbzMMGt u30HY9KmCrpbBHbyy2QBfUlR3ZIuuSs1njvuFmuPg0OHusl4NNwcasPqojD7hplNcVBGLb0dhAk tlNlS4+XzWsbhjgjW5ffGBj1XzU++ZVg== X-Received: by 2002:a05:6000:1788:b0:43d:1c39:593c with SMTP id ffacd0b85a97d-43fe3dfbcb8mr144860f8f.30.1776373871208; Thu, 16 Apr 2026 14:11:11 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43ead35bf1esm17407209f8f.16.2026.04.16.14.11.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 14:11:10 -0700 (PDT) Date: Fri, 17 Apr 2026 00:11:06 +0300 From: Dan Carpenter To: Maksym Pikhotskyi Cc: gregkh@linuxfoundation.org, ethantidmore06@gmail.com, starpt.official@gmail.com, straube.linux@gmail.com, sameekshasankpal@gmail.com, arthur.stupa@gmail.com, luka.gejak@linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt Message-ID: References: <20260415184727.285753-1-mpikhotskyi@gmail.com> <20260416195338.324428-1-mpikhotskyi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260416195338.324428-1-mpikhotskyi@gmail.com> On Thu, Apr 16, 2026 at 11:53:37PM +0400, Maksym Pikhotskyi wrote: > The null-pointer-guard was incorrect, returning _FAIL on valid pointer. > Invert the guard, so it returns _FAIL on invalid pointer. > > Fixes: e23ad1570028 ("staging: rtl8723bs: use guard clause for stainfo check") > Signed-off-by: Maksym Pikhotskyi > --- Ugh. Crap. Thanks. Reviewed-by: Dan Carpenter regards, dan carpenter