mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Teng Liu <27rabbitlt@gmail.com>
Cc: andy@kernel.org, hansg@kernel.org, mchehab@kernel.org,
	gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: media: atomisp: remove unnecessary parentheses in return statement
Date: Sat, 18 Apr 2026 11:25:12 +0300	[thread overview]
Message-ID: <aeM_6Kpt6UhmDtgL@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <20260317155636.99844-1-27rabbitlt@gmail.com>

Hi Teng,

On Tue, Mar 17, 2026 at 04:56:36PM +0100, Teng Liu wrote:
> Remove unnecessary parentheses around the return value in
> ia_css_pipeline_get_pipe_io_status(). return is not a function,
> so parentheses are not required.
> 
> This addresses the following checkpatch error:
>   ERROR: return is not a function, parentheses are not required
> 
> Signed-off-by: Teng Liu <27rabbitlt@gmail.com>
> ---
>  .../staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c   | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c b/drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c
> index 0470871f8..fba567de4 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c
> @@ -446,7 +446,7 @@ bool ia_css_pipeline_has_stopped(struct ia_css_pipeline *pipeline)
>  
>  struct sh_css_sp_pipeline_io_status *ia_css_pipeline_get_pipe_io_status(void)
>  {
> -	return(&sh_css_sp_group.pipe_io_status);
> +	return &sh_css_sp_group.pipe_io_status;

Is it the only such case in the driver?

>  }
>  
>  bool ia_css_pipeline_is_mapped(unsigned int key)

-- 
Regards,

Sakari Ailus

      reply	other threads:[~2026-04-18  8:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 15:56 Teng Liu
2026-04-18  8:25 ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeM_6Kpt6UhmDtgL@valkosipuli.retiisi.eu \
    --to=sakari.ailus@iki.fi \
    --cc=27rabbitlt@gmail.com \
    --cc=andy@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®