mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Karthikey D Kadati <karthikey3608@gmail.com>
Cc: Hans de Goede <hansg@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: atomisp: fix block comment coding style
Date: Sun, 19 Apr 2026 01:12:55 +0300	[thread overview]
Message-ID: <aeQB5w7EYm52zYND@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <20251227105520.23086-1-karthikey3608@gmail.com>

Hi Kerthikey,

On Sat, Dec 27, 2025 at 04:25:20PM +0530, Karthikey D Kadati wrote:
> Fix the checkpatch.pl warning:
> WARNING: Block comments use a trailing */ on a separate line
> 
> This change aligns the block comment at line 1384 with the standard
> Linux kernel coding style for better readability.
> 
> Signed-off-by: Karthikey D Kadati <karthikey3608@gmail.com>

Thanks for the patch.

It no longer applies to my atomisp branch. In general, it'd be good to fix
a few more issues of the same kind.

> ---
>  drivers/staging/media/atomisp/pci/atomisp_cmd.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> index 3a4eb4f6d..327836372 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> @@ -1380,8 +1380,10 @@ static void atomisp_update_grid_info(struct atomisp_sub_device *asd,
>  	if (atomisp_css_get_grid_info(asd, pipe_id))
>  		return;
>  
> -	/* We must free all buffers because they no longer match
> -	   the grid size. */
> +	/*
> +	 * We must free all buffers because they no longer match
> +	 * the grid size.
> +	 */
>  	atomisp_css_free_stat_buffers(asd);
>  
>  	err = atomisp_alloc_css_stat_bufs(asd, ATOMISP_INPUT_STREAM_GENERAL);

-- 
Kind regards,

Sakari Ailus

  reply	other threads:[~2026-04-18 22:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-27 10:55 Karthikey D Kadati
2026-04-18 22:12 ` Sakari Ailus [this message]
2025-12-27 10:56 Karthikey D Kadati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeQB5w7EYm52zYND@valkosipuli.retiisi.eu \
    --to=sakari.ailus@iki.fi \
    --cc=hansg@kernel.org \
    --cc=karthikey3608@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®