From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 796C031A556
	for <linux-kernel@vger.kernel.org>; Mon, 20 Apr 2026 14:54:24 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1776696864; cv=none; b=bBOPbM6hsXECPMm8Eztf9Kh7heTf0ISXMlVXH8FDmR4BS+qtb6s2dwOjjKW0N6k6tquouDLavDU9oO37qmYfw3fMKiBB/RGZ6+BYO9VTUDdJTskDf4qCPLcucicEeHFKyY7Ov+I0KZcR5aJorvBd1SMcE0Q17UGr+wzAPLs9Zt4=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1776696864; c=relaxed/simple;
	bh=o4yy5WH/m71HPtOkxuFd1gFe/seDYLMN3dzJeM1EXoY=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=Ac/r+niu7/ziEr1WvSpylm86NMijoWkiCEQYRNoKOvF2W1dEF+GAarPEmxKr+2EPv+6jfg99UXUpSfvGy1Hvclsupbvs/rFYpufr6NRnmgRqmQEs5mJlVfFPL/I1NZ6CjT3Mr3j0FxP0+215uWNQJaO0prfrll9MgymaG4+/BMo=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sBRRXJ8T; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sBRRXJ8T"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E44FC19425;
	Mon, 20 Apr 2026 14:54:23 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1776696864;
	bh=o4yy5WH/m71HPtOkxuFd1gFe/seDYLMN3dzJeM1EXoY=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=sBRRXJ8Tb9It0KcfkMkcyyXbc5D324kFK04WhGGWbG9H84QsAPC89eqL8zEsWgWbg
	 7jD52qelvR9F/EPr5nqz0UUgId3SBKEn0MyfA7+fUQazrCJPgVX5MX/9rNKjjKa015
	 /JAobfbLUsIuJyBLERiUtYdFndLZG5Iyc+/1+VGz2U9VbSe8AJqecpvFKrakTXSdKq
	 Ijm91nJ8nkVFPDQty6uaLrMy/d9OjhupkcrNPANDr+B+yHj+W/UW+olS10rO8hbeQZ
	 cj3VbZSMrYMI+ZHW0kBNW/cQMVohNXeWNAOYVV1297Yu5tMbNfazTr16LKnmPSijkn
	 G9rza4SD0Q66A==
Date: Mon, 20 Apr 2026 08:54:21 -0600
From: Keith Busch <kbusch@kernel.org>
To: Daniel Wagner <dwagner@suse.de>
Cc: Chao Shi <coshi036@gmail.com>, Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Hannes Reinecke <hare@suse.de>, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org, Sungwoo Kim <iam@sung-woo.kim>,
	Dave Tian <daveti@purdue.edu>, Weidong Zhu <weizhu@fiu.edu>
Subject: Re: [PATCH] nvme: core: reject invalid LBA data size from Identify
 Namespace
Message-ID: <aeY-HYDHq1wEhLYc@kbusch-mbp>
References: <20260418042835.420281-1-coshi036@gmail.com>
 <cb2c00e2-ba72-4d6d-b17f-ef5ae3b0633e@flourine.local>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cb2c00e2-ba72-4d6d-b17f-ef5ae3b0633e@flourine.local>

On Mon, Apr 20, 2026 at 02:22:04PM +0200, Daniel Wagner wrote:
> On Sat, Apr 19, 2026 at 12:28:34AM -0400, Chao Shi wrote:
> > Fixes: 9419e71b8d67 ("nvme: move ns id info to struct nvme_ns_head")
> 
> This fixes tag is wrong. The above commit doesn't touch the code line
> in question.
> 
> Probably a5b1cd61820e ("nvme: move a few things out of
> nvme_update_disk_info") is the better choice here.

We've never validated the 'ds' field though, so not sure anything
introduced a regression here that warrants a fixing tag.