From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934766AbdAIJyJ (ORCPT ); Mon, 9 Jan 2017 04:54:09 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:8344 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754876AbdAIJyB (ORCPT ); Mon, 9 Jan 2017 04:54:01 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfec7f1-f793f6d000007796-25-58735db44030 Subject: Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board To: Inki Dae , Andi Shyti Cc: Hoegeun Kwon , robh@kernel.org, thierry.reding@gmail.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, cw00.choi@samsung.com, jh80.chung@samsung.com, Donghwa Lee , Hyungwon Hwang From: Andrzej Hajda Message-id: Date: Mon, 09 Jan 2017 10:53:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 In-reply-to: <587355B8.2050701@samsung.com> Content-transfer-encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHeXcuOw5nx6n5sNJiEVnSlYLThZXdGAUR+CHRokae1HJqOypd JFqkzlnbXEo2o5uYokalZlZiuobTLq5yXaycZpQjhXWxcILZtjPBb7/n/T/XPy+FSayElErL yGbVGcp0GSnCmzs9PUub9nEJKyqKopnzPd0C5r71G8G8GxsmmKvWHi/Z5Yzjj5tk3NU6kqkq 1xOMacCIM+8nCgjG8GUEY+z2O0Km9+Flkim3twmYqdYWIeN5eAXfRCsemPuFiobaIlJx/+8g oRgotgkU+qZapPjdEL2bTBRtSGbT03JZ9XL5AVGqcbQGz3o5/5j7kUNwGtVLdSiIAno11I32 CHmeDS+dt0kdElESugpBW36lgA9+Iyhs+YOmK9xXSwPCTQS9lRrCJ4jpUBi/4MR9jNGLwTVm wvmkbwjG6kYwnxBGJ0L+uN7P4bQCHrx4LfQlYbQJg6YfBv8ipLd6srGP5LvKYbyxxM84vRA8 BpufI+gEsHR+9DcKomNB65gQ8JPnQYdjGOdX/SkEe3uaDlFejoKGdox/3gqFN/oCN4fBd1tT gOdCkbbDfxnQxQh+GbqEfFCK4N+P8kD1enhie0Xww0LA1HwR4weIQVsg4VMU0KmxB+yKA4fL FbDrIwYfJrsFRjTPPMMx8wzHzDNuuIawWhTO5nCqFJZbtYxTqricjJRlBzNVDcj7t579s/1s Qe6udRZEU0gWLDbuUCdICGUud1xlQUBhsnDxob1cgkScrDx+glVn7lfnpLOcBc2hcFmkuPWa Y4+ETlFms0dYNotVT6sCKkh6GpXEXN78WDocrO9trYbIdPnUuY76BZmxUQfvVmwvf7olb3R7 tc504s2sRU+G1ryyxkeWTQ4ZQvPvDUo2rk0JOvr1e5n57an+mMO2S6a4kyGN9WdTnbu6T3lk cP2oW6SZ0OS5tDu3oZjXk86kCJm+83NS1q2+pN39Zc/PxDubP6n1NTKcS1WuXIKpOeV/vsCl 91cDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPIsWRmVeSWpSXmKPExsVy+t/xy7rPYosjDL5/57foPXeSyWL7kWes Fte/PGe1mH/kHJB13s7iytf3bBbvl3exWSyd0cdqMen+BBaLG7/aWC36H79mtjh/fgO7xeVd c9gsZpzfx2Txf88Odoufu+axOAh47Jx1l91j06pONo/t3x6wetzvPs7k0bdlFaPH501yAWxR bjYZqYkpqUUKqXnJ+SmZeem2SqEhbroWSgp5ibmptkoRur4hQUoKZYk5pUCekQEacHAOcA9W 0rdLcMuY8GYFS8EFhYr3u68wNTCukepi5OSQEDCReD9/ChOELSZx4d56NhBbSGAJo8T8F9kg Nq+AoMSPyfdYuhg5OJgF1CWmTMntYuQCKnnGKLHkwRxmkLiwQJTE2+tRIOUiAh4SO89eYoeo uc0s0dF9jRXEYRaYwCyx4vtrVpAqNgFNib+bb7JBLLCT+LF5IpjNIqAq8bP/OBvIUFGBCImG w+kgYU4BbYmOK7/A7mQWkJc4eOU5ywRGgVlIzpuFcN4sJFULGJlXMYqklhbnpucWG+oVJ+YW l+al6yXn525iBEbutmM/N+9gvLQx+BCjAAejEg/vBK+iCCHWxLLiytxDjBIczEoivGkxxRFC vCmJlVWpRfnxRaU5qcWHGE2BTp3ILCWanA9MKnkl8YYmhuaWhkbGFhbmRkZK4rwlH66ECwmk J5akZqemFqQWwfQxcXBKNTCKfmotsHaJ7E/dUc6QumR3/6kVPl92HmrhF7jLpd14gFPEPvDP 5D+eotPMrlVFZx5h+hFb+nnHNf6ImvbuXnchwQQ9133aglGb5IoEz5yR6Tswe1K78r5pCfcN /HYvU1DMquy90SplfS4kq6PDxM31QYLw/bqmiImzU2Tet683m/D0aNeJFCWW4oxEQy3mouJE AP1VDhbyAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170109095355eucas1p2d3f0b1d2bdbe317ae59a7e48d21c2711 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170105102012epcas1p4ddeb577ea84b5c2cdf7029666b2091c1 X-RootMTR: 20170105102012epcas1p4ddeb577ea84b5c2cdf7029666b2091c1 References: <1483611609-23522-1-git-send-email-hoegeun.kwon@samsung.com> <1483611609-23522-4-git-send-email-hoegeun.kwon@samsung.com> <20170106052239.5prkyj3v4x4qcc46@gangnam.samsung> <586F2BF3.8080400@samsung.com> <20170106081806.h4y7o57kjbibau6l@gangnam.samsung> <586F5728.1010800@samsung.com> <5df95abe-0d5d-0c48-2840-5996260201de@samsung.com> <587355B8.2050701@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09.01.2017 10:19, Inki Dae wrote: > > 2017년 01월 09일 16:37에 Andrzej Hajda 이(가) 쓴 글: >> On 06.01.2017 09:36, Inki Dae wrote: >>> 2017년 01월 06일 17:18에 Andi Shyti 이(가) 쓴 글: >>>> Hi Inki, >>>> >>>> Thanks for the reply, but... >>>> >>>>>>> +static const struct drm_display_mode default_mode = { >>>>>>> + .clock = 222372, >>>>>>> + .hdisplay = 1440, >>>>>>> + .hsync_start = 1440 + 1, >>>>>>> + .hsync_end = 1440 + 1 + 1, >>>>>>> + .htotal = 1440 + 1 + 1 + 1, >>>>>>> + .vdisplay = 2560, >>>>>>> + .vsync_start = 2560 + 1, >>>>>>> + .vsync_end = 2560 + 1 + 1, >>>>>>> + .vtotal = 2560 + 1 + 1 + 15, >>>>>>> + .vrefresh = 60, >>>>>>> + .flags = 0, >>>>>>> +}; >>>>>> how is this working with tm2e? Are these values valid for both >>>>>> the boards? >>>>> We don't need to consider tm2e board with two reasones, >>>>> 1. there is no tm2e board support in mainline >>>>> 2. the panel on tm2 would be a little bit different from one on tm2e >>>> ... this display in the Tizen Kernel is supported by both: >>>> tm2 [1] and tm2e [2]. The only differences are: >>> Why tm2e dts file is in mainline? Seems communication miss with Chanwoo. :( >>> >>>> TM2: >>>> clock-frequency = <14874444>; >>>> hactive = <1440>; >>>> >>>> TM2E: >>>> clock-frequency = <16523724>; >>>> hactive = <1600>; >>>> >>>> I don't know much about the differences you mention in point 2, >>>> but it's a pity to drop support only because we don't want to put >>>> in the dts the 'hactive', and 'clock-frequency' properties. >>> Anyway, tm2e board is already in mainline so Panel driver may need to identify what kinds of panel is probed to decide porch values. I think there are relevant registers in MCU of the Panel device to check version or similar thing. >> I think we can safely use different compatible string for tm2e - it uses >> different display IC controller - s6e3hf2, driver will provide timings >> based on it. > Using compatable string wouldn't be a good idea because Panel is a device not specific to board. But both panels are different devices: TM2 has: AMS567DJ01 panel on S6E3HA2 interface (called LDI/IC) TM2E has AMB559DE01 panel on S6E3HF2 interface (called LDI/IC) Why assigning different compatibles to different devices is not a good idea? > >> As far as I examined available specs/docs there is no reliable register >> which can be used to safely distinguish it on runtime, but the docs I >> have are far from completeness. > The data sheet I am seeing says a RDDIDS register describes manufacturer and module version information. With this we could identify the Panel device. > Of course, we may need to check the register has really different values according to board. > > Below is the version information Hoegeun checked, > > TM2 > [ 4.908666] panel_s6e3ha2 13900000.dsi.0: Manufacture date: 2014-10-31 06:41 > [ 5.035768] panel_s6e3ha2 13900000.dsi.0: Id: 50 20 09 > > TM2e > [ 4.929265] panel_s6e3ha2 13900000.dsi.0: Manufacture date: 2014-09-03 06:30 > [ 5.056287] panel_s6e3ha2 13900000.dsi.0: Id: 40 40 14 There is description of ID1, ID2, ID3 registers in specs of both panels, I see no reliable bits to distinguish panels. And relying on read values of random devices does not seems to me proper solution. Regards Andrzej > > > Thanks. > >> Regards >> Andrzej >> >>> Thanks. >>> >>>> Andi >>>> >>>> [1] https://git.tizen.org/cgit/platform/kernel/linux-exynos/tree/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts?h=tizen#n1284 >>>> [2] https://git.tizen.org/cgit/platform/kernel/linux-exynos/tree/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts?h=tizen#n1270 >>>> -- >>>> To unsubscribe from this list: send the line "unsubscribe devicetree" in >>>> the body of a message to majordomo@vger.kernel.org >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>> >>>> . >>>> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> >