From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7C736372 for ; Wed, 29 Jan 2025 17:38:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738172317; cv=none; b=lIMNFRipKq1r8i82lIStqFxJEU6zn6m/lVo4F3NEDH8v96oll+OfGxXEtYQiskbMFvVH2vnUHGN+Gn9NiwSmuD11y2+oKUM8nGIGun9PWjGRQe5n5dZxz/vmAUpulVA5d5q/aM+/JPSuHwvVLxHwOkusXkpw2pgOmfJgCwVcG6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738172317; c=relaxed/simple; bh=NS6mlZ/5maGI7/ua++niZZw9hXZFzSzo5x2gBhk8vK8=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=JUYzqQqjL9iGRhuxrwdTClMIZ4NjBOBqr09eIW6U6yZ1q2g19gSR8jicwTJNmRBcCjC799F/OPENqr79roWSAhosPK5qY6KFLseP2peAoKCoKbkNmg3s4RXHwxNkjzj685u7QwhqfHcIJase6v1vsAd4Wg070asa+hKPsdRXOR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=cka0X3ia; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="cka0X3ia" Received: from [100.65.98.224] (unknown [20.236.11.42]) by linux.microsoft.com (Postfix) with ESMTPSA id D4F5C2066C19; Wed, 29 Jan 2025 09:38:35 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D4F5C2066C19 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1738172316; bh=cJ9d+E1dSYsxptXRTXBxxtRku+LQhMlnWswfyOTmi6c=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=cka0X3ia5zuKwc49NhO3HaYx1RAPzX2iRa1EYwvFydXDPmAA9IegmYFa2wPEz8amY DYdpS76JZiBrUp4Jy11PFVBeTL32p/wRw54zjg0GfQlgNDmjLyYE9WYtEU3rpCoon6 jMEytwbHb7HAzb6KrCubUrhxJ6kdzGxyecCT7eeE= Message-ID: Date: Wed, 29 Jan 2025 09:38:38 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Julia Lawall , Nicolas Palix , Andrew Morton , eahariha@linux.microsoft.com, cocci@inria.fr, linux-kernel@vger.kernel.org Subject: Re: [PATCH] coccinelle: misc: secs_to_jiffies script: Create dummy report To: Ricardo Ribalda References: <20250129-secs_to_jiffles-v1-1-35a5e16b9f03@chromium.org> From: Easwar Hariharan Content-Language: en-US In-Reply-To: <20250129-secs_to_jiffles-v1-1-35a5e16b9f03@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/29/2025 12:06 AM, Ricardo Ribalda wrote: > When running cocci in report mode, eg: > $make coccicheck M="$dir" MODE=report > > It returns this error: > virtual rule report not supported > coccicheck failed > make: *** [Makefile:251: __sub-make] Error 2 > > Create a dummy rule to avoid this error and run the other cocci scripts. > > Fixes: 551dbd1ec7ff ("coccinelle: misc: add secs_to_jiffies script") > Signed-off-by: Ricardo Ribalda > --- > scripts/coccinelle/misc/secs_to_jiffies.cocci | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci > index 8bbb2884ea5d..2d85dca16418 100644 > --- a/scripts/coccinelle/misc/secs_to_jiffies.cocci > +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci > @@ -10,6 +10,7 @@ > // > > virtual patch > +virtual report > > @depends on patch@ constant C; @@ > > @@ -20,3 +21,8 @@ virtual patch > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > + > +// Dummy rule for report mode that would otherwise be empty and make spatch > +// fail ("No rules apply.") > +@script:python depends on report@ > +@@ > Sorry about that, and thanks for the patch! FWIW, Reviewed-by: Easwar Hariharan