From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 910B37765D for ; Wed, 24 Jan 2024 12:34:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706099663; cv=none; b=j/0sTrgFtlv9JnjMVz05WTyzRmo2/S9J7MCiZUy+VZ4VRxCOAuCRPh8guRyM1bSi4JEQbnse5HEYYN2EGg8qFGFGjTWan9jo4+s5RMPdGQLQcuZVkmHtmztLaJm5n8lB1C8Y6Oek0mt3Gy729FPcUiF0dY0UcO5ZwfAgHA4WRrA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706099663; c=relaxed/simple; bh=jyvSiO7pP8IS2juBo4PIGtSrz/acm4bNYI4ZPwuqEYA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gNS/wzGO6cDbaWS1UKlFk8yFC/xOhN9WJFRBgJwFN3pIThlI2pkFpbM718Me8ZBdwlAhDPLkDyUK7f29ICAsqECHmQpUtYRAFxXzpnKwyLyPTUoo3DF251Ojp7+t5BFevBDNTbZOImIaFa53wJf9CR8ukk8lWPjYQUOirvPLFpE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=g8yeZPCM; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="g8yeZPCM" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-510133ed214so556053e87.1 for ; Wed, 24 Jan 2024 04:34:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706099660; x=1706704460; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=P6RopD7J40Mytb9WIDlcCfTBz6ZKZHDbcmtWKYlQzcI=; b=g8yeZPCMoSSl/66Gbay5hM4HuKgGT9RUqr0MHECPOhg12FK2pQ4La74oi6SSo2npgr USSvOt2ST5ZbfDFQTLADgj3Qjy3Fnd4ydkF95jrNSo5ZAGMjM1JODqAdKUKSGV31L0P3 IXwe1bceDZuutfMDNbMjZVKtVw66I6MqSli4wLKPTJq0LAbkizOC5Cn3u6G0S66mO4lK +wKXLED9P5vcg0VAug9aidTvcZ2kc0nj0LNJwqt6azSmcc5EFrmeo43st45H/6PAyNeh GOwSw2CzHbhVHjPaerSYJ04MkaPufGSV54/5WWBhAmQmbp9Ya94oefhu8DMuDGIqrCEW Svog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706099660; x=1706704460; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P6RopD7J40Mytb9WIDlcCfTBz6ZKZHDbcmtWKYlQzcI=; b=r3/4KFd6saqPa95R22zNIXFIhrrUSE0a/PzNLPRAws8b5EsVAQA8OjRINWChDW8ipc ySVtptOhs4jw3Fbp8TLeA+F9HKYjsI639rFBKSGbPGgdwVmDzDrwjVNPRFBBZl0bk+QY Ozq2wKLbdztXkxQeeVMtKwC71Y/ZH5H7PNoMwbam6K1+v4sziRsCze/3oYHEf2vAY/ZE NUFo1A9zggrcAKoi/YZdSkK67donr/t3bUskVBg6pQttqx7Fe6UnO0oRynaTHcd2Xbr3 bOrIexFv2UVHIjqeo6CyXUAMWVfhO32naExD2H6v2e+VbGFjW/F64KxnssC0zlW9ly14 AOPg== X-Gm-Message-State: AOJu0YxtUbpzUVS/G7RSS8fJDgfBiWmZaq89EvTMjrxs9PHjJFrWLKmq 0KTCkh3JfAPdrLUHfkbgM8tj8OBk/PKoDgoYpzmFHTB5jA7QUoO8s/n+1HvK0Sk= X-Google-Smtp-Source: AGHT+IFxrZhUS4GmLbPy+Or25khi6S/3hoZURFv44UJtwh7pvfKXw7sXxdDDR8uIyYRgssXe7kwJ7w== X-Received: by 2002:a05:6512:202:b0:510:40a:4cb2 with SMTP id a2-20020a056512020200b00510040a4cb2mr1512683lfo.38.1706099659702; Wed, 24 Jan 2024 04:34:19 -0800 (PST) Received: from [172.30.205.123] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id p26-20020a19f01a000000b005100ed58b76sm207756lfc.308.2024.01.24.04.34.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jan 2024 04:34:19 -0800 (PST) Message-ID: Date: Wed, 24 Jan 2024 13:34:18 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] thermal/drivers/tsens: Add suspend to RAM support for tsens Content-Language: en-US To: Priyansh Jain , Amit Kucheria , Thara Gopinath , Bjorn Andersson , "Rafael J . Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: quic_manafm@quicinc.com References: <20240122100726.16993-1-quic_priyjain@quicinc.com> <548e2f24-a51e-4593-9463-09506488c70e@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/24/24 11:42, Priyansh Jain wrote: > > > On 1/22/2024 8:02 PM, Konrad Dybcio wrote: >> On 22.01.2024 11:07, Priyansh Jain wrote: >>> Add suspend callback support for tsens which disables tsens interrupts >>> in suspend to RAM callback. >> >> Would it not be preferrable to have the "critical overheat", wakeup- >> capable interrupts be enabled, even if the system is suspended? >> > > > As part of suspend to RAM, tsens hardware will be turned off and it cannot generate any interrupt.Also system doesn't want to abort suspend to RAM due to tsens interrupts since system is already going into lowest > power state. Hence disabling tsens interrupt during suspend to RAM callback. Is that a hardware limitation, or a software design choice? I'm not sure I want my phone to have thermal notifications disabled when it's suspended. Konrad