From: Ian Abbott <abbotti@mev.co.uk>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Spencer E. Olson" <olsonse@umich.edu>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: tio: fix multiple missing break in switch bugs
Date: Fri, 12 Oct 2018 10:04:02 +0100 [thread overview]
Message-ID: <aeb0ea08-86bc-3ce7-ea93-a68b2d522ed0@mev.co.uk> (raw)
In-Reply-To: <20181011190520.GA12609@embeddedor.com>
On 11/10/2018 20:05, Gustavo A. R. Silva wrote:
> Currently, there are multiple missing break statements in two switch code
> blocks. This makes the execution path to fall all the way down through
> to the default cases, which makes the function ni_tio_set_gate_src() to
> always return -EINVAL.
>
> Fix this by adding the missing break statements.
>
> Also, notice that due to the absence of the break statements,
> the following pieces of code are unreachable:
>
> 1078 if (ret)
> 1079 return ret;
> 1080 /* 3. reenable & set mode to starts things back up */
> 1081 ni_tio_set_gate_mode(counter, src);
>
> 1098 if (ret)
> 1099 return ret;
> 1100 /* 3. reenable & set mode to starts things back up */
> 1101 ni_tio_set_gate2_mode(counter, src);
>
> So, by adding the missing breaks, this patch also fixes the problem
> above.
>
> Addresses-Coverity-ID: 1474165 ("Missing break in switch")
> Addresses-Coverity-ID: 1474162 ("Structurally dead code")
> Fixes: 347e244884c3 ("staging: comedi: tio: implement global tio/ctr routing")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/staging/comedi/drivers/ni_tio.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/drivers/staging/comedi/drivers/ni_tio.c
> index 838614e..0eb388c 100644
> --- a/drivers/staging/comedi/drivers/ni_tio.c
> +++ b/drivers/staging/comedi/drivers/ni_tio.c
> @@ -1070,8 +1070,10 @@ int ni_tio_set_gate_src(struct ni_gpct *counter,
> case ni_gpct_variant_e_series:
> case ni_gpct_variant_m_series:
> ret = ni_m_set_gate(counter, chan);
> + break;
> case ni_gpct_variant_660x:
> ret = ni_660x_set_gate(counter, chan);
> + break;
> default:
> return -EINVAL;
> }
> @@ -1090,8 +1092,10 @@ int ni_tio_set_gate_src(struct ni_gpct *counter,
> switch (counter_dev->variant) {
> case ni_gpct_variant_m_series:
> ret = ni_m_set_gate2(counter, chan);
> + break;
> case ni_gpct_variant_660x:
> ret = ni_660x_set_gate2(counter, chan);
> + break;
> default:
> return -EINVAL;
> }
>
Thanks for catching that bug!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address: )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
next prev parent reply other threads:[~2018-10-12 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 19:05 Gustavo A. R. Silva
2018-10-12 9:04 ` Ian Abbott [this message]
2018-10-12 9:06 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeb0ea08-86bc-3ce7-ea93-a68b2d522ed0@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olsonse@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®