From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Vincent Shih <vincent.sunplus@gmail.com>,
gregkh@linuxfoundation.org, stern@rowland.harvard.edu,
p.zabel@pengutronix.de, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, wells.lu@sunplus.com
Subject: Re: [PATCH v2 2/2] dt-bindings: usb: Add bindings doc for Sunplus EHCI driver
Date: Sun, 27 Feb 2022 11:53:31 +0100 [thread overview]
Message-ID: <aeb85444-e280-8c53-a0ba-f8d21f28975b@canonical.com> (raw)
In-Reply-To: <1645955441-6496-3-git-send-email-vincent.sunplus@gmail.com>
On 27/02/2022 10:50, Vincent Shih wrote:
> Add bindings doc for Sunplus EHCI driver
>
> Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com>
> ---
> .../bindings/usb/sunplus,sp7021-usb-ehci.yaml | 97 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 98 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml b/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml
> new file mode 100644
> index 0000000..e492f7a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml
> @@ -0,0 +1,97 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd. 2021
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/sunplus,sp7021-usb-ehci.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sunplus SP7021 EHCI Device Tree bindings for ehci0/ehci1
> +
> +maintainers:
> + - Vincent Shih <vincent.sunplus@gmail.com>
> +
> +allOf:
> + - $ref: usb-hcd.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - sunplus,sp7021-usb-ehci0
> + - sunplus,sp7021-usb-ehci1
How did you address Rob's comments about using one one compatible? You
still have two.
> +
> + clocks:
> + maxItems: 2
> +
> + clock-names:
> + items:
> + - const: usbc_clk
> + - const: uphy_clk
> +
> + resets:
> + maxItems: 2
> +
> + reset-names:
> + items:
> + - const: usbc_rst
> + - const: uphy_rst
> +
> + reg:
> + items:
> + - description: USBC register region
> + - description: UPHY register region
> + - description: MOON4 register region
> +
> + reg-names:
> + items:
> + - const: usbc
> + - const: uphy
> + - const: moon4
> +
> + interrupts:
> + maxItems: 1
> +
> + nvmem-cell-names:
> + description: names corresponding to the nvmem cells of disconnect voltage
> + const: disc_vol
> +
> + nvmem-cells:
> + description: nvmem cell address of disconnect voltage
> + maxItems: 1
> +
> + port-num:
> + description: identify ehci0 (port0) and ehci1 (port1)
This still should be a dedicated PHY driver referenced here.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-02-27 10:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 9:50 [PATCH v2 0/2] Add driver for ehci in Sunplus SP7021 Vincent Shih
2022-02-27 9:50 ` [PATCH v2 1/2] usb: host: ehci-sunplus: " Vincent Shih
2022-02-27 16:07 ` Alan Stern
2022-02-27 9:50 ` [PATCH v2 2/2] dt-bindings: usb: Add bindings doc for Sunplus EHCI driver Vincent Shih
2022-02-27 10:53 ` Krzysztof Kozlowski [this message]
2022-02-28 2:44 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeb85444-e280-8c53-a0ba-f8d21f28975b@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=vincent.sunplus@gmail.com \
--cc=wells.lu@sunplus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®