From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E402011CA9 for ; Sun, 19 Jul 2026 13:53:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784469200; cv=none; b=gh5rqNemswhwDAbX6kqD77QnbhuDslsMRb7at0IfD38Ec/Qv7Yo64Q+DfW0NeobphpDK2Mq2xiWJYt0LT/Pk8F9SMw9NqjdDoVLUjzwL082Jn3/U5P4ioNXCY0xl3Gw+bmXrcOo5luKNSe1KP58eU8H4nt7snwbZ5pMBWLQg1oE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784469200; c=relaxed/simple; bh=K+P5R6wAclwOFM86ZUqkNFpSNByvTQ8SFaF2Kx/AkcA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MQ47AV3tWaIV4sxpKdtWD/CaFRi70sYhpTS7uysH0p5rT+FsgaDhAR0C5TBYqU55QwPwCxpCEUKYc2tIhxJf+cTAY/k1O89PKOYuY8akYFkfOqBg5StgUi4YTQ2Gn9ZIoXsPsDcXSfYXxOEByF1Yz1ohrvgyheC09S4vIMYBpLI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nxHtsd1i; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nxHtsd1i" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2ceb096e675so89297195ad.0 for ; Sun, 19 Jul 2026 06:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784469198; x=1785073998; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=1nuOr72UPwe1KUQeAbUU34Et7h55j9VwtvONRGN6oj8=; b=nxHtsd1i1Lyu2/RmhPm5UqhFXLIyhTpd0jtIbFyOQPJCzMXCuuavktphQx/uXtv39I +cBOb/FVNRGiKn6Aml543rf4Dd00xleRkX1HPQirz57W/Ju8mTF3xOU+3DDy5/Aa9Y9U F/JpGszeEmDyGMk/zJx9cUSKlTYAI6YJv2TK3MTdTg+Xz5jYnEySPp8DY+PpIw1nza2l mJ70iLcWK98V1pVg7mrP9peLRydQ7SLBnkY0kmu4NPy8IrMOiFzPXq4K5bbsB5Q3gz86 IMOfu+uZrH4OMwJPQoYfopAmKRRzHjoq2shPca3a+R1Gs54p5v/RUslkkxo6oEmcHtJN M/CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784469198; x=1785073998; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1nuOr72UPwe1KUQeAbUU34Et7h55j9VwtvONRGN6oj8=; b=jZHCEEuxaikjbiFekvOZuWK/Nne4rUdMKaTPRaQgwB2pzktlJWCOfc/iHc9c+XORkT a1oKPJhiimXe851Ce8r32vXJ29/syQsImGKhQc7p3qjp6SX37/4WvaqS5cCmJubkoVoV hgoRYD/icQ6Um6hA3O5Jc994NyKGqo4/gszRjqYvXWAfhwd1poRdKEJYGL7WhZ2pKX5J R8PFOvmE5HpWxQPBr0ocTgibDp0gHlyQCqogrgm2NLA513yfDb01ARu5JSf/EpaBdFaA NpDhKFDy+iuTwSQlwyDBOcxd5jh6QuVH774tmQPl9Ex3LojPeSUFRO8K24aDRZ+QhnQa KhZA== X-Forwarded-Encrypted: i=1; AHgh+RpEI1oKJxClZPlfYR6paMvWZyyxU/4BX+EfMz2LJshHXpxI/qay/QQ9LAiZ5bhJ5mTiVMvCDUSQgKbTDOQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9cMkVunbC9ehZhmzag7t88gpH/MudtulCeemamgUp6x4x63q/ YEHAj5JDV4mf1I/XvpZht2IbhXCVlifynZep+nptI3KqYbLnz0zRWl9h X-Gm-Gg: AfdE7cly3L5W3uQERfSJwnVVSk4fcXHfDxuaHnx9cHC2oRXL6XQIbVEBNSzf+GwMhfa 4Aihk7wkfTbbiPsZ2Vs5AlabxBPSTgDKN2HvzpxlnJnjIVxRJoUTzsQQWHr7eQKFxIoHP1/im5t 97gnQebr5Dod/7mTNp8iObObLkBkFR7U6U6O19RqLDnXVJjyBXC2F3Q50f8nWHamK70lbfB7GLl nddxJJm7wR1Rtw1tnJxiav2NjNQBBDQ9uU4IqhUgWLmptfFGbABZXGfDzBqonXJtKNdDMBojXZN aBGzSoYPvwYy79ifi/xPxDott7jJdTVyWpWpTCQ/fRvs8EQ9UGHG3MaxJ+ah0Ns57Zdv8wRiJ6K QG41PtANRMn1ukD/1EMZtDGZr0VW8y0KrIT+R9/cHXP6itsKUod5cvW/4C0O1kpTjIGrdvZYqig UzEkHQ2vLSn/aSl0o= X-Received: by 2002:a17:903:b8b:b0:2c9:cf5d:d9b8 with SMTP id d9443c01a7336-2cf349a4e71mr120661285ad.33.1784469198194; Sun, 19 Jul 2026 06:53:18 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf344cf96bsm41125915ad.28.2026.07.19.06.53.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 06:53:17 -0700 (PDT) Sender: Guenter Roeck Date: Sun, 19 Jul 2026 06:53:16 -0700 From: Guenter Roeck To: Alexis Czezar Torreno Cc: Kun Yi , Nuno =?iso-8859-1?Q?S=E1?= , Jonathan Corbet , Shuah Khan , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 1/3] hwmon: (pmbus/max34440): block unsupported VIN and IIN limit registers Message-ID: References: <20260716-max34451_fixes-v1-0-a941b27eaecb@analog.com> <20260716-max34451_fixes-v1-1-a941b27eaecb@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260716-max34451_fixes-v1-1-a941b27eaecb@analog.com> On Thu, Jul 16, 2026 at 04:25:11PM +0800, Alexis Czezar Torreno wrote: > MAX34451 and ADPM chips do not support standard PMBus VIN/IIN limit > registers, manufacturer specific min/max registers, or undercurrent > or undertemperature fault limits. STATUS_BYTE and STATUS_OTHER are also > not available. Accessing these non-existent registers during driver > initialization triggers a CML error and asserts ALERT. Handled by > blocking these functions during read/write. > > Fixes: 7a001dbab4ad ("hwmon: (pmbus/max34440) Add support for MAX34451.") > Fixes: 629cf8f6c23a ("hwmon: (pmbus/max34440) Add support for ADPM12160") > Fixes: 2e0b52f1ae88 ("hwmon: (pmbus/max34440): add support adpm12200") > Fixes: 479bfeba2eb6 ("hwmon: (pmbus/max34440): add support adpm12250") > Tested-by: Alexis Czezar Torreno That is implied. Please only use Tested-by: tags if someone else tested the patch. > Signed-off-by: Alexis Czezar Torreno Applied. Thanks, Guenter