mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Erick Karanja <karanja99erick@gmail.com>,
	outreachy@lists.linux.dev, philipp.g.hortmann@gmail.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: rtl8723bs: Initialize local variables at declaration
Date: Sat, 5 Apr 2025 17:21:53 +0300	[thread overview]
Message-ID: <aec43d5d-8f9f-4951-9ddb-03b66b1ce859@stanley.mountain> (raw)
In-Reply-To: <ef088d6-cec1-9758-cc0-55fb66ca952@inria.fr>

On Sat, Apr 05, 2025 at 04:41:37AM -0400, Julia Lawall wrote:
> 
> I guess the first change above would be ok though.

Here is the first change:

-	struct xmit_priv *pxmitpriv;
+	struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
  	u8 queue_empty, queue_pending;
  	s32 ret;

-
-	pxmitpriv = &padapter->xmitpriv;
-

Yes.  This is a nice change.

regards,
dan carpenter


      reply	other threads:[~2025-04-05 14:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-05  3:14 [PATCH 0/2] Simplify local variable initialization Erick Karanja
2025-04-05  3:14 ` [PATCH 1/2] staging: rtl8723bs: Optimize variable initialization in rtl8723b_hal_init.c Erick Karanja
2025-04-05  7:39   ` Greg KH
2025-04-05  8:39     ` Julia Lawall
2025-04-05  8:45   ` Julia Lawall
2025-04-05 10:22     ` Erick Karanja
2025-04-05 10:27       ` Julia Lawall
2025-04-05 10:35         ` Erick Karanja
2025-04-05 10:38           ` Julia Lawall
2025-04-05 14:19   ` Dan Carpenter
2025-04-05 14:28     ` Julia Lawall
2025-04-05 14:43       ` Erick Karanja
2025-04-06  4:11     ` Erick Karanja
2025-04-05  3:14 ` [PATCH 2/2] staging: rtl8723bs: Initialize local variables at declaration Erick Karanja
2025-04-05  7:37   ` Greg KH
2025-04-05  8:41     ` Julia Lawall
2025-04-05 14:21       ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aec43d5d-8f9f-4951-9ddb-03b66b1ce859@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=julia.lawall@inria.fr \
    --cc=karanja99erick@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®