mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Kiryl Shutsemau <kas@kernel.org>
Cc: Lance Yang <lance.yang@linux.dev>,
	akpm@linux-foundation.org, ziy@nvidia.com,
	baolin.wang@linux.alibaba.com, liam@infradead.org,
	nico.pache@linux.dev, ryan.roberts@arm.com, dev.jain@arm.com,
	baohua@kernel.org, usama.arif@linux.dev, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] mm/huge_memory: disallow raw PMD mappings of the huge zero page
Date: Fri, 18 Sep 2026 22:32:01 +0200	[thread overview]
Message-ID: <aec6769f-dbd4-4dfb-acd6-63ba93db89f3@kernel.org> (raw)
In-Reply-To: <aqwPHfWhKGty-Q_4@thinkstation>

On 9/17/26 18:03, Kiryl Shutsemau wrote:
> On Thu, Sep 17, 2026 at 05:29:48PM +0200, David Hildenbrand (Arm) wrote:
>> On 9/17/26 16:32, Kiryl Shutsemau wrote:
>>>
>>> The patch looks fine, but don't we want to cover the same for non-huge
>>> zero page in vmf_insert_pfn_prot()?
>>
>> Why would the zeropage be a problem in PFNMAP mapping?
> 
> Nothing enforces that it is read-only.

Well, ok, that at least would be easy to check.

There are other reasons why we'd want to disallow it ... similar to the check in
vm_mixed_ok().

Which reminds me that we should try getting rid of vmf_insert_mixed() at some
point ... but it's tricky.

-- 
Cheers,

David

  parent reply	other threads:[~2026-09-18 20:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17 12:10 Lance Yang
2026-09-17 14:32 ` Kiryl Shutsemau
2026-09-17 15:29   ` David Hildenbrand (Arm)
2026-09-17 16:03     ` Kiryl Shutsemau
2026-09-18  2:52       ` Lance Yang
2026-09-18 10:16         ` Kiryl Shutsemau
2026-09-18 20:37         ` David Hildenbrand (Arm)
2026-09-18 20:32       ` David Hildenbrand (Arm) [this message]
2026-09-17 15:38 ` David Hildenbrand (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aec6769f-dbd4-4dfb-acd6-63ba93db89f3@kernel.org \
    --to=david@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=dev.jain@arm.com \
    --cc=kas@kernel.org \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nico.pache@linux.dev \
    --cc=ryan.roberts@arm.com \
    --cc=usama.arif@linux.dev \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®