mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Magnus Damm" <magnus.damm@gmail.com>
To: "Arjan van de Ven" <arjan@infradead.org>
Cc: "Magnus Damm" <magnus@valinux.co.jp>,
	"Linux Kernel" <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org
Subject: Re: [PATCH 00/03] Unmapped: Separate unmapped and mapped pages
Date: Sat, 11 Mar 2006 20:52:53 +0900	[thread overview]
Message-ID: <aec7e5c30603110352u4a18825ai1aaa6c5eac04685d@mail.gmail.com> (raw)
In-Reply-To: <1141999506.2876.45.camel@laptopd505.fenrus.org>

On 3/10/06, Arjan van de Ven <arjan@infradead.org> wrote:
> On Fri, 2006-03-10 at 14:19 +0100, Magnus Damm wrote:
> > My current code just extends this idea which basically means that
> > there is currently no relation between how many pages that sit in each
> > LRU. The LRU with the largest amount of pages will be shrunk/rotated
> > first. And on top of that is the guarantee logic and the
> > reclaim_mapped threshold, ie the unmapped LRU will be shrunk first by
> > default.
>
> that sounds wrong, you lose history this way. There is NO reason to
> shrink only the unmapped LRU and not the mapped one. At minimum you
> always need to pressure both. How you pressure (absolute versus
> percentage) is an interesting question, but to me there is no doubt that
> you always need to pressure both, and "equally" to some measure of equal

Regarding if shrinking the unmapped LRU only is bad or not: In the
vanilla version of refill_inactive_zone(), if reclaim_mapped is false
then mapped pages are rotated on the active list without the
young-bits are getting cleared in the PTE:s. I would say this is very
similar to leaving the pages on the mapped active list alone as long
as reclaim_mapped is false in the dual LRU case. Do you agree?

Also, losing history, do you mean that the order of the pages are not
kept? If so, then I think my refill_inactive_zone() rant above shows
that the order of the pages are not kept today. But yes, keeping the
order is probaly a good idea.

It would be interesting to hear what you mean by "pressure", do you
mean that both the active list and inactive list are scanned?

Many thanks,

/ magnus

  reply	other threads:[~2006-03-11 11:52 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-10  3:44 Magnus Damm
2006-03-10  3:44 ` [PATCH 01/03] Unmapped: Implement two LRU:s Magnus Damm
2006-03-10 19:16   ` Christoph Lameter
2006-03-11 12:14     ` Magnus Damm
2006-03-10  3:44 ` [PATCH 02/03] Unmapped: Modify LRU behaviour Magnus Damm
2006-03-10  3:44 ` [PATCH 03/03] Unmapped: Add guarantee code Magnus Damm
2006-03-10  4:57   ` Nick Piggin
2006-03-10  6:04     ` Magnus Damm
2006-03-10 15:41       ` Chandra Seetharaman
2006-03-11 12:29         ` Magnus Damm
2006-03-15 15:32           ` Chandra Seetharaman
2006-03-10  4:55 ` [PATCH 00/03] Unmapped: Separate unmapped and mapped pages Nick Piggin
2006-03-10  5:55   ` Magnus Damm
2006-03-10  7:52 ` Arjan van de Ven
2006-03-10 13:19   ` Magnus Damm
2006-03-10 14:05     ` Arjan van de Ven
2006-03-11 11:52       ` Magnus Damm [this message]
2006-03-11 20:58     ` Peter Zijlstra
2006-03-13  2:28       ` Magnus Damm
2006-03-10 12:22 ` Peter Zijlstra
2006-03-10 13:38   ` Magnus Damm
2006-03-11 21:08     ` Peter Zijlstra
2006-03-13  3:05       ` Magnus Damm
2006-03-10 19:12 ` Christoph Lameter
2006-03-11 11:56   ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aec7e5c30603110352u4a18825ai1aaa6c5eac04685d@mail.gmail.com \
    --to=magnus.damm@gmail.com \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=magnus@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®