From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1750780AbWEADHj@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1750780AbWEADHj (ORCPT <rfc822;willy@w.ods.org>);
	Sun, 30 Apr 2006 23:07:39 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750789AbWEADHj
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sun, 30 Apr 2006 23:07:39 -0400
Received: from pproxy.gmail.com ([64.233.166.183]:43484 "EHLO pproxy.gmail.com")
	by vger.kernel.org with ESMTP id S1750780AbWEADHi convert rfc822-to-8bit
	(ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 30 Apr 2006 23:07:38 -0400
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=nnwJwFEMBwYbTRF0OiX85OEqjhFvdlX0ZMeTbHD5LWzthSttfRiROrT3J/CA3R9Enac37Am1vcAhZ99lm6GOPwxsLWGLyUNM4CdsIjcRtyXJpym7W76yrIMBsJdAGe/fYoU3XUbdsX7BysvrhKmHdfpy+DAFrBQzLJKcZRjP7b0=
Message-ID: <aec7e5c30604302007q78c5aec8n6e6da5f34b95b29b@mail.gmail.com>
Date: Mon, 1 May 2006 12:07:37 +0900
From: "Magnus Damm" <magnus.damm@gmail.com>
To: "Dave McCracken" <dmccr@us.ibm.com>
Subject: Re: i386 and PAE: pud_present()
Cc: "Andi Kleen" <ak@suse.de>, "Nick Piggin" <nickpiggin@yahoo.com.au>,
       "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
       "Linux Memory Management" <linux-mm@kvack.org>
In-Reply-To: <2432524299CCD3CA89BB647D@10.1.1.4>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
	format=flowed
Content-Transfer-Encoding: 7BIT
Content-Disposition: inline
References: <aec7e5c30604280040p60cc7c7dqc6fb6fbdd9506a6b@mail.gmail.com>
	 <4451CA41.5070101@yahoo.com.au> <200604281027.22183.ak@suse.de>
	 <2432524299CCD3CA89BB647D@10.1.1.4>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/30/06, Dave McCracken <dmccr@us.ibm.com> wrote:
>
> --On Friday, April 28, 2006 10:27:21 +0200 Andi Kleen <ak@suse.de> wrote:
>
> >> Take a look a little further down the page for the comment.
> >>
> >> In i386 + PAE, pud is always present.
> >
> > I think his problem is that the PGD is always present too (in
> > pgtables-nopud.h) Indeed looks strange.
>
> The PGD is always fully populated on i386 if PAE is enabled.  All three of
> the pmd pages are allocated at page table creation time and persist till
> the page table is deleted.

The following code snippet is from some kexec patch of mine. The
function is used to build a new set of page tables which are used when
jumping to the new kernel.

The code should be pretty archtecture independent - the same code
works on x86 and x86_64. And x86/PAE with a workaround.

#ifdef CONFIG_X86_PAE
#undef pud_present
#define pud_present(pud) (pud_val(pud) & _PAGE_PRESENT)
#endif

#define pa_page(page) __pa(page_address(page))

static int create_mapping(struct page *root, struct page **pages,
			  unsigned long va, unsigned long pa)
{
	pgd_t *pgd;
	pud_t *pud;
	pmd_t *pmd;
	pte_t *pte;
	int k = 0;

	pgd = (pgd_t *)page_address(root) + pgd_index(va);
	if (!pgd_present(*pgd))
		set_pgd(pgd, __pgd(pa_page(pages[k++]) | _KERNPG_TABLE));

	pud = pud_offset(pgd, va);
	if (!pud_present(*pud))
		set_pud(pud, __pud(pa_page(pages[k++]) | _KERNPG_TABLE));

	pmd = pmd_offset(pud, va);
	if (!pmd_present(*pmd))
		set_pmd(pmd, __pmd(pa_page(pages[k++]) | _KERNPG_TABLE));

	pte = (pte_t *)page_address(pmd_page(*pmd)) + pte_index(va);
	set_pte(pte, __pte(pa | _PAGE_KERNEL_EXEC));

	return k;
}

Any comments?

/ magnus