From: "Magnus Damm" <magnus.damm@gmail.com>
To: "Uwe Kleine-König" <Uwe.Kleine-Koenig@digi.com>
Cc: "Alan Cox" <alan@lxorguk.ukuu.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gregkh@suse.de" <gregkh@suse.de>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"hjk@linutronix.de" <hjk@linutronix.de>,
"lethal@linux-sh.org" <lethal@linux-sh.org>,
"tglx@linutronix.de" <tglx@linutronix.de>
Subject: Re: [PATCH] uio: uio_pdrv_genirq V2
Date: Fri, 11 Jul 2008 15:15:02 +0900 [thread overview]
Message-ID: <aec7e5c30807102315i3048f68q245a4fbdfe89b1b2@mail.gmail.com> (raw)
In-Reply-To: <20080710103036.GA32507@digi.com>
On Thu, Jul 10, 2008 at 7:30 PM, Uwe Kleine-König
<Uwe.Kleine-Koenig@digi.com> wrote:
> Alan Cox wrote:
>>
>> > > + else if (!irq_on && !priv->irq_disabled)
>> > > + disable_irq(dev_info->irq);
>> > I'm not sure if this is a problem on SMP. Should you use
>> > disable_irq_nosync here, too? Probably it's OK.
>>
>> That one will also deadlock.
> Can you explain why? I think irqcontrol is only called in task context.
> I only see one possible deadlock and that's disable_irq being called
> while the irq is IRQ_INPROGRESS on the same cpu. I'm always willing to
> learn.
>
>> The easiest fix is probably to use test_and_set and friends for each I/O
>> operation.
> Actually using spinlock + irq_disabled variable is new in V2 of this
> patch. Don't know why this changed, though.
Sorry for not being more clear about it. Basically, I wanted to
serialize user space access somehow, but I managed to screw it up. =)
Atomic enable-and-disable operations without serialization has this problem:
irq line state task0 task1
enabled enabled write "0"
if (!test_and_set_bit())
enabled disabled
write "1"
if (test_and_clear_bit())
enable_irq() <- ERR
disable_irq()
ERR will make the interrupt depth counter underflow.
The best solution in my mind is atomic operations,
disable_irq_nosync() in irq handler only, and serialize user space
only - not the irq handler.
Or maybe the UIO core layer should serialization in the case of multiple tasks?
/ magnus
next prev parent reply other threads:[~2008-07-11 6:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-10 3:52 Magnus Damm
2008-07-10 6:56 ` Uwe Kleine-König
2008-07-10 8:46 ` Alan Cox
2008-07-10 10:30 ` Uwe Kleine-König
2008-07-10 10:02 ` Alan Cox
2008-07-10 10:47 ` Uwe Kleine-König
2008-07-11 6:15 ` Magnus Damm [this message]
2008-07-10 10:58 ` Hans J. Koch
2008-07-10 11:06 ` Uwe Kleine-König
2008-07-10 13:49 ` Hans J. Koch
2008-07-11 8:45 ` Magnus Damm
2008-07-11 9:00 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec7e5c30807102315i3048f68q245a4fbdfe89b1b2@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=Uwe.Kleine-Koenig@digi.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=hjk@linutronix.de \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®