From: Magnus Damm <magnus.damm@gmail.com>
To: Frans Pop <elendil@planet.nl>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Erik Ekman <erik@kryo.se>, Alan Cox <alan@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 -tip][RFC] serial8250: update to dev_pm_ops
Date: Mon, 27 Jul 2009 11:57:10 +0900 [thread overview]
Message-ID: <aec7e5c30907261957x2793e8b9m8183bba0c3c2539f@mail.gmail.com> (raw)
In-Reply-To: <200907262252.41429.elendil@planet.nl>
On Mon, Jul 27, 2009 at 5:52 AM, Frans Pop<elendil@planet.nl> wrote:
> On Sunday 26 July 2009, Rafael J. Wysocki wrote:
>> In fact, I wouldn't advise anyone to do these conversions mechanically.
>
> With hindsight I'd say you are correct.
>
> In that case would it maybe have been better to have a build time warning
> about the need to convert drivers rather than a run time one? Run time
> warnings have a much higher annoyance factor and will thus "invite" more
> people into having a shot at getting rid of them.
I'm the one who added the runtime warning and I agree that a build
time warning would have been more suitable. Exacly how to implement
that in this specific case is another question. I'm open to
suggestions. =)
The purpose was simply to move over to the new interface sooner than later.
> But I guess partly it's also just the nature of this change: it looks
> trivial due to the corresponding terms.
It should be pretty trivial. The tricky part is what gets used when in
the cases of CONFIG_HIBERNATION and CONFIG_SUSPEND. The dev_pm_ops
comment in include/linux/pm.h should guide people in the right
direction.
Thanks for your help!
/ magnus
next prev parent reply other threads:[~2009-07-27 2:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 6:37 [PATCH " Erik Ekman
2009-07-08 11:10 ` Frans Pop
2009-07-08 13:43 ` Alan Cox
2009-07-25 14:12 ` Frans Pop
2009-07-25 20:18 ` Rafael J. Wysocki
2009-07-25 20:59 ` [PATCH v2 " Erik Ekman
2009-07-26 0:52 ` Dmitry Torokhov
2009-07-26 19:45 ` Rafael J. Wysocki
2009-07-26 20:52 ` Frans Pop
2009-07-26 22:38 ` Rafael J. Wysocki
2009-07-27 2:57 ` Magnus Damm [this message]
2009-08-03 10:42 ` Erik Ekman
2009-07-25 20:22 ` [PATCH " Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec7e5c30907261957x2793e8b9m8183bba0c3c2539f@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=alan@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=elendil@planet.nl \
--cc=erik@kryo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®