From: Magnus Damm <magnus.damm@gmail.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Alan Stern <stern@rowland.harvard.edu>, Greg KH <gregkh@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH update] PM: Introduce core framework for run-time PM of I/O devices (rev. 11)
Date: Fri, 31 Jul 2009 23:32:13 +0900 [thread overview]
Message-ID: <aec7e5c30907310732u35faa15fpab070025f596463e@mail.gmail.com> (raw)
In-Reply-To: <200907222110.47701.rjw@sisk.pl>
Hi Rafail
[Runtime PM v11]
Thanks for your work on this. The code is getting better and better.
I've just finished posting a bunch of patches related to v11 of your
Runtime PM patch. Basically everything seems fine except a few minor
details and the code below: =)
On Thu, Jul 23, 2009 at 4:10 AM, Rafael J. Wysocki<rjw@sisk.pl> wrote:
> On Wednesday 22 July 2009, Rafael J. Wysocki wrote:
> Index: linux-2.6/drivers/base/dd.c
> ===================================================================
> --- linux-2.6.orig/drivers/base/dd.c
> +++ linux-2.6/drivers/base/dd.c
> @@ -23,6 +23,7 @@
> #include <linux/kthread.h>
> #include <linux/wait.h>
> #include <linux/async.h>
> +#include <linux/pm_runtime.h>
>
> #include "base.h"
> #include "power/power.h"
> @@ -202,7 +203,9 @@ int driver_probe_device(struct device_dr
> pr_debug("bus: '%s': %s: matched device %s with driver %s\n",
> drv->bus->name, __func__, dev_name(dev), drv->name);
>
> + pm_runtime_get_noresume(dev);
> ret = really_probe(dev, drv);
> + pm_runtime_put_noidle(dev);
>
> return ret;
> }
This creates problems when drivers want to performing runtime resume
from within probe(). For more details please have a look at "[PATCH
04/04] video: Runtime PM hack for SuperH LCDC driver".
Cheers,
/ magnus
next prev parent reply other threads:[~2009-07-31 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-22 15:01 [PATCH] PM: Introduce core framework for run-time PM of I/O devices (rev. 10) Rafael J. Wysocki
2009-07-22 19:10 ` [PATCH update] PM: Introduce core framework for run-time PM of I/O devices (rev. 11) Rafael J. Wysocki
2009-07-31 14:32 ` Magnus Damm [this message]
2009-07-31 18:53 ` Rafael J. Wysocki
2009-08-03 3:26 ` Magnus Damm
2009-08-03 15:15 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec7e5c30907310732u35faa15fpab070025f596463e@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®