From: Magnus Damm <magnus.damm@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-sh@vger.kernel.org, johnstul@us.ibm.com,
lethal@linux-sh.org
Subject: Re: [PATCH 02/02] clocksource: Start CMT at clocksource resume
Date: Mon, 30 Nov 2009 20:19:36 +0900 [thread overview]
Message-ID: <aec7e5c30911300319i115efdb6p215984377cb97f22@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0911281457560.24119@localhost.localdomain>
Hi Thomas,
On Sat, Nov 28, 2009 at 11:00 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Wed, 25 Nov 2009, Magnus Damm wrote:
>
>> From: Magnus Damm <damm@opensource.se>
>>
>> Add code to start the CMT timer on clocksource resume.
>>
>> This makes sure the timer is started during sysdev_resume().
>> Without this patch the clocksource may be read as suspended,
>> this after sysdev resume but before platform device resume.
>
> Hmm, don't you have the same situation on suspend ?
>
> platform device suspend stops the clock, but the generic code expects
> it to be running until sysdev shutdown.
You are correct, the same situation exists on suspend.
> Another thing is that you now run both, the sysdev and the platform
> resume. Is that by design or accident ?
By incorrect design. =)
To fix this properly I was thinking of adding a clocksource suspend()
callback and ditch the platform ops all together. If you don't mind
then I'll post a patch for that tomorrow!
Thank you!
/ magnus
prev parent reply other threads:[~2009-11-30 11:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 8:12 [PATCH 00/02] clocksource: SuperH CMT driver resume changes Magnus Damm
2009-11-25 8:12 ` [PATCH 01/02] clocksource: Add argument to resume callback Magnus Damm
2009-11-25 8:12 ` [PATCH 02/02] clocksource: Start CMT at clocksource resume Magnus Damm
2009-11-28 14:00 ` Thomas Gleixner
2009-11-30 11:19 ` Magnus Damm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec7e5c30911300319i115efdb6p215984377cb97f22@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=johnstul@us.ibm.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®