From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Hans de Goede" <hansg@kernel.org>, RenHai <kean0048@gmail.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] platform/x86: think-lmi: Add certificate GUID structure
Date: Thu, 28 Aug 2025 17:15:57 -0400 [thread overview]
Message-ID: <aec9c6b1-c578-4835-8f48-d1747a7388ab@app.fastmail.com> (raw)
In-Reply-To: <a5ecc59a-65bb-a270-9642-f2c59fc958ce@linux.intel.com>
On Thu, Aug 28, 2025, at 6:50 AM, Ilpo Järvinen wrote:
> On Mon, 25 Aug 2025, Mark Pearson wrote:
>
>> Add a certificate GUID structure to make it easier to add different
>> options for other platforms that need different GUIDs.
>>
>> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>> ---
>> Changes in v2:
>> - split patch up into series
>> Changes in v3:
>> - add field details to thinkpad_cert_guid declare.
>> - add missing comma
>> - Move null thumbprint GUID check to later in series
>>
>> drivers/platform/x86/lenovo/think-lmi.c | 38 +++++++++++++++++++------
>> 1 file changed, 30 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/platform/x86/lenovo/think-lmi.c b/drivers/platform/x86/lenovo/think-lmi.c
>> index 0992b41b6221..a22d25f6d3c6 100644
>> --- a/drivers/platform/x86/lenovo/think-lmi.c
>> +++ b/drivers/platform/x86/lenovo/think-lmi.c
>> @@ -177,6 +177,28 @@ MODULE_PARM_DESC(debug_support, "Enable debug command support");
>> #define TLMI_CERT_SVC BIT(7) /* Admin Certificate Based */
>> #define TLMI_CERT_SMC BIT(8) /* System Certificate Based */
>>
>> +struct tlmi_cert_guids {
>> + char *thumbprint;
>> + char *set_bios_setting;
>> + char *save_bios_setting;
>> + char *cert_to_password;
>> + char *clear_bios_cert;
>> + char *update_bios_cert;
>> + char *set_bios_cert;
>
> const char
>
yep.
>> +};
>> +
>> +static struct tlmi_cert_guids thinkpad_cert_guid = {
>
> These are not supposed to be altered, right? If so, this should be const
> then.
>
Weird...I could have sworn I made it a const. I'll fix
>> + .thumbprint = LENOVO_CERT_THUMBPRINT_GUID,
>> + .set_bios_setting = LENOVO_SET_BIOS_SETTING_CERT_GUID,
>> + .save_bios_setting = LENOVO_SAVE_BIOS_SETTING_CERT_GUID,
>> + .cert_to_password = LENOVO_CERT_TO_PASSWORD_GUID,
>> + .clear_bios_cert = LENOVO_CLEAR_BIOS_CERT_GUID,
>> + .update_bios_cert = LENOVO_UPDATE_BIOS_CERT_GUID,
>> + .set_bios_cert = LENOVO_SET_BIOS_CERT_GUID,
>> +};
>> +
>> +static struct tlmi_cert_guids *cert_guid = &thinkpad_cert_guid;
>
> const here as well. Please also note my comment on placement of this in
> patch 2.
Ack.
Thanks for the review
Mark
next prev parent reply other threads:[~2025-08-28 21:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 16:03 [PATCH v3 0/3] platform/x86: think-lmi: ThinkCenter certificate Mark Pearson
2025-08-25 16:03 ` [PATCH v3 1/3] platform/x86: think-lmi: Add certificate GUID structure Mark Pearson
2025-08-28 10:50 ` Ilpo Järvinen
2025-08-28 21:15 ` Mark Pearson [this message]
2025-08-25 16:03 ` [PATCH v3 2/3] platform/x86: think-lmi: Certificate support for ThinkCenter Mark Pearson
2025-08-28 10:46 ` Ilpo Järvinen
2025-08-28 21:14 ` Mark Pearson
2025-08-25 16:03 ` [PATCH v3 3/3] platform/x86: think-lmi: Add extra TC BIOS error messages Mark Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec9c6b1-c578-4835-8f48-d1747a7388ab@app.fastmail.com \
--to=mpearson-lenovo@squebb.ca \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kean0048@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®