From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cae.in-ulm.de (cae.in-ulm.de [217.10.14.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E1D8175A87 for ; Tue, 21 Apr 2026 06:30:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.10.14.231 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776753032; cv=none; b=ClCHQWlUTGVL1TEJgeLYwt7dGi6IpWNguOuihqoKQAQ9H6ATMcP75FsYVK+AgTS3UWnDnkh2kC3iv/qcdkWufwa/w6nwF2KJtKfPmBVzLz59Nd0aOkbWuc4ninogqe+J3u75rW2O1eUBkQPt5mYiZyrknUZO60lMW58p5aAq+mc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776753032; c=relaxed/simple; bh=qpJBd7UXBaDqixtWXqqcPuh5/x61lZ9/iYnR7Dr0hcE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ykx/3VH2AsJvSoYvMyXEqSPnvGj0VOFWzlLz/2kVFXtIkTpzHCRiyPVLpqnohxSdEDDGscSGmlvrxd0+S47UEQ/zB+6W1U2HCaeiMmdTbe5ZbyvhxzFwgFd+LPUAeQoZkj55b+74KLzYUj/SLkdl9e9O40fqGBf99PMMBSK2TBk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=c--e.de; spf=pass smtp.mailfrom=c--e.de; arc=none smtp.client-ip=217.10.14.231 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=c--e.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=c--e.de Received: by cae.in-ulm.de (Postfix, from userid 1000) id A579F14011C; Tue, 21 Apr 2026 08:30:27 +0200 (CEST) Date: Tue, 21 Apr 2026 08:30:27 +0200 From: "Christian A. Ehrhardt" To: David Gow Cc: David Howells , Andrew Morton , linux-kernel@vger.kernel.org, Kees Cook , Petr Mladek Subject: Re: [PATCH v3 5/5] lib: kunit_iov_iter: Add tests for extract_iter_to_sg Message-ID: References: <20260326214905.818170-1-lk@c--e.de> <20260326214905.818170-6-lk@c--e.de> <34a81ec2-af84-465d-9b5e-7bb5bf01680f@davidgow.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <34a81ec2-af84-465d-9b5e-7bb5bf01680f@davidgow.net> Hi David, On Tue, Apr 21, 2026 at 01:45:33PM +0800, David Gow wrote: > Le 27/03/2026 à 05:49, Christian A. Ehrhardt a écrit : > > Add test cases that test extract_iter_to_sg. > > > > For each iterator type an iterator is loaded with a suitable > > buffer. The iterator is then extracted to a scatterlist with > > multiple calls to extract_iter_to_sg. The final scatterlist > > is copied into a scratch buffer. > > > > The test passes if the scratch buffer contains the same data > > as the original buffer. > > > > The new tests demonstrate bugs in extract_iter_to_sg > > for kvec and user iterators that are fixed by the previous > > commits. > > > > Cc: David Howells > > Cc: Andrew Morton > > Signed-off-by: Christian A. Ehrhardt > > --- > > Hmm... this is failing on powerpc, where PAGE_SIZE is 64k: > > [13:20:40] # iov_kunit_iter_to_sg_kvec: ASSERTION FAILED at Sorry about that! I wasn't aware of the large page size on powerpc. This should fix it. I will prepare a proper patch but it would be cool if you could verify that it actually helps. Best regards, Christian diff --git a/lib/tests/kunit_iov_iter.c b/lib/tests/kunit_iov_iter.c index 37bd6eb25896..f02f7b7aa796 100644 --- a/lib/tests/kunit_iov_iter.c +++ b/lib/tests/kunit_iov_iter.c @@ -1128,7 +1128,7 @@ static void __init iov_kunit_iter_to_sg_kvec(struct kunit *test) struct kvec kvec; size_t bufsize; - bufsize = 0x100000; + bufsize = 0x200000; iov_kunit_iter_to_sg_init(test, bufsize, false, &data); kvec.iov_base = data.buffer; @@ -1146,7 +1146,7 @@ static void __init iov_kunit_iter_to_sg_bvec(struct kunit *test) struct bio_vec *bvec; struct iov_iter iter; - bufsize = 0x100000; + bufsize = 0x200000; iov_kunit_iter_to_sg_init(test, bufsize, false, &data); bvec = kunit_kmalloc_array(test, data.npages, sizeof(*bvec), @@ -1173,7 +1173,7 @@ static void __init iov_kunit_iter_to_sg_folioq(struct kunit *test) struct iov_iter iter; size_t bufsize; - bufsize = 0x100000; + bufsize = 0x200000; iov_kunit_iter_to_sg_init(test, bufsize, false, &data); folioq = iov_kunit_create_folioq(test); @@ -1190,7 +1190,7 @@ static void __init iov_kunit_iter_to_sg_xarray(struct kunit *test) struct iov_iter iter; size_t bufsize; - bufsize = 0x100000; + bufsize = 0x200000; iov_kunit_iter_to_sg_init(test, bufsize, false, &data); xarray = iov_kunit_create_xarray(test); @@ -1206,7 +1206,7 @@ static void __init iov_kunit_iter_to_sg_ubuf(struct kunit *test) struct iov_iter iter; size_t bufsize; - bufsize = 0x100000; + bufsize = 0x200000; iov_kunit_iter_to_sg_init(test, bufsize, true, &data); iov_iter_ubuf(&iter, READ, data.ubuf, bufsize);