From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83547C5CFEB for ; Wed, 11 Jul 2018 08:26:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4757C20877 for ; Wed, 11 Jul 2018 08:26:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4757C20877 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732374AbeGKI3y (ORCPT ); Wed, 11 Jul 2018 04:29:54 -0400 Received: from esa1.microchip.iphmx.com ([68.232.147.91]:65371 "EHLO esa1.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726314AbeGKI3y (ORCPT ); Wed, 11 Jul 2018 04:29:54 -0400 X-IronPort-AV: E=Sophos;i="5.51,337,1526367600"; d="scan'208";a="16903889" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Jul 2018 01:26:46 -0700 Received: from [10.159.245.112] (10.10.76.4) by chn-sv-exch02.mchp-main.com (10.10.76.38) with Microsoft SMTP Server id 14.3.352.0; Wed, 11 Jul 2018 01:26:45 -0700 Subject: Re: [PATCH v10 0/6] Driver for at91 usart in spi mode To: Radu Pirea , CC: , , , , , , , , , , References: <20180625172230.29686-1-radu.pirea@microchip.com> From: Nicolas Ferre Organization: microchip Message-ID: Date: Wed, 11 Jul 2018 10:26:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180625172230.29686-1-radu.pirea@microchip.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/06/2018 at 19:22, Radu Pirea wrote: > Hello, > > This is the second version of driver. I added a mfd driver which by > default probes atmel_serial driver and if in dt is specified to probe > the spi driver, then the spi-at91-usart driver will be probed. The > compatible for atmel_serial is now the compatible for at91-usart mfd > driver and compatilbe for atmel_serial driver was changed in order to > keep the bindings for serial as they are. > > Changes in v10: > -fixed kbuild test robot warning > > Changes in v9: > - minor changes > - rebased on top of broonie/for-4.19 > > Changes in v8: > - fixed passing an empty mfd cell if "atmel,usart-mode" value is invalid > > Changes in v7: > - synced up SPDIX license with module license > - numbering of usart modes starts from 0 insteand of 1 > > Changes in v6: > - removed unused compatible strings from serial and spi drivers > > Changes in v5: > - fixed usage of stdout-path property with atmel_serial driver > > Changes in v4: > - modified the spi driver to use cs gpio support form spi subsystem > - fixed dma transfers for serial driver > - squashed binding for spi and serial and moved them to mfd/atmel-usart.txt > > Changes in v3: > - fixed spi slaves probing > > Changes in v2: > - added at91-usart mfd driver > - modified spi-at91-usart driver to work as mfd driver child > - modified atmel_serial driver to work as mfd driver child > > Changes in v1: > - added spi-at91-usart driver > > > Radu Pirea (6): > MAINTAINERS: add at91 usart mfd driver > dt-bindings: add binding for atmel-usart in SPI mode > mfd: at91-usart: added mfd driver for usart > MAINTAINERS: add at91 usart spi driver > spi: at91-usart: add driver for at91-usart as spi > tty/serial: atmel: change the driver to work under at91-usart mfd For the record or if needed by the MAINTAINERS changes, you can add my: Acked-by: Nicolas Ferre for the whole series. Once the remarks by Mark are addressed, you can certainly re-send the series with all tags collected for Lee to take it, if he is okay with this process, of course... Thanks, best regards, Nicolas > .../bindings/{serial => mfd}/atmel-usart.txt | 25 +- > MAINTAINERS | 16 + > drivers/mfd/Kconfig | 9 + > drivers/mfd/Makefile | 1 + > drivers/mfd/at91-usart.c | 71 +++ > drivers/spi/Kconfig | 9 + > drivers/spi/Makefile | 1 + > drivers/spi/spi-at91-usart.c | 432 ++++++++++++++++++ > drivers/tty/serial/Kconfig | 1 + > drivers/tty/serial/atmel_serial.c | 42 +- > include/dt-bindings/mfd/at91-usart.h | 17 + > 11 files changed, 607 insertions(+), 17 deletions(-) > rename Documentation/devicetree/bindings/{serial => mfd}/atmel-usart.txt (76%) > create mode 100644 drivers/mfd/at91-usart.c > create mode 100644 drivers/spi/spi-at91-usart.c > create mode 100644 include/dt-bindings/mfd/at91-usart.h > -- Nicolas Ferre