From: Jens Axboe <axboe@kernel.dk>
To: Tejun Heo <tj@kernel.org>
Cc: linux-block@vger.kernel.org, kernel-team@fb.com, dskarlat@fb.com,
dschatzberg@fb.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-5.13/block] blk-iocost: don't ignore vrate_min on QD contention
Date: Fri, 23 Apr 2021 08:55:15 -0600 [thread overview]
Message-ID: <aed2c239-8169-d30f-1410-ac0b5ae10cf1@kernel.dk> (raw)
In-Reply-To: <YIIo1HuyNmhDeiNx@slm.duckdns.org>
On 4/22/21 7:54 PM, Tejun Heo wrote:
> ioc_adjust_base_vrate() ignored vrate_min when rq_wait_pct indicates that
> there is QD contention. The reasoning was that QD depletion always reliably
> indicates device saturation and thus it's safe to override user specified
> vrate_min. However, this sometimes leads to unnecessary throttling,
> especially on really fast devices, because vrate adjustments have delays and
> inertia. It also confuses users because the behavior violates the explicitly
> specified configuration.
>
> This patch drops the special case handling so that vrate_min is always
> applied.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-04-23 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 1:54 Tejun Heo
2021-04-23 14:55 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aed2c239-8169-d30f-1410-ac0b5ae10cf1@kernel.dk \
--to=axboe@kernel.dk \
--cc=dschatzberg@fb.com \
--cc=dskarlat@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®