From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 936C2C77B75 for ; Mon, 22 May 2023 12:30:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233297AbjEVMaT (ORCPT ); Mon, 22 May 2023 08:30:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234205AbjEVM3y (ORCPT ); Mon, 22 May 2023 08:29:54 -0400 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82FACA9; Mon, 22 May 2023 05:26:33 -0700 (PDT) Received: (Authenticated sender: alexis.lothore@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id B0691C0004; Mon, 22 May 2023 12:26:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1684758392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LmOknkiGbwRWi05gBEVUbhKWKgcpIrXBPCzL78lpEGw=; b=KJYXKaU5T0YwZvWBpn0vwwU7ANrv67sjH7nSzG1MQfrq9UEAMIttP39vWyaT3HdcAKjomH g/qV6CvC8Rx9QMJAUf/z41PtN9/Vc0Rw/1REVVTP9ouPMfWj/jpNU/5LApgDBZ78ObwwE3 WcecZtw6sZGxONJD85smgMi5tkmAenLw4yK+a3TC9Vq0gMmeoQM7RNU/kztNBUnyyq3FaD iUJmVFLsUmtLN9Q885rGIPX2jU0at9awrIyGbzEG3mjpG4ejk4vbw144QHBtb9D7nmk0ZT ZiLLqPOylo8rLIL6TSvUnXjEZF1n6YOi/W6uCDaQ6TIarNkAAuw+IeOswkzMWw== Message-ID: Date: Mon, 22 May 2023 14:26:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH net-next v2 7/7] net: dsa: mv88e6xxx: enable support for 88E6361 switch Content-Language: en-US To: Andrew Lunn Cc: "Russell King (Oracle)" , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Rob Herring , Krzysztof Kozlowski , Conor Dooley , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, paul.arola@telus.com, scott.roberts@telus.com, =?UTF-8?Q?Marek_Beh=c3=ban?= References: <20230519141303.245235-1-alexis.lothore@bootlin.com> <20230519141303.245235-8-alexis.lothore@bootlin.com> <1c104034-b61f-5242-40fa-339de59ac9c9@bootlin.com> <237dbb7f-8979-4435-a099-95bb5d093910@lunn.ch> From: =?UTF-8?Q?Alexis_Lothor=c3=a9?= In-Reply-To: <237dbb7f-8979-4435-a099-95bb5d093910@lunn.ch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Andrew, On 5/22/23 14:19, Andrew Lunn wrote: >>> Not exactly related to this patch, but please do not rely on this "max >>> speed mode" - please always ensure that you specify the phy-mode and >>> fixed-link settings for CPU and DSA ports in firmware. Thanks. >> >> I would like to make sure to fully understand your point: >> - when telling so specify phy-mode and fixed-link in firmware, you mean >> device-tree, right ? >> - when checking for code and execution flow, I observe that port_max_speed is >> always called and its output is always used to configure shared ports mode in >> mv88e6xxx driver. Are you telling that eventually, the whole mv88e6xxx driver >> should stop relying on port_max_speed_mode for shared ports ? > > Yes, the concept of port_max_speed_mode causes problems for PHYLINK, > and we want to remove it. Russell and i have been updating DT > descriptions adding fixed-link and phy-mode properties to all > mv88e6xxx systems so that it is not needed. Either at the end of this > cycle, or the beginning of the next we will change the code to > actually enforce this. Understood, thanks for clarification > > Andrew -- Alexis Lothoré, Bootlin Embedded Linux and Kernel engineering https://bootlin.com