From: Joe Perches <joe@perches.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org
Subject: [PATCH 03/12] ipx.h: Remove extern from function prototypes
Date: Sat, 21 Sep 2013 10:22:43 -0700 [thread overview]
Message-ID: <aed828a0b08b947467bf8009e8225c3abdfe78c0.1379783995.git.joe@perches.com> (raw)
In-Reply-To: <005f102eb1322058f9e797a7268ae8be01ecfaae.1379783995.git.joe@perches.com>
There are a mix of function prototypes with and without extern
in the kernel sources. Standardize on not using extern for
function prototypes.
Function prototypes don't need to be written with extern.
extern is assumed by the compiler. Its use is as unnecessary as
using auto to declare automatic/local variables in a block.
Signed-off-by: Joe Perches <joe@perches.com>
---
include/net/ipx.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/net/ipx.h b/include/net/ipx.h
index c1fec6b..9e9e354 100644
--- a/include/net/ipx.h
+++ b/include/net/ipx.h
@@ -123,23 +123,23 @@ extern struct list_head ipx_routes;
extern rwlock_t ipx_routes_lock;
extern struct list_head ipx_interfaces;
-extern struct ipx_interface *ipx_interfaces_head(void);
+struct ipx_interface *ipx_interfaces_head(void);
extern spinlock_t ipx_interfaces_lock;
extern struct ipx_interface *ipx_primary_net;
-extern int ipx_proc_init(void);
-extern void ipx_proc_exit(void);
+int ipx_proc_init(void);
+void ipx_proc_exit(void);
-extern const char *ipx_frame_name(__be16);
-extern const char *ipx_device_name(struct ipx_interface *intrfc);
+const char *ipx_frame_name(__be16);
+const char *ipx_device_name(struct ipx_interface *intrfc);
static __inline__ void ipxitf_hold(struct ipx_interface *intrfc)
{
atomic_inc(&intrfc->refcnt);
}
-extern void ipxitf_down(struct ipx_interface *intrfc);
+void ipxitf_down(struct ipx_interface *intrfc);
static __inline__ void ipxitf_put(struct ipx_interface *intrfc)
{
--
1.8.1.2.459.gbcd45b4.dirty
next prev parent reply other threads:[~2013-09-21 17:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 17:22 [PATCH 01/12] inet*.h: " Joe Perches
2013-09-21 17:22 ` [PATCH 02/12] ip*.h: " Joe Perches
2013-09-21 17:22 ` Joe Perches [this message]
2013-09-21 17:22 ` [PATCH 04/12] lapb.h: " Joe Perches
2013-09-21 17:22 ` [PATCH 05/12] llc*.h: " Joe Perches
2013-09-21 17:22 ` [PATCH 06/12] mrp.h: " Joe Perches
2013-09-21 17:22 ` [PATCH 07/12] ndisc.h: " Joe Perches
2013-09-21 17:22 ` [PATCH 08/12] net_namespace.h: " Joe Perches
2013-09-21 17:22 ` [PATCH 09/12] iw_handler.h: " Joe Perches
2013-09-21 17:22 ` [PATCH 10/12] netevent/netlink.h: " Joe Perches
2013-09-21 17:22 ` [PATCH 11/12] netrom.h: " Joe Perches
2013-09-21 17:22 ` [PATCH 12/12] p8022.h: " Joe Perches
2013-09-21 18:04 ` [PATCH 01/12] inet*.h: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aed828a0b08b947467bf8009e8225c3abdfe78c0.1379783995.git.joe@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®