From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 391E64457B7 for ; Thu, 27 Aug 2026 11:17:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787829446; cv=none; b=oPPpAa+tN7zrLKQq3WEBAjrWiR9GAXK8Svm9psku4/XDFHSDJ7TpN230YLojLmsgfi4sSdDSBfGzQbwZGCCnTKcrWAodUF4JsOASkQ75YCj7CB3HQarbuZ/aixILTpoRzl5wkFuCwWjKRw4+z2fwfPWfsfl+kQ15+5un7xgJG/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787829446; c=relaxed/simple; bh=TNfL0ltNtyA++Rr8CgECMMr+pcLqnV/WtZHCJGLhTqQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hhzjEcd3jWrYO1tHZIE1ju/qSkSphJ0cWcqWgcd+f27/1fdwK1fqS3YvJ4dWYApMegYZ39k7ARrCRgAZTebHrb0QH+hb+aRZ78zsr0a72pfhbl7QP8nnwG0tVe9QfwGnua7ntR365n2hQlRwMMFz+GCNxjrgC5aFkSormLS0wsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oZenkQEh; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oZenkQEh" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-499840a2575so12723145e9.3 for ; Thu, 27 Aug 2026 04:17:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787829436; x=1788434236; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=t7OBFqNTBANSPaxVAd2poemMPOcLMraetZWIq+y0CHI=; b=oZenkQEh24GGihXOqcSj2iJHkyAZvMzaZao4YFIUBifwoDMCDuiOwSe/ZdvS47O7Ll 4PjWFeBJCY+U4RfkorpF861HJeJo03FFRpZU6WeC2ePnrgPL6gqkjq3oJLu2Z0k++yGW Ivy0n4vVn/ZrZJli0/ocHTnAsEY4bxFqAKp90CaGyBLeKTfYsHbsiiERuRVg6oyjZVou cWOVKoXF66uk8Ii0f8qzOtJvIU+QV2O9Q6ApA5Ktbte/jOeAk/3FuZvb4/z2GZKXdBX+ S6ZLDnhnAXe7q/leVE13PiOXaDZ+p3ciPb/hA/3a96YmfAxwcdcfXQANoBrOwiH4SX+w hOrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787829436; x=1788434236; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=t7OBFqNTBANSPaxVAd2poemMPOcLMraetZWIq+y0CHI=; b=V5LZZQCOaC4hdbWHqtKBzqyAfzAlbF2RkeJO99YEyvg/HNHdwc9d0j6G8Dm9d8rPxK jarn45fLnc5b+mZ4RfHLWFER1k89QegBvOAxB50QrEBNgmXEWeAPkRDgn4hfooCMlvVA wWNV85kRMdALp0f93ol/uXRG4QhBjQP97LmEOvi1pyKSUyJo8jKKN6VDNAtMMGINw1UX JzAVc2bOmfwKNZjifSsiEfAw2FRbxVFnDB5Fmhu2I6CbKbXsQWbclrkU0VVwpvr3uYsw qrb5w4rdgApqNd7aF8d49x3CZf6q9C7TERet93YXO8/WfaAm8uDMtQVrgokmQMYixCBu sBKA== X-Forwarded-Encrypted: i=1; AHgh+Rr3s8O/P810ekH4o6AhTng9zrE49uv7X7cX9Fmonn6nNjx3kAaLF3ABM/FTZphpsd3+s0E4v/+tkhzwUvQ=@vger.kernel.org X-Gm-Message-State: AFuF++kEXgvvz1eHLtUZlGmjg0Ej/AkeqPrpv2dwS2dNf9xb5BLZgo+h 2hVd3hfLP2CFNOvQ7JxH6gRvJKeFdhOPlx643P3LuVWPOY8aK/cwqY9L X-Gm-Gg: AR+sD10vQpu5vsy6spKsL7yY6kpS+gOp0MEdOkup49Vm8JnpfrNIwg/eJQCfOlZBUxt 3WlNhGfMHA08xnPC6NN2I5Jve4iDOi0I5EN1ABL8k51MUCQ2Nz7/mltAL5RGLaEHI8jHH3mcL5V 8est/cU/bNZZcyufRF3LfPwXZ9sTwIpdZD6EVf7gDD+BLjbiAyW1ejQSaM0/48uc+Xk5OW7oPtp cvilks5N2slOQKXK4MKOY885dgQdz3BZi2WizXjnjgM/gh/4x3Uk54HAv7giWG8LvyhM27SBgk8 /HhwMgBYnv7DFe0eao94WspOgZNZLHK3Yabwby6V8qMqr/Hthw8E4AycAxwIgvQP495YwVKFl6f 3wtDrfS0Y4tA5aeANGiSOiLpF0Tvzxfy4VQ3rL1bqvNflTNZEN/Hys+t6vIOoy3kAdacuSGLDla v+ClXuA1rPGSP3HQknUt4XweQeA/GCjwpW3ZRfphNkbFcBcpmV3o0/5fHz2Qi0CjDCT+3nQjWjW 9t/ZXy5tMk4JTtsuvWJScTxyibKdj8XEtlLM3ie6eE8xQ70CX/zLYEXXqpoWMeXggXCkHjnXumS YbV9gG7k+MtQFg== X-Received: by 2002:a05:600c:c87:b0:496:c93d:e2f with SMTP id 5b1f17b1804b1-499dc93411fmr130733645e9.15.1787829435320; Thu, 27 Aug 2026 04:17:15 -0700 (PDT) Received: from [172.24.138.145] (ipservice-092-208-247-184.092.208.pools.vodafone-ip.de. [92.208.247.184]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49b49236515sm68507065e9.1.2026.08.27.04.17.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Aug 2026 04:17:14 -0700 (PDT) Message-ID: Date: Thu, 27 Aug 2026 13:17:13 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 3/3] iio: dac: Add AD5529R DAC driver support To: Andy Shevchenko , Janani Sunil Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Jonathan Corbet , Shuah Khan , Mark Brown , Marius Cristea , Marcus Folkesson , Kent Gustavsson , Conor Dooley , Daire McNamara , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-spi@vger.kernel.org, Kent Gustavsson , linux-riscv@lists.infradead.org References: <20260827-ad5529r-driver-v10-0-38f2be07b824@analog.com> <20260827-ad5529r-driver-v10-3-38f2be07b824@analog.com> Content-Language: en-US From: Janani Sunil In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/27/26 10:23, Andy Shevchenko wrote: > More or less in a good shape, a few nit-picks and minor issues here and there > and I believe the next version will be fine to go. Note, some of the mentioned > issues can be addressed later, but if no doubts, address now. > > On Thu, Aug 27, 2026 at 09:34:48AM +0200, Janani Sunil wrote: >> Add support for AD5529R 16-channel, 12/16 bit Digital to Analog Converter >> from Analog Devices. >> >> The device communicates over SPI and supports per-channel output range >> configuration. An optional external 4.096V reference can be used in >> place of the internal reference. >> + for (unsigned int i = 0; i < ARRAY_SIZE(ad5529r_vss_supply_names); i++) { >> + ret = devm_regulator_get_enable_optional(dev, >> + ad5529r_vss_supply_names[i]); >> + if (ret && ret != -ENODEV) >> + return dev_err_probe(dev, ret, >> + "Failed to get and enable %s regulator\n", >> + ad5529r_vss_supply_names[i]); >> + } > Hmm... Can we use bulk regulator approach here? I don´t think the bulk helper fits here. Each VSS supply is independently optional, and there is currently no optional bulk get-enable regulator helper. Regards, Jan