From: Eli Billauer <eli.billauer@gmail.com>
To: Chen Ni <nichen@iscas.ac.cn>, arnd@arndb.de, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char: xillybus: Use to_delayed_work()
Date: Tue, 15 Apr 2025 12:46:51 +0300 [thread overview]
Message-ID: <aedaf79b-7bd3-885c-2bcf-ab9c73f7cf86@outbound.gmail.com> (raw)
In-Reply-To: <20250414074559.3954142-1-nichen@iscas.ac.cn>
Yes, I suppose this is the right way to do it.
Thanks,
Eli
Acked-by: Eli Billauer <eli.billauer@gmail.com>
On 14/04/2025 10:45, Chen Ni wrote:
> Use to_delayed_work() instead of open-coding it.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/char/xillybus/xillybus_core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/char/xillybus/xillybus_core.c b/drivers/char/xillybus/xillybus_core.c
> index 11b7c4749274..efb1ae834265 100644
> --- a/drivers/char/xillybus/xillybus_core.c
> +++ b/drivers/char/xillybus/xillybus_core.c
> @@ -1184,8 +1184,7 @@ static int xillybus_flush(struct file *filp, fl_owner_t id)
>
> static void xillybus_autoflush(struct work_struct *work)
> {
> - struct delayed_work *workitem = container_of(
> - work, struct delayed_work, work);
> + struct delayed_work *workitem = to_delayed_work(work);
> struct xilly_channel *channel = container_of(
> workitem, struct xilly_channel, rd_workitem);
> int rc;
prev parent reply other threads:[~2025-04-15 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 7:45 Chen Ni
2025-04-15 9:46 ` Eli Billauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aedaf79b-7bd3-885c-2bcf-ab9c73f7cf86@outbound.gmail.com \
--to=eli.billauer@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®