From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7937DC2D0CD for ; Tue, 17 Dec 2019 11:52:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 593162146E for ; Tue, 17 Dec 2019 11:52:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727723AbfLQLwc (ORCPT ); Tue, 17 Dec 2019 06:52:32 -0500 Received: from foss.arm.com ([217.140.110.172]:34378 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726275AbfLQLwc (ORCPT ); Tue, 17 Dec 2019 06:52:32 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91CC631B; Tue, 17 Dec 2019 03:52:31 -0800 (PST) Received: from [10.1.196.56] (e112269-lin.cambridge.arm.com [10.1.196.56]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7E8ED3F6CF; Tue, 17 Dec 2019 03:52:30 -0800 (PST) From: Steven Price Subject: Re: linux-next: Tree for Dec 16 (drm_panel & intel_panel) To: Randy Dunlap , Sam Ravnborg Cc: Stephen Rothwell , intel-gfx , Linux Kernel Mailing List , dri-devel , Linux Next Mailing List , Thierry Reding References: <20191216162209.5b5256dd@canb.auug.org.au> <20191217054255.GA26868@ravnborg.org> <65c9dc7b-3c61-8204-07da-212632732791@infradead.org> Message-ID: Date: Tue, 17 Dec 2019 11:52:29 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <65c9dc7b-3c61-8204-07da-212632732791@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/12/2019 06:37, Randy Dunlap wrote: > On 12/16/19 9:42 PM, Sam Ravnborg wrote: >> Hi Randy. >> >> On Mon, Dec 16, 2019 at 08:25:11AM -0800, Randy Dunlap wrote: >>> On 12/15/19 9:22 PM, Stephen Rothwell wrote: >>>> Hi all, >>>> >>>> Changes since 20191213: >>>> >>> >>> on x86_64: >>> >>> ld: drivers/gpu/drm/drm_panel.o: in function `drm_panel_of_backlight': >>> (.text+0x2ee): undefined reference to `devm_of_find_backlight' >>> >>> ld: drivers/gpu/drm/i915/display/intel_panel.o: in function `intel_backlight_device_register': >>> intel_panel.c:(.text+0x593e): undefined reference to `backlight_device_register' >>> ld: drivers/gpu/drm/i915/display/intel_panel.o: in function `intel_backlight_device_unregister': >>> intel_panel.c:(.text+0x5a04): undefined reference to `backlight_device_unregister' >>> >>> CONFIG_DRM_PANEL=y >>> CONFIG_BACKLIGHT_CLASS_DEVICE=m >>> CONFIG_DRM_I915=y >>> >>> Full randconfig file is attached. >> >> Can you please verify if you have: >> 907aa265fde6589b8059dc51649c6d1f49ade2f3 >> ("drm/drm_panel: fix EXPORT of drm_panel_of_backlight") >> >> This commit is supposed to fix it. >> >> Sam >> > > Hi Sam, > I don't have the linux-next.git tree so I can't check that. > I just built whatever is in linux-next of 20191216. > 907aa265fde6589b8059dc51649c6d1f49ade2f3 ("drm/drm_panel: fix EXPORT of drm_panel_of_backlight") is fixing drm_panel_of_backlight(), but the error above is for backlight_device_register(). >From what I can tell, that commit is actually the cause of the error - now intel_backlight_device_register() is being included in the kernel even though it calls backlight_device_register() which is in a module. Of course it also fixed the original error, so reverting it isn't any use. The below Kconfig change fixes the build for me, but I've no idea whether this is the correct fix. Steve ----8<----- diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index ba9595960bbe..6b69dab683ae 100644 --- a/drivers/gpu/drm/i915/Kconfig +++ b/drivers/gpu/drm/i915/Kconfig @@ -16,7 +16,7 @@ config DRM_I915 select IRQ_WORK # i915 depends on ACPI_VIDEO when ACPI is enabled # but for select to work, need to select ACPI_VIDEO's dependencies, ick - select BACKLIGHT_CLASS_DEVICE if ACPI + select BACKLIGHT_CLASS_DEVICE select INPUT if ACPI select ACPI_VIDEO if ACPI select ACPI_BUTTON if ACPI