From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD9503D6CA9 for ; Tue, 21 Apr 2026 12:54:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776776058; cv=none; b=Ktc9dz/t+MvHyi7miiqlgzPk/UAlka+27Z3cV0MYCMMdTjrqfXlDT7t+CoUgxj33LdG+WvKRINyrSjRH/gP2+ePYD0xoDe+bxxahNb690aDOJVZzzm2/fJT1PtLhh8fKMpCKMJL4E1GvLYR42xsCJvNZotLOFOqB736VT2pJAOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776776058; c=relaxed/simple; bh=uFGmd0NgS3Gb4WO3dlidZD4uKw75wCW6ySr7In9/XnY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QcEsTGoDtcrPv557Eu2Nd5OAf9IYt5EhTuKpvDSP05EtDOvnKb5xNtuqjrUEZ5aIgNIK6LhwEai7vj+CjzmaD0n6UpgD4TMeugG6lLNnODV8TZCGifco09iNTKbA+IJxr2Z0Pdd7vN40erNbFTo09b2QUJyYlFv3lvcbTW/nlPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F/UOdA+i; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N6MAun9/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F/UOdA+i"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N6MAun9/" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63LC6Ixi1012009 for ; Tue, 21 Apr 2026 12:54:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=rvgwzwNCsr0kVCgZCO0b8Gan 6uAfHoY1Q2EdivY2g1U=; b=F/UOdA+idDNgOsgLkGkvfkksajla126tXrb04fwe ThVX7Vi2+OwDb+N2DJ7J/PyUOATs6NFVIcHP9mQthJEPDy6lKOeBOmGaYNQ8T1JR /okemA1rpivOi5egf6aGNLgluHvnpZ9v7u6K0q9iIHttvkSV106A4yH6n0fQo44q 21h+hEdXqx85PAgPOswsjdar4lKEpDhdTUHZg0t4P2AV9dVFhSwBkjjsNU2rJHiE OMWlOgFQDIpKCjxNbdYXa0BjTLeTcdqFVyXY1QRTC3uy6lskOeMk77AyvWDd5zbc Y5Su6Fn/p+tyng7OOY3cIZd79nh2sp1Hu9YamH93GPrKMw== Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dnt9035x5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Apr 2026 12:54:13 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-2dd1c74508cso7091943eec.0 for ; Tue, 21 Apr 2026 05:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776776053; x=1777380853; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rvgwzwNCsr0kVCgZCO0b8Gan6uAfHoY1Q2EdivY2g1U=; b=N6MAun9//6U1Lt7or6TLEjl5m2mtfM64Cz7z/qOr2TuSqblwtJhTB9U1h2hDwipfWz IeOuXxsm45mLybfecZmm/Bmpns28egEDywcIhIPnZN33/tzIElju6mhXpMwxy8/CuXCv K/xYGyxVpqmjakl9IT+jxNlaJwWNHjLw4qgY8TIcWFwBQz68nc1coML0kH0pv0v4UuN8 MgkrenPWZMyRG39g3Jwl51TgJIzJJ7ySUJW/dFt5u5e16lLet8PmTRrZBZSshfGAtXjG iUYgcTVQNy0VCNXzgALDUySgnhS7vvPWcgH9Mc16yXmuhgro77gEgbL0BskZCBy9UYmK KQPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776776053; x=1777380853; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rvgwzwNCsr0kVCgZCO0b8Gan6uAfHoY1Q2EdivY2g1U=; b=nfiXVRjf53kXTu5XRW/FhAYX3poTVfwJFzLCShZu610DeUQJSd34l3664TFn42RVzc jT8XUrMacq/qFisLKrVGJ59lIteazZoyF/mR/58U2aXkJUrPsdehiMJyur0Nc0ahKHMN u23ARYa+kqqGGRN6FjJwJsgQgMynjkQCBVHhtOqx5muI5r7caoshmBj71hsF3Cif20dZ tQlrSlrJlXuHzK/op7+gDdNZ4k9hUVSwPWmKvSSxdUnGQ/c2JDMJx8fwbXdx3Z/BhYX2 1BlOXES4u7i0Kt/HMMG+8WFkoxeb2/cPrAJuMS5JRbGBvxZ7Z9DL5wbBgSuyedRZK9XS 8xSw== X-Forwarded-Encrypted: i=1; AFNElJ+rXhUyxXhrCWahyIJFpaLTWAMNslnk6B3Sd1Z4WGlEVGILGKD4TmazXsenEf8Np3L9slsqhp9cDP8BJkU=@vger.kernel.org X-Gm-Message-State: AOJu0YxU+E3NiVU+m+C4N2AyNu3Ri5iotFO1CMCYBI9+lv1TvJI9GA7L LxiiefkPkR7cA9tXFQJjBjN3Qy+KcjF/jb/mO9rYOkwXM8275C1eBBC3MxLEALzvdTAfzKOrSOT ZQKg4w8fIMPjjlVrTvZBCXNB7QxTAAE07l7EGFLX8r0swtL9zmQxfIStkZCEOdJhYMX0= X-Gm-Gg: AeBDiev+xTPmzZHqwdIh+djGLsljQNnETY3XAvfIJlz9yLWduBwECCwjHEcITWTE26M 7xhqpqzrXYFOU54S/d4wfDFAPjkMLya5KSeZTuz/FynB9MMZM9N9a3n3vzxmWitM2o1pythtDmu s5dwvrP3YRBoscGSusyds15nWNALao5+Fq8q6+XQ4YPja2a7ETt2mFAdPow3/pSFNTrxOdvDD12 ZQ2RjR/0QrxHx8yEmZO6u9lF0zN+0XO/DWdZOm53lU79sdUH56okXA6nRMkYu8KSgDJbSx44WBh xWXIOBmqMMnGkh8kyA22M9UAy2kirsW0UMw3J+6FwwhnlYA707Akb8OQfkb6hrpcgplqQ+Pkmn8 IuHN+t3DP/0rMAJFkb9gWY2rtJpeOClM9Mk2BnBCIwifqy91Jt7JtGyiPDQCsp+UFqwbYeFrnHt o= X-Received: by 2002:a05:7300:fd09:b0:2da:d4b4:c85a with SMTP id 5a478bee46e88-2e464dad10cmr8237850eec.11.1776776053051; Tue, 21 Apr 2026 05:54:13 -0700 (PDT) X-Received: by 2002:a05:7300:fd09:b0:2da:d4b4:c85a with SMTP id 5a478bee46e88-2e464dad10cmr8237816eec.11.1776776052469; Tue, 21 Apr 2026 05:54:12 -0700 (PDT) Received: from QCOM-aGQu4IUr3Y (i-global052.qualcomm.com. [199.106.103.52]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53ccce0f5sm18748491eec.17.2026.04.21.05.54.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 05:54:12 -0700 (PDT) Date: Tue, 21 Apr 2026 20:54:06 +0800 From: Shawn Guo To: Konrad Dybcio Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Dmitry Baryshkov , Kamal Wadhwa , Bartosz Golaszewski , Deepti Jaggi , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] regulator: rpmh-regulator: Add RPMH regulator support for Nord Message-ID: References: <20260420072639.1249984-1-shengchao.guo@oss.qualcomm.com> <20260420072639.1249984-3-shengchao.guo@oss.qualcomm.com> <77a87de7-3c66-44b5-9900-df8798d3074f@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <77a87de7-3c66-44b5-9900-df8798d3074f@oss.qualcomm.com> X-Authority-Analysis: v=2.4 cv=KfbidwYD c=1 sm=1 tr=0 ts=69e77375 cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=b9+bayejhc3NMeqCNyeLQQ==:17 a=kj9zAlcOel0A:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=6n_0llUhAYeFIU8IND8A:9 a=CjuIK1q_8ugA:10 a=scEy_gLbYbu1JhEsrz4S:22 X-Proofpoint-ORIG-GUID: e0gjk2TT140sZM-i162XRhQaWl8htxuS X-Proofpoint-GUID: e0gjk2TT140sZM-i162XRhQaWl8htxuS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIxMDEyOCBTYWx0ZWRfXzl/YAWJR/yM8 mydTxSoGLQS4pCExxw03iZidWVgTy7G2cgytfW93Rv3tGc23J+cUIi9S+t7v2Q8Z/0cXy8udDkX weRvZmbxbTBWT03uTd3Vpe5XLDBZoekHMvxTE41JCydPbZ2h21KrOx1TWd8c26shUFrd5vEC3wH 5zNgnPSwC2fIVscNSfwPDPPO8Ud71yNX9nnSYuuXzM2H9Hj2thu9baNHAOSjBDJtRlaPyuxINyt 9Me5vV37gpHvu3/xMCTbZlT9H0XBibndQXWp46BRE9lFYcN/7IbibNXSG/V9BoT+3nkPVWitrVL G60Zfih838ex4RvNQeq37uDsv1tzDXx6oCI4ClWJr0gEpQLyjVMnLnEEl+1a3+LbzM/gZhveALr /HW8RPgg6vj9gDm3T5m2ecv3JURmHlINlWf9Xh8Da4e72aJHoXPY43s34bxov4moJXkbC1NEq1u 5Wbtzc29dG5R538og+w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-21_02,2026-04-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 spamscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604210128 On Mon, Apr 20, 2026 at 11:21:23AM +0200, Konrad Dybcio wrote: > On 4/20/26 9:26 AM, Shawn Guo wrote: > > From: Kamal Wadhwa > > > > Add support for PMAU0102 PMIC voltage regulators which are present on > > Nord boards. > > > > Signed-off-by: Kamal Wadhwa > > Signed-off-by: Shawn Guo > > --- > > drivers/regulator/qcom-rpmh-regulator.c | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c > > index 6e4cb2871fca..9545300d7b03 100644 > > --- a/drivers/regulator/qcom-rpmh-regulator.c > > +++ b/drivers/regulator/qcom-rpmh-regulator.c > > @@ -1100,6 +1100,21 @@ static const struct rpmh_vreg_init_data pm8998_vreg_data[] = { > > {} > > }; > > > > +static const struct rpmh_vreg_init_data pmau0102_vreg_data[] = { > > + RPMH_VREG("smps1", SMPS, 1, &pmic5_ftsmps527, "vdd-s1"), > > + RPMH_VREG("smps2", SMPS, 2, &pmic5_ftsmps527, "vdd-s2"), > > + RPMH_VREG("smps3", SMPS, 3, &pmic5_ftsmps527, "vdd-s3"), > > + RPMH_VREG("smps4", SMPS, 4, &pmic5_ftsmps527, "vdd-s4"), > > + RPMH_VREG("smps5", SMPS, 5, &pmic5_ftsmps527, "vdd-s5"), > > + RPMH_VREG("smps6", SMPS, 6, &pmic5_ftsmps527, "vdd-s6"), > > + RPMH_VREG("smps7", SMPS, 7, &pmic5_ftsmps527, "vdd-s7"), > > + RPMH_VREG("smps8", SMPS, 8, &pmic5_ftsmps527, "vdd-s8"), > > + RPMH_VREG("ldo1", LDO, 1, &pmic5_nldo515, NULL), > > + RPMH_VREG("ldo2", LDO, 2, &pmic5_nldo515, NULL), > > + RPMH_VREG("ldo3", LDO, 3, &pmic5_pldo515_mv, NULL), > > Any reason for the NULL supplies? We thought it's fine to not model LDO supplies, as they may not always follow PMIC. But that might be even a good reason for modeling, so that we can have a better DT description for the supplies. I will change it to: RPMH_VREG("ldo1", LDO, 1, &pmic5_nldo515, "vdd-l1"), RPMH_VREG("ldo2", LDO, 2, &pmic5_nldo515, "vdd-l2"), RPMH_VREG("ldo3", LDO, 3, &pmic5_pldo515_mv, "vdd-l3"), Thanks for asking! Shawn