From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753207AbcIHUOO (ORCPT ); Thu, 8 Sep 2016 16:14:14 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:50727 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751672AbcIHUOL (ORCPT ); Thu, 8 Sep 2016 16:14:11 -0400 Subject: Re: [PATCH 0/5] nbd improvements To: Josef Bacik , , , , , References: <1473363221-142264-1-git-send-email-jbacik@fb.com> From: Jens Axboe Message-ID: Date: Thu, 8 Sep 2016 14:13:46 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473363221-142264-1-git-send-email-jbacik@fb.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: BLUPR17CA0047.namprd17.prod.outlook.com (10.162.85.143) To CY4PR15MB1190.namprd15.prod.outlook.com (10.172.177.12) X-MS-Office365-Filtering-Correlation-Id: 498fc4b9-53c3-4f47-2b52-08d3d824a6ec X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1190;2:PEl9+kxNPYwYMI0tiHgWoIs4409h+U1zJ7Fd3snJZEp+mznTokDfF4XZSKtwJhFz4WsnrGkYyKWl7sk9rgMv2I9fyku2vRzTAKNnuTChNQO/mqb84CsQITcxyA1ZbPR5OND+odmch9gXeyMzwsAsjCWLPNHo0LMXHR48gUzBwdNQ+CaLfxvVpgU387sK+OdN;3:/PWVTXy0JoLFwZ2f6rlaHfeMGxkbwWny+xchSsk6Q1uqYTbUSwxCL5RzzgYI0r9irDd7DhsQ3xU9YfzRzXt60Br489awPEJVZ5kZivvrCsjnHkMaFPhsykFU87CM45X3;25:xxTTDR8wnzc58GDf9IxgXpojvnfnrdYDkK8zyo6CBOiTst4d5MwaKisq0u+9luaCxXnnzkuFx7L2iXIHjiOaYTonTTGK+jT7mazFxyRR9D4Io7g+83RSN5g1eXjlFouwdntnlQRjw1MVI/1rVyHM32Ch2QBbGFmbgvQGXswHm2UYrN8UdDRcA9V+gwMsko5t1hHF6j45dga2t29WBpmcifW1kJK+PpUjYJfbGPh8go1bH4ylyKIY0GIctQEIWoVwsJXA4XGZ6JznFlq4ERITAGizhO8Xaq25Cko75XsKgN/uv1GZa6yb2lQodBV83cgKuc8Viy2Ytd1rUrnE+TTAGlYQnXjEo8SRgGS4W6hDlCHjocLTwkkaCvFWQp8mdhVrKrVOgvKRNlk/QmG6c6War2O7PYVW0Ev9iRU0YgTA2VM= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1190; X-LD-Processed: 8ae927fe-1255-47a7-a2af-5f3a069daaa2,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1190;31:KpXud6Rs6s9ztLJfMuxpLeAwzu29FCBkIkOxd/JIXndkesNmQTfUHLK3zARsWlbIzT0fOGRA40HANXTyiGVVrHzmUTFYBPE9ACzgwj3dGd5473ah0+9rfGt+KlUE2jzmPtsTgJALlmO0o12+zJ5+dJjcjQ8xffcRi6efWD/locZa/SWQPazj2fs0GnqMriFLDr6e+vys9GbrKzNF1uopO46C4HEfhvLbaWtY36FF0Yk=;20:v0XDawcxlFOwHwuY879Cuc2AawCMkb2wWX0Z3svyqONJq7GekgQBj6Gre6nonxtYh7ZtNJxRavfkZLF6OaZeb28jBAiG5iPuXu7GavC2szdO6fuRuEZX0ICq963eaZkWNJOQc7bkmAOS3cKzMnMA92+psY8S8s8omOW6ggW1GQE=;4:nGkYE64jHwFciWEIRC6TDgl1YcXCFXFheJVXLU5UWrVUhjBqc28D43hJmk535iuA4eCPVLEIpmwWPZJbcszHljq0MjC9U8AFRfvNeUksEIyBXpq65IalZCGBHYEerfs+hqCwjOl9b/42L8/YH0r7VLaAP53KCIOVJE/czB8f9Zt172X79fCBETE7kpzC1JQMceQbro7d5KUzBOUmSiGcazJCPvnPEkMJ5UHYVQeT+Azik3n5Um11tnmXIFrA4Ra6tMAL+34SI8B+DfJ4jDXl0DJ2Zacl0ev2VDmdWynsjIdrxMACAhjwqTllcPaKkObxgKygrpR5VQKHvghY/VGDGMJFEHT0Doj/jp0+OOKBq8zrhtuoDxiatUKvw2cYo2GlF0yXNS38nQbM9DMofTBNxW6EbJBuU3IQne+5w+KJ+tPUBbwxIkEuh0lDk0vi5ABYt/a4Gxz6fGy08HdFsPN4/w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(158342451672863)(166708455590820); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:CY4PR15MB1190;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1190; X-Forefront-PRVS: 00594E8DBA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(24454002)(199003)(377454003)(189002)(5660300001)(107886002)(189998001)(4001350100001)(86362001)(5001770100001)(31696002)(97736004)(2906002)(23746002)(31686004)(106356001)(83506001)(15975445007)(7846002)(77096005)(65956001)(117156001)(230700001)(64126003)(66066001)(105586002)(50466002)(3846002)(101416001)(92566002)(2950100001)(33646002)(47776003)(50986999)(586003)(31430400001)(68736007)(19580395003)(8676002)(7736002)(42186005)(81156014)(81166006)(65826007)(65806001)(36756003)(305945005)(6116002)(76176999)(2201001)(54356999);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1190;H:[192.168.1.153];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1190;23:2Bo1xQm8qs1t/REAsx0Y/LNfj0vb70r/h/H8U?= =?Windows-1252?Q?TT8kq3zXOPiuLMxb3vVXKRTW4+6XvOZ613vZmqOTx2xudHBdql0uPfzv?= =?Windows-1252?Q?DbjLhc3XXEOvFJQ2avhuNDmDOQ7x1mZISw9QdWh/IWbIGn7PSEYtOagH?= =?Windows-1252?Q?CH/HuaY/rh8P1K5/F+yZ7xd9LoNPLFtq0jPCWqgMA8BXUlgZQk0q/iHk?= =?Windows-1252?Q?38lwtWpM321GgdZr1HFvS3MQeW1TaJ/MMJrnDyWgXAqprBsNUZgABHM4?= =?Windows-1252?Q?Hqm3V/AMW1RQCvDY1Pe3+Cddys6nMEq8yNXLkQrivX2FJsBrJWAY90Ea?= =?Windows-1252?Q?eLyiSuaztNwRrUGI2QWXpxaXaHmwuqH4RKQqOUncC234XnIPj02+tI/6?= =?Windows-1252?Q?rLVz5+WpTQsjucEIr7uDsAA6i5AT+HFTsr4cfsY7G5ndb//MrcgvrBlZ?= =?Windows-1252?Q?AdxhDiZHyc5LjI8KMVRWyNdMoxXX+vK5QUbdq+6JluJJbLjdyFi9zmsq?= =?Windows-1252?Q?sOb3b/59X9KaXPLmeTQMvNmTWPoHxokgdVX7xr5ZM85HbGiCVujg7rqk?= =?Windows-1252?Q?lvAJk3gktsZlhMB07+jEwpOPsn9gIvWhhy9/gklUPz7G7ShBRDmU2mdq?= =?Windows-1252?Q?B9vzbmbIWftm5LcT5EB6zFPqBeAcXTqGEDeiTdlOYdSax+rN8JwY9OhZ?= =?Windows-1252?Q?W6lo8xGpDDnYJdqt3631IQEsrg2tHFdpf6dYX3OipDHQbNYQ6jQ+8CSD?= =?Windows-1252?Q?q6TdGW+hl9BXBBVevZmlQnQlqwsafkBHPx5+8BKB6oAKeetE+UkKuP78?= =?Windows-1252?Q?52AMvCbvTrTTz+NS3FiHPCXrqA5GS+SUifiA/KpmxNCDzkf9H04mxTt9?= =?Windows-1252?Q?kGty2cN00OujMjM7Ws6UyE7C6DdA7F5UjP5UfwiYJyvygDuA4YXlRnGW?= =?Windows-1252?Q?+vv149DXYXS++qzEKt6vD7izrV7ulUis/cCQPdTxTcz9k1gXe098+28K?= =?Windows-1252?Q?EIPmmu18NRpZzPnVB2QxN7AbSmO/cqMCJebTntOJoKqJw8T0ACx7KdNM?= =?Windows-1252?Q?Q56u1m/E8SRKrSRSOHsJS0aRgd1tCFj72CqgI5F2mOFkkTRMWtFM98Cj?= =?Windows-1252?Q?9iF264oVl0rmSxs9XsuU5uvbzZvDRvKzn3J/oowj3Bd/qXsqU121UzOt?= =?Windows-1252?Q?CfLGLvwm2Ie7CynCYjB1DxOHMp3ixrBYzimyWrMB4JmlOehfUYTfn+WI?= =?Windows-1252?Q?z51AhWePEU+9TDKE7GKTXZifJ9rZCdNlhRtVDfSMgp3pLKCRIq0UsPl/?= =?Windows-1252?Q?yVVWL6xfpFMihynuTivPmtYUoav9KJazlJlMwjYHtCd6jfMUiE9yLlU4?= =?Windows-1252?Q?n6o7K+7tDS/eOcuf/NXceONnfMyP8qGT7kPcyQBQLIWeOwzQANG9kJ7b?= =?Windows-1252?Q?Ad9MtCQhjMfPT/qbGZxI46BO8v3LwK4HFzqZ1qzLDCVsda45lOLNl6p4?= =?Windows-1252?Q?DG3Ygw=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1190;6:0L0xF+9mRigF4ftkvMzEuAkgvAgvoT+xOppNA1ccKuK4YRovYLogVno+fC+j6gQPT72E7flxTqUjHV8vHlbD/WhuX6a3qxlJ4iU2mkSxu7ee4NOeFKxE5DI4oNbKW8Va0BPP111Ejm9C2WwotVanrhvw5mULzZKQlBlRrfpRQ2MFjpS0Oa0C4hhvw/zOL09Ve9LQSgfuvQOn9xFk7+ldneJbBd9H9TDDrNwYr6YLkYyVncxUr6y/6BjASfQe58S34eQFT/eKZ1T/BwlvS0wOh1KySq/ZSLquKzKHKIcfikw=;5:21dqBEGZ2XUDfHcSmsu1fQjBXyPr+9FAlHQgj5Lku8PFyAjUURHHdxMqsZZbosHMfjMnCAnhBDh0UKZHNtfl6nGRvcoEM5+N/1Z6bAsfMmH3K2sXKgJII7JPYLfimE6zL2npRQbjIZES/3CLiCbm2g==;24:poDVEPyObK8o+t78njuH3NQxIfsTpY+P7XeMQ1GHGjXI//wsAognXE6pgiiB9NQtEOI8XAkFrWYVvFEQGZCZHMXwKnCzegHS3aagb8es5fM=;7:5NqhLQmvz2lISGQjMwv1EVyxDbjVr+eb8EVQjDlbiP0TNVxSBgOFev9tkNLm9EfgzGKUbQoKD4alRTnMhAytsbQhV6Djow6D/XhURu6mEKwjYnYz15eI7Sj5jXh8kxBxgw8prdPjvoIfwsEuKR3fsnhnJ4F4vAr9RsiNba/0AtIur4eSFn7SjG2IiWXZn38QYeA/+GdfiT8wDw0cGNXndmWTTVVkUPuzxVwmrkV418QqeK4yFqM/o2m0O7lzY9du SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1190;20:z+hbQZWy8N8AWgHfzyGnJoBvGZcbLEbCBOnNOJxfqBAavPoQoTdhbtkDzFO2u7EuTCrhQHP24u0g1HW78vSZBbAun20RqCFEiIubGCXCCK57NTWNI3XXjDI4W2qiDfEoqhS4xSnKWwzdIN6RW1qdmiYJiQs8siB8Ln7952AT4CI= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2016 20:13:50.9070 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1190 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-08_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/08/2016 01:33 PM, Josef Bacik wrote: > This is a patch series aimed at bringing NBD into 2016. The two big > components of this series is converting nbd over to using blkmq and > then allowing us to provide more than one connection for a nbd device. > The NBD user space server doesn't care about how many connections it > has to a particular device, so we can easily open multiple > connections to the server and allow blkmq to handle multi-plexing over > the different connections. This drastically improves performance > with multi-threaded workloads over NBD. The multi-connection support > requires some changes to the NBD userspace client code, and you can > find that code here > > https://github.com/josefbacik/nbd > > I have been testing this for a few months and it is pretty solid and gives > excellent performance improvements. Thanks, Not only are these nice performance improvements, it also cleans up the code a lot and kills crufty old driver code in favor of using the proper APIs instead. I have applied the series for 4.9. -- Jens Axboe