From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751950AbdLEU1T (ORCPT ); Tue, 5 Dec 2017 15:27:19 -0500 Received: from mout.web.de ([212.227.15.3]:62642 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbdLEU1O (ORCPT ); Tue, 5 Dec 2017 15:27:14 -0500 Subject: [PATCH 1/4] uwb: Delete an error message for a failed memory allocation in hwarc_probe() From: SF Markus Elfring To: linux-usb@vger.kernel.org, Andrey Konovalov , Greg Kroah-Hartman , Johan Hovold Cc: LKML , kernel-janitors@vger.kernel.org References: <994a4a57-cfe6-91b5-5fc1-d4153cc5b0e6@users.sourceforge.net> Message-ID: Date: Tue, 5 Dec 2017 21:27:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <994a4a57-cfe6-91b5-5fc1-d4153cc5b0e6@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:V+XX5OsVkGRSJ1pvQPOiHk/FUl/E7CQtPyadMH3XtcSrsr2cIg0 QW0W7hMIL/CEux5Vg6ciYDu+6112fBreLDayR/Wm+CtBEOls1t/BKIOrbKN9wwauMuhaX5d 0XqUWE18IHeYfO7++jVFsEu0PTtQ9nzZFn4wqar8QJr9nPSgS+4932lQ/FcSj9XVH2rGOJ/ Qz8LLg1Z1s3XUz825CyOg== X-UI-Out-Filterresults: notjunk:1;V01:K0:w+xX75DdNyw=:cGBhHqFxo9cd1tVv63quUV ZlvfAGV6lmRfhZuM8/LqA/zNoWSsrBvI2KqrqsJDIJCY3uWyHf3peJTUQFuvLnIVkpcoRPtui +VzUfQSPx3Pg+FNVMHVGO7ov5NLddxnLInrRkB+Vs2FFxeNmONPoqBNgqe40WcWj3otti70uX Zr+ewMBdzaWkNvyVsh1yd7r0RlLP3Ru7H7gFZxFl49cURjLSsqo1ClwOXjmYscnjlsBFc4xZk 3GYrs5DlPBgxna5eQDDdKbQY3SoONbSSVsUnxsEobjwKbcubX2oVSwmfHLN7z5P7Uz4nuhYDa tBONwL/quR6uxwRMkkQJJ6qoM1EkHBoYISdzdw/dkWF4ep3aiBxx/UEvLl23w7eUq20xv8iT8 BpQGPtfaC949QL8fp6pzQKMS2BVYiBEBXP8iwwkFjhEAzSZ4rZpc2Sp1dMrQBJO8ncJGbJcGe gmoDwHtvNYYEteo3hbvq4RAvy7A7Y2nKVcsKaGRVuv3dNuQzsFW0CPcGKs/MGwp0zlRWau50+ NGAUnXG+efrI2hD68jr5613WOgDn0ommgtSm/HGZyyqcwJRoxYv8hdkAECQktoQhdRDnVREPb 94aWPuNBJSxz0ZLoxJ2Dij0me1mtAMKnJVbB8qHCX+IenNZpAkeEmWtNd2qIR4nII5/E0X6K2 PCFCQynGlmuf33TtYsKOM8l5D0zDLP008s1v1wpe8KI05iC86Ttk8J5iOcSKhNmGCmDJhOWxF 4PEh8ksPpnsTIRNQhEq90okFtPv3bdEXOTf4sWLoMrwpLOE38HcI+luRR8SkIQetKNwxRZecL j8xJC5aTBr5bgI4VJ4QJOPP6qn9i6jMiDCmPiCvArYOT9dUcjw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 5 Dec 2017 20:30:50 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/uwb/hwa-rc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/uwb/hwa-rc.c b/drivers/uwb/hwa-rc.c index 9a53912bdfe9..ecd1f0d60487 100644 --- a/drivers/uwb/hwa-rc.c +++ b/drivers/uwb/hwa-rc.c @@ -835,10 +835,9 @@ static int hwarc_probe(struct usb_interface *iface, goto error_rc_alloc; } hwarc = kzalloc(sizeof(*hwarc), GFP_KERNEL); - if (hwarc == NULL) { - dev_err(dev, "unable to allocate HWA RC instance\n"); + if (!hwarc) goto error_alloc; - } + hwarc_init(hwarc); hwarc->usb_dev = usb_get_dev(interface_to_usbdev(iface)); hwarc->usb_iface = usb_get_intf(iface); -- 2.15.1