From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Del Regno <angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Abel Vesa <abelvesa@kernel.org>,
Andy Gross <agross@codeaurora.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Shawn Guo <shawn.guo@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] arm64: dts: qcom: msm8998: wire up interconnect paths
Date: Tue, 20 Oct 2026 09:16:15 +0200 [thread overview]
Message-ID: <aee928e2-909a-456a-8ab4-66d8b5aaeaf5@oss.qualcomm.com> (raw)
In-Reply-To: <20261019-msm8998-icc-v1-8-c2da3934b6c8@oss.qualcomm.com>
On 10/19/26 4:12 PM, Dmitry Baryshkov wrote:
> With the NoC providers described but no consumer referencing them, the
> NoC bus clocks stay at their boot rates: nothing votes for DDR or
> config bandwidth, so masters such as MDSS or UFS run on whatever the
> bootloader left behind.
>
> Add the interconnect paths for the GPU, MDSS, Venus, UFS, USB and SDHC2.
> PCIe is deliberately left out: MSM8998 has no route from the CPU to the
> PCIe config slave, and requesting one only makes the PCIe driver fail
> to probe.
On upstream, sm8450 is the first one to have one wired up in DT
(intriguing), sdm845 is the first one to have one in the icc driver
Downstream, 8450 and earlier do not have a path defined on the PCIe
node but clearly that relies on lucky ordering
I threw the LLM at msm8998-bus.dtsi and it said:
The only edges into slv_pcie_0 come from three masters:
- mas_bimc_snoc_1 (line 669), reachable only from slv_bimc_snoc_1,
which is fed by mas_oxili and mas_mnoc_bimc. Neither is reachable from
the apps master.
- mas_a1noc_snoc (line 679), reachable only from slv_a1noc_snoc, which
is fed by PCIe, USB3, UFS, and BLSP2 masters.
- mas_a2noc_snoc (line 692), reachable only from slv_a2noc_snoc, which
is fed by mas_cnoc_a2noc, IPA, SDCC2/4, TSIF, BLSP1, and
mas_cr_virt_a2noc. The last two come from slv_cnoc_a2noc (fed only by
mas_qdss_dap) and slv_cr_virt_a2noc (fed only by mas_crypto_c0). Neither
of those is reachable from the apps master.
But I wonder if it's some sort of an oversight. Can we try to
regenerate the paths internally?
Konrad
prev parent reply other threads:[~2026-10-20 7:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 14:12 [PATCH 0/8] interconnect: qcom: implement support for MSM8998 Dmitry Baryshkov
2026-10-19 14:12 ` [PATCH 1/8] dt-bindings: interconnect: add Qualcomm MSM8998 NoC Dmitry Baryshkov
2026-10-20 8:24 ` Krzysztof Kozlowski
2026-10-20 10:25 ` Dmitry Baryshkov
2026-10-19 14:12 ` [PATCH 2/8] soc: qcom: smd-rpm: Handle zero-length errors Dmitry Baryshkov
2026-10-19 14:12 ` [PATCH 3/8] interconnect: qcom: icc-rpm: depopulate SMD RPM child NoCs Dmitry Baryshkov
2026-10-19 14:12 ` [PATCH 4/8] interconnect: qcom: icc-rpm: skip duplicate SMD RPM node votes Dmitry Baryshkov
2026-10-19 14:12 ` [PATCH 5/8] interconnect: qcom: icc-rpm: Allow negative QoS offset Dmitry Baryshkov
2026-10-19 14:12 ` [PATCH 6/8] interconnect: qcom: add MSM8998 interconnect provider Dmitry Baryshkov
2026-10-19 14:12 ` [PATCH 7/8] arm64: dts: qcom: msm8998: add interconnect provider nodes Dmitry Baryshkov
2026-10-20 7:11 ` Konrad Dybcio
2026-10-19 14:12 ` [PATCH 8/8] arm64: dts: qcom: msm8998: wire up interconnect paths Dmitry Baryshkov
2026-10-20 7:16 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aee928e2-909a-456a-8ab4-66d8b5aaeaf5@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=agross@codeaurora.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®