From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.227.137 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795039718; b=z6mEkF1DI1dMRDr1BG5eecn0qHyuCCVsGYFmoIpTIxirHu8TyjkJ0TvOJ3PyIgGvkPJP ijWzBuhwMlnICm2FTbYoLq6N5fhc/8bZgd7Ny6uMFsB83xgTEWMCYphPb7jQ5Mw1v9XO9 GJKjZ9tICDoPSfgZbiEM+wyxSfdfRplkzijJWpYmO7cZmtzKg7ir2ShaCZMyUsdVVfBVx B6ae0EwB1Ysx3c0AFo6zh/DyzitDDwMXt9eH2jcfik6vRuTejxqzPcauN0+mvT1YsSILB xERLyimWozGC2NcSmM+9npOrZPFZd00sD57oshZhs9q9GWxidvRF4eycBLP6HGcnRPQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795039718; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: Content-Type:Content-Transfer-Encoding:MIME-Version; bh=48GpV2tL7XVTAarQnrcMPM8Usr/dY/fptCTJVKAYBQY=; b=ttVFOoqO2/nE592FVieuwMeqWVV50aGMnQlKRq1ns23d0i+A41huDkUp7wdoqdiZcJgD Qhwq1jQ2f2/ytyo9xgX2sKbvG1Ot5+FiRcrqUhPzO3rqcpqkbDpFjA+WpWx5cGnUoufua EICdQRu1vPJgjipFz//3LM1+drti9jrGo6bXDaPyzgZVL2puLISObwAYjUgdxXH2cfucl cwW6CMFa1DNTIpiJXB0MQQnRSMH7PUe/8zNPlMOseagPAUT/e6mWdYJbk2RBV3TfLIIoS t7DhNMOkqUUF/SbJZS3D3jY6gRmG6XRPu8yXKIrPicNK0TC9+1dHH3Xff9FNNxmht1w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=TL+qoGVE; arc=none smtp.remote-ip=74.125.227.137 Received: from mail-pj2-f9.google.com (mail-pj2-f9.google.com [74.125.227.137]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3AB4606A331 for ; Wed, 18 Nov 2026 22:08:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org F3AB4606A331 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=TL+qoGVE Received: by mail-pj2-f9.google.com with SMTP id 98e67ed59e1d1-3b18c01238eso454534a91.1 for ; Wed, 18 Nov 2026 14:08:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795039717; x=1795644517; darn=vger.kernel.org; h=mime-version:content-transfer-encoding:content-type:references :in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=48GpV2tL7XVTAarQnrcMPM8Usr/dY/fptCTJVKAYBQY=; b=TL+qoGVENBtqdSL1KVPq7bNBAjkkVhIwlqKAUADbqYHk4AkYI+nRvsOWAO2mGrIxHj nBz+igXfMC5XechbWZtetuHpApE5n6+lZNRoEfYS4bAnH6z/0ZTDY8KlnTRj9RhbMzye I6I+eyyIFk1yA2toiirFyOIsuUv2r4V1Q5scTbNY6ow+mlMy/Alp1sjHdR2zr2/AYCt4 QGqEE2TJudyL9ZxgRhw/LpZR/YqqXqRi1Q5C5prDCvZkW8JPxH5tOK1Co5oZxRYp8Qc1 lIoa5oYKpqKwJumMzX9Z+uWv2ECf5dNKH/4iGGl1/7zVJqleRGmJBK5EV5poLVck17Mk YAcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795039717; x=1795644517; h=mime-version:content-transfer-encoding:content-type:references :in-reply-to:subject:cc:to:from:message-id:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=48GpV2tL7XVTAarQnrcMPM8Usr/dY/fptCTJVKAYBQY=; b=dJZELlejZAtE3kJ+i5fu2ModSGt8edXmEgHTThvxS60sZT4NRWbThfDN35bL2uDtze Chx2rB4KmlcBsV3cJ4NogOgD15EdAlTH7naZCS3CXFEzYuCKusD8VIziqHbxEwYNb6nI qcsap0DeN/bFsE0ntjBJmlZ/heOtAGwOcVOaryDt/YH+pF4+1PtdCECgIiYPYReowwEr 0FpNT6Yf7GyQMfqbP1UvoGhIrj6HxITU22S62exCyeBAuedWft1mBDObQtsifokbMr0N Ivb1SW+/AI8nt013Iznj5Pv91/LTYEzikudLEODbsWnznXv0PW2xgyNwgsAXXlmhngWb 5zAw== X-Forwarded-Encrypted: i=1; AL+hErFR4VDqMnDifJpEMR5t5v3GRHSIair4dubrVJDPtVN1Mobhu0ONVWSUEoDRIWZeo0xs/AQJipoI08GeCJM=@vger.kernel.org X-Gm-Message-State: APuU4Z+9Ap++Tz86WUTMD6CR9aiIi4IPVTgsYYvcZvMJPX3tF+uyog8n 125c48xi6olF7zf5IUz3/L4dq1TNcfD/JBKcftdi2raqiEdTIKXooQqQ X-Gm-Gg: AZFdTZe4hs95oLGJDzNkXeMw5rMBxeEN2Rxou3fk4BHUnovxd/wPZU5APjNAq+Adxc6 ETkeM3ng5DshPblKhwstgBYOoV1mE5nZavgeJBXZjh/NOznyE0AnbPwlQKyuEMeheWkN9kaD9ye b7myig+orodqLoYuDwtDr1+R3NsHLH6rU4dUfDWfoSGjLBLqYwBN2cu5XQ9g4cE3JnxENhB/9Yh FXpPFclpfIPslO0UXi3qYmVvzqMvcbXgzzWRr5HvksC6ffvFkEzNLiLVf4SPMhxGzFRROPD0EyH 7O8mDYcHQYZMlTfnTiX3/oO0l1DaBBJ4PioT4h1lzj7A7iBP25Zqh+ruxfe+RHpDg7nb/UN27wv nnJBedK3vaExCmxPHGvJnxPvhh8YZPnvNHvzZp6WvOlwoil5y6NXr/1VaP9z8u9OHbTWk71qvjZ JpnjSWDROxL7nuBO7fE+7sz7DlUfzAjz/N8mpLgv+Ib9zThhV8WYulOdkSnwQqt+bEPrB9kyJO4 vOx0obpRkFfm02FCktLuNLKVqG7BFwf104qphBqXGLZbSpCI+Qa1fumHlhMrBSwdGrPM0Pv2P+u 4rc= X-Received: by 2002:a17:90b:2ccf:b0:3b3:cb22:72d0 with SMTP id 98e67ed59e1d1-3b3d07656e8mr4366165a91.29.1795039717105; Wed, 18 Nov 2026 14:08:37 -0800 (PST) Received: from localhost ([2403:2c80:6::107b]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b3fe09df73sm93624a91.9.2026.11.18.14.08.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 14:08:35 -0800 (PST) Date: Thu, 19 Nov 2026 06:08:29 +0800 Message-ID: From: Cody Kang To: Thomas Zimmermann Cc: David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Vinod Koul , Neil Armstrong , Haylen Chu , Michael Turquette , Stephen Boyd , Brian Masney , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yao Zi , Uwe =?utf-8?q?Kleine-K=C3=B6nig?= , Guodong Xu , dri-devel@lists.freedesktop.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v2 10/17] drm/spacemit: add Saturn DPU KMS pipeline In-Reply-To: References: <20260809-k3-display-v2-0-327d7910bf71@gmail.com> <20260809-k3-display-v2-10-327d7910bf71@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Hi Thomas, On Mon, 14 Sep 2026 15:58:39 +0200, Thomas Zimmermann wrote: > Hi, > > please find a review below. I've only mentioned most issues once, they > are usually throughout the code. Please fix all instances then. Thanks for the review. Will fix all instances. > Am 09.08.26 um 15:14 schrieb Cody Kang via B4 Relay: [...] > > + drm_atomic_crtc_state_for_each_plane_state(plane, pstate, crtc_state) { > > + u32 rdma_id = to_spacemit_plane_state(pstate)->rdma_id; > > + u32 layer_fbcmem_size = > > + to_spacemit_plane_state(pstate)->fbcmem_size; > > If you need to check plane state, please do this in the plane's > atomic_check. For atomic commits that only change plane state, the > CRTC's atomic_check might not run, I think. Will do; the check moves into the plane's atomic_check. > It looks like this code allocates memory. This is is something that > should be done globally. It does not allocate memory: it partitions the on-chip line buffer. With one plane per CRTC nothing is shared between planes, so the plane's own check is enough. [...] > > + if (!drm_dev_enter(crtc->dev, &idx)) > > + return; > > drm_dev_enter() and drm_dev_exit() protect hardware access. Given hat > you have a tracepoint below, you certainly don't want to return here. > It's is better to write code like this > > atomic_enable() { > > if (drm_dev_enter()) { > > // do HW access > drm_dev_exit() > } > > } > > although not many drivers do this. Will do. > > + > > + trace_spacemit_crtc_atomic_enable(a_crtc->dev_id); > > Why is your modesetting code is filled with tracepoints? Most other > drivers don't need them. There is debugging infrastructure available in DRM. Will drop them. [...] > > + ret = reset_control_bulk_assert(ARRAY_SIZE(priv->pipe_resets), > > + priv->pipe_resets); > > + if (ret) > > + dev_warn(a_crtc->dev, > > + "failed to assert resets: %d\n", ret); > > + usleep_range(10000, 20000); > > + a_crtc->first_modeset = false; > > + } > > Just no. This code belongs into driver or platform init. It is > definitely not for mode setting. Will do; it moves to probe. [...] > > + usleep_range(10000, 20000); > > + } > > + > > + drm_crtc_vblank_on(&a_crtc->crtc); > > I'd say you want to enable vblanking after programming the display mode. (?) Will do. > > + > > + spacemit_crtc_init(a_crtc); > > The code is full of these tiny helpers. Please inline them. And please > also avoid the callbacks that these tiny helpers invoke. The DRM > interfaces are your abstraction interface. Please don't introduce > another one. Will do. [...] > > + /* > > + * MMIO on a clock-gated DPU stalls the bus, so an in-flight handler > > + * must finish its status reads before dpu_pm_suspend() gates the > > + * clocks. > > + */ > > + if (a_crtc->irq_online > 0) > > + synchronize_irq(a_crtc->irq_online); > > This irq is unrelated to vblanking, I presume? It is the vblank interrupt as well: the one line carries the DPU's vsync, config-ready and underrun status. The synchronize_irq() is not about vblank, though. A register read on a clock-gated DPU stalls the bus, so a handler that is already running has to finish before the clocks stop. With the move to runtime PM (next point) the call will sit in the runtime suspend callback, ahead of the clock gating. > > + timer_delete_sync(&a_crtc->cfg_rdy_timer); > > + > > + /* Close the ISR's MMIO gate before the clocks actually stop. */ > > + a_crtc->clocks_on = false; > > + dpu_pm_suspend(a_crtc->dev); > > This whole DPU PM stuff doesn't seem to belong here. There's are > device-PM ops for controlling power management. It might happen that > compositors disable the CRTC for simple mode setting. This should not > suspend the whole device. Will do; it moves to runtime PM. > > + spin_lock_irq(&drm->event_lock); > > + if (crtc->state->event) { > > + drm_crtc_send_vblank_event(crtc, crtc->state->event); > > + crtc->state->event = NULL; > > + } > > + spin_unlock_irq(&drm->event_lock); > > You need set up the vblank machinery to send the event on the next > vblank irq. See [1] for a simple example. > > [1] > https://elixir.bootlin.com/linux/v7.2.5/source/drivers/gpu/drm/drm_vblank_helper.c#L51 Will do. The event will be armed from the config-ready interrupt rather than in atomic_flush, since the next commit must not start before the hardware has taken the current command lists. [...] > > + trace_spacemit_crtc_atomic_check(a_crtc->dev_id); > > Please don't add your own tracepoints. Will do. > > + ret = spacemit_crtc_atomic_check_fbmem(crtc, state); > > + if (ret) { > > + drm_dbg_kms(crtc->dev, > > + "failed to satisfy fbcmem size for all rdmas\n"); > > Drivers should only use drm_dbg(). drm_dbg_kms() et al are for DRM core > and helpers. Will do. [...] > > + if (WARN_ON(!crtc->state)) > > There are helpers like drm_WARN_ON() et al. Please prefer them over > WARN_ON() and other non-DRM counterparts. Will do. [...] > > + ret = drm_vblank_init(drm, drm->mode_config.num_crtc); > > + if (ret) { > > + dev_err(dev, "failed to initialize vblank\n"); > > + goto err_unbind_all; > > + } > > Better do this after running drm_mode_config_reset(). Will do. [...] > > + /* The programming paths use the raw rectangles, so refuse to clip. */ > > + if ((state->src.x1 >> 16) != src_x || (state->src.y1 >> 16) != src_y || > > + (drm_rect_width(&state->src) >> 16) != src_w || > > + (drm_rect_height(&state->src) >> 16) != src_h || > > + state->dst.x1 != state->crtc_x || state->dst.y1 != state->crtc_y || > > + drm_rect_width(&state->dst) != crtc_w || > > + drm_rect_height(&state->dst) != crtc_h) { > > + drm_dbg_kms(plane->dev, > > + "clipped plane rectangles not supported\n"); > > + return -EINVAL; > > + } > > What's the matter with this code? > > Allocated buffers can be larger than the display mode. If the hardware > cannot handle this, it might become a problem in some setups. It worked around the driver programming the unclipped rectangles. Will fix. > > + /* One-dimensional sources are invalid (only 0x0 = constant fill) */ > > + if ((src_w == 0) != (src_h == 0)) { > > + drm_dbg_kms(plane->dev, "unsupported src_w %d src_h %d\n", > > + src_w, src_h); > > + return -EINVAL; > > + } > > I'm not aware of any driver testing this. The above calculation of > state->visible should have detected this case. Will do. [...] > > + cur_state->mmu_tbl.size = > > + ((PAGE_ALIGN(fb->obj[0]->size) >> PAGE_SHIFT) + > > + HW_ALIGN_TTB_NUM) * 4; > > + cur_state->mmu_tbl.va = > > + dma_alloc_coherent(a_crtc->dev, cur_state->mmu_tbl.size, > > + &cur_state->mmu_tbl.pa, > > + GFP_KERNEL | __GFP_ZERO); > > + if (!cur_state->mmu_tbl.va) > > + return -ENOMEM; > > Resource allocation/deallocation like this should better be done in > begin_fb_access/end_fb_access when you need them for the commit. > User-space compositors might send in a large number of states only for > atomic_check'ing. There's no point in allocating actual memory then. Will move the allocation to prepare_fb. Cody