From: Jie Luo <quic_luoj@quicinc.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: phy: at803x: add QCA8084 ethernet phy support
Date: Sun, 5 Nov 2023 15:42:02 +0800 [thread overview]
Message-ID: <aef83003-6ddb-f09c-5a49-765273e71ceb@quicinc.com> (raw)
In-Reply-To: <1aaf7a4b-fc7e-4203-af71-740bc187d046@lunn.ch>
On 11/4/2023 10:19 PM, Andrew Lunn wrote:
> On Sat, Nov 04, 2023 at 02:25:25PM +0800, Jie Luo wrote:
>>
>>
>> On 11/3/2023 9:01 PM, Andrew Lunn wrote:
>>>> #define QCA8081_PHY_ID 0x004dd101
>>>> +#define QCA8081_PHY_MASK 0xffffff00
>>>
>>> That is an unusual mask. Please check it is correct. All you should
>>> need its PHY_ID_MATCH_EXACT, PHY_ID_MATCH_MODEL, PHY_ID_MATCH_VENDOR.
>>
>> Thanks Andrew for the review.
>> The PHY ID of qca8084 is correct, i will update to use PHY_ID_MATCH_EXACT in
>> the new added entry for qca8084.
>
> Note, i asked about the mask, not the ID. Is PHY_ID_MATCH_EXACT maybe
> too exact? Is there the option for different revisions of the PHY? Can
> one entry in the table be used for multiple revisions?
>
>
> Andrew
>
> ---
> pw-bot: cr
Sure, Andrew, qca8084 is the different model chip from qca8081, and
there is only one PHY ID used currently for the qca8084(4-port) and
qca8082(2-port), but we can use PHY_ID_MATCH_MODEL for new added entry
of qca8084 and qca8082.
next prev parent reply other threads:[~2023-11-05 7:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 12:35 Luo Jie
2023-11-03 13:01 ` Andrew Lunn
2023-11-04 6:25 ` Jie Luo
2023-11-04 14:19 ` Andrew Lunn
2023-11-05 7:42 ` Jie Luo [this message]
2023-11-04 19:35 ` Russell King (Oracle)
2023-11-05 8:09 ` Jie Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aef83003-6ddb-f09c-5a49-765273e71ceb@quicinc.com \
--to=quic_luoj@quicinc.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®