From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Junxiao Chang <junxiao.chang@intel.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, gye976@gmail.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, lars@metafoo.de
Subject: Re: [PATCH v5] iio: buffer: fix warning in requesting threaded irq
Date: Wed, 22 Apr 2026 10:53:53 +0300 [thread overview]
Message-ID: <aeh-kV-XNSaWhohW@ashevche-desk.local> (raw)
In-Reply-To: <20260423014426.1999735-1-junxiao.chang@intel.com>
On Thu, Apr 23, 2026 at 09:44:26AM +0800, Junxiao Chang wrote:
> IRQF_ONESHOT is for threaded IRQ. If there is no threaded IRQ
> handler, this flag should not be set.
>
> This change fixes a warning during booting with kernel v7.0-rc3.
> Hardware: ARLs(Ultra 9 285) desktop
> Software: Ubuntu 24.04 + v7.0-rc3 kernel.
>
> WARNING: kernel/irq/manage.c:1502 at __setup_irq+0x1639/0x2510, CPU#3: iio-sensor-prox/974
> Call Trace:
> request_threaded_irq+0x2c7/0x490
> iio_trigger_attach_poll_func+0x353/0x6b0
> __iio_update_buffers+0x2420/0x2c70
> enable_store+0x183/0x270
> dev_attr_store+0x5e/0x90
>
> There is no threaded handler in thiggered buffer setup, e.g. vf610_adc
A typo here: triggered.
> and hid-sensor. They might introduce this warning.
But you see them IRL, right? Can you just add a point to the above list:
Hardware platform: ...
Hardware sensor in use: ... <— this to be added
Software stack (OS): ...
?
With that you may drop or rephrase that to
"There is no threaded handler in triggered buffer setup in other drivers,
e.g. vf610_adc and hid-sensor. They might introduce this warning."
> Signed-off-by: Junxiao Chang <junxiao.chang@intel.com>
> ---
...
> V3/V4: https://lore.kernel.org/linux-iio/20260421103807.7ca935e9@jic23-huawei/T/#t
('T/#t' part is not needed)
> V2: https://lore.kernel.org/linux-iio/20260418002334.3643504-1-junxiao.chang@intel.com/T/#mc0803722dce6585bbc8c9e0ec8289bd96afe99aa
> V1: https://lore.kernel.org/linux-iio/20260418002334.3643504-1-junxiao.chang@intel.com/T/#mf0eba6c23049d15c2b43ea5528b5f5a47e216c58
Click there on the permalink to get the proper link to the mail, now it's an
indirect form of the links.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-22 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 1:44 Junxiao Chang
2026-04-22 7:53 ` Andy Shevchenko [this message]
2026-04-22 10:09 ` Jonathan Cameron
2026-04-22 13:11 ` Chang, Junxiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeh-kV-XNSaWhohW@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gye976@gmail.com \
--cc=jic23@kernel.org \
--cc=junxiao.chang@intel.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®