From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Maxwell Doose <m32285159@gmail.com>
Cc: ak@it-klinger.de, jic23@kernel.org, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] iio: proximity: srf08: Replace sprintf() with sysfs_emit()
Date: Wed, 22 Apr 2026 15:53:55 +0300 [thread overview]
Message-ID: <aejE42knD_s5rsGy@ashevche-desk.local> (raw)
In-Reply-To: <20260422124505.8875-1-m32285159@gmail.com>
On Wed, Apr 22, 2026 at 07:45:05AM -0500, Maxwell Doose wrote:
> Replace sprintf() function calls with sysfs_emit() and
> sysfs_emit_at(). While the current code is fine, sysfs_emit() is
> preferred over sprintf(), and will help modernize the driver.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
...
> v5:
> - Reversed decision to put sysfs_emit() call on one line per Jonathan
> Cameron's request.
Oh, I missed that. In any case I consider my suggestion is still better,
it keeps driver in limits and makes the wrap on logical boundary.
> - Fixed some of my editor's tab-spacing issues
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-22 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 12:45 Maxwell Doose
2026-04-22 12:53 ` Andy Shevchenko [this message]
2026-04-24 17:53 ` Jonathan Cameron
2026-04-24 18:18 ` Maxwell Doose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aejE42knD_s5rsGy@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=ak@it-klinger.de \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m32285159@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®