From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BF72366561 for ; Wed, 22 Apr 2026 19:23:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776885840; cv=none; b=aW75VuPpcP5I5uuuFzXF0a1hdpU2ZXNz4PvbEjdfDh8qKibYs8qt/896SDAiWYJZmOWWAeyREdH4+ZHP1YMRLvIZHESFUfixCejb9eUZnWBTH9u61P4dd19Aor3Grzs7KrWToCMIwxrFFTkaRw2vl0SHavIsAwEtMmxOt55TDfc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776885840; c=relaxed/simple; bh=GOlsRhu5LgMi15Pl5cci3wyo6PAC6/sfsNnZtOHlARw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qcOE2/4S5tdFgr/lqsGeGfb0cs059p+0NB+qSLRUk9cuGAorwstu/Gief+9GClRnYj33N9GjWcgvUVFTmj9Wx8o4v38zKMLklMsso/wt+qpXcE77lSvszUzVK2M54faFbJ5tmR3JfcERGAlCQYAQfN6D5Ub7jucURqbq/eQBBKA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=JG+w3/5r; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JG+w3/5r" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776885836; x=1808421836; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=GOlsRhu5LgMi15Pl5cci3wyo6PAC6/sfsNnZtOHlARw=; b=JG+w3/5rGBWBT0qGltzeM8+XCjoLz6vg/pU/s0MMkGwQTM5oiBJD9iiu KBaI5iDn3AbF0y61TpC0xjgMeo3M1Df5P/a4rdph1GhbQazWsA9dA98+a UgeDdkKYTl0sgThVxzS7+UtqdWH9rjSK5K3QEfxhozGJKVQARA5ctnab/ TlUue2ACsYXnDpOTIs2xMOSpELuB0cyLPYTnP1kCxNlfPC3cdvMe8HjCe RknoKF94Pe3Ls4IX4SJt206+76B1w1pyDjmwxUPTeonfL1K580DB1dcAI QYLjKMNh7htim67oVxSJ1bC0E/3SU3gg+ITlXxPKspbAfaJOrxbDcCF4D w==; X-CSE-ConnectionGUID: grHSf+6+SDqLOfJ/vDfTYA== X-CSE-MsgGUID: PTagTqbUSZeUlkQyLhHDJg== X-IronPort-AV: E=McAfee;i="6800,10657,11764"; a="95263990" X-IronPort-AV: E=Sophos;i="6.23,193,1770624000"; d="scan'208";a="95263990" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2026 12:23:52 -0700 X-CSE-ConnectionGUID: 71xVpT6zQV2fFcIjZHCJgQ== X-CSE-MsgGUID: i071P1XcQ8y0zR0XHUc+bQ== X-ExtLoop1: 1 Received: from smoticic-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.201]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2026 12:23:50 -0700 Date: Wed, 22 Apr 2026 22:23:47 +0300 From: Andy Shevchenko To: Josh Law Cc: akpm@linux-foundation.org, kees@kernel.org, James.Bottomley@hansenpartnership.com, linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com Subject: Re: [RFC] [QUESTION] Stuff to do for string Message-ID: References: <313CDBE8-2AE7-4104-9DE0-C119A843A0F4@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Apr 22, 2026 at 05:56:38PM +0100, Josh Law wrote: > On 22 April 2026 17:51:40 BST, Andy Shevchenko > wrote: > >On Wed, Apr 22, 2026 at 05:28:39PM +0100, Josh Law wrote: > >> On 22 April 2026 17:12:37 BST, Andy Shevchenko > >> wrote: > >> >On Wed, Apr 22, 2026 at 03:57:16PM +0100, Josh Law wrote: > >> >> Hello, (this is my first RFC, so maybe cc is bad, but yeah) > >> >> > >> >> What do you guys have planned/would like me to have a look at doing > >in > >> >> lib/string.c > >> >> > >> >> I am home from school so I am virtually free > >> > > >> >Arbitrary things that came to my mind (no particular order) > >> > > >> >- Get rid of strlcat() > >> > >> Yeah, I'm working on that actually :D, privately, I sorta stopped cuz i > >> thought kees was gonna do that, if not, not issue! > >> > >> >- Clean up include/linux/string.h > >> > a) drop extern for functions > >> > b) put the headers it includes into an order and follow IWYU > >> > >> Hmm, yeah, I see it's kind of a mess (in a polite way) > >> > >> >- kill memscan() in favour of memchr() / memchr_inv() > >> > >> Hmm, maybe, is there a crazy amount of files that call memscan()? > > > >You can find an answer yourself. The daily-basis kill feature tool is > >`git grep ...`. > > Oh, yes, I see this now, I should be able to do this, gotta slap the > computer awake cuz sometimes it breaks. So it may take time for me > to submit it, would you like a treewide cleanup, or subsystem by subsystem It depends case by case. As Kees' patch shows in some cases it may touch too many things to be treewide and has to be subsystem / driver focused. > >> I'll also (try ;), yk, school :( ) to review patches for your file. Ig > >> it's the best I do for you lot right now, (I am starting to review most > >> if not all patches in lib), e.g: > >> > >https://lore.kernel.org/all/AA9B2A7E-A88D-457C-8244-50087631B347@gmail.com > >> :) -- With Best Regards, Andy Shevchenko