From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Guangshuo Li <lgs201920130244@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linusw@kernel.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] eeprom: digsy_mtc: fix reference leak on failed device registration
Date: Fri, 24 Apr 2026 11:36:42 +0300 [thread overview]
Message-ID: <aesrmgiKC1uBxek7@ashevche-desk.local> (raw)
In-Reply-To: <CANUHTR9-p7Cc7i=eSjaE2Wp_dEq-1Gw1LWaYDySP86u6=FmJoA@mail.gmail.com>
On Fri, Apr 24, 2026 at 04:21:05PM +0800, Guangshuo Li wrote:
> On Thu, 16 Apr 2026 at 15:52, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Thu, Apr 16, 2026 at 12:52:02AM +0800, Guangshuo Li wrote:
...
> After re-checking it, digsy_mtc_eeprom is a static platform_device and it
> does not provide a dev.release callback. Therefore calling
> platform_device_put() on the platform_device_register() failure path is
> not appropriate here and can trigger the missing release callback warning.
>
> This falls into the same static platform_device pattern pointed out in
> the other reviews, so I will drop this patch.
Ah, good point! Indeed, this device is either present for the entire system
run-time or not at all. Even if it's erroneously attempted to be instantiated
it's still not a big deal.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-04-24 8:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 16:52 Guangshuo Li
2026-04-16 7:52 ` Andy Shevchenko
2026-04-24 8:21 ` Guangshuo Li
2026-04-24 8:36 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aesrmgiKC1uBxek7@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=lgs201920130244@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®