From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2051C4332F for ; Mon, 6 Nov 2023 11:41:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231473AbjKFLlz (ORCPT ); Mon, 6 Nov 2023 06:41:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230018AbjKFLlx (ORCPT ); Mon, 6 Nov 2023 06:41:53 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48354BE; Mon, 6 Nov 2023 03:41:50 -0800 (PST) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3A65pNTM022945; Mon, 6 Nov 2023 11:41:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=gUDEE2dz5GLAemOBWyVoCMY+wl8Y9k+DBPKEwhf8QJY=; b=TuZUH62ib6Q847URwIBJF1gV5x8rzkFhfoR+vXOCSYd1lhDX0xiLMQeBM2GfQBi3BOxM 9CGryYjw8rlnDXoropjC59ucXYgwzRL9nGUnZcKsYeMY7RBIwYHHtiqTaVjy/avlvmKC 6fl6T26bhD/hC918vZbKaOMqZdlS3i+z2XAVQxKoLbZCoOzSOANeMNi+cqS4T8kYCJTt a78/zymUY8tT1HPkL3xWvY2hL3O9t1zmaJDUIxl/9zLmL2WDYlO5dpqXbZeGFblJtT+A bBTKhsO3AhrnhcBu+DyZSPXQiRgfGhFIUYuRvWmWzJQQzex7Bj9bknmW8Qcwy/Vk6f9S sw== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3u5ernkyxm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Nov 2023 11:41:46 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3A6Bfjn4027388 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 6 Nov 2023 11:41:45 GMT Received: from [10.214.66.81] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Mon, 6 Nov 2023 03:41:41 -0800 Message-ID: Date: Mon, 6 Nov 2023 17:11:38 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH 2/2] arm64: dts: qcom: qcm6490: Add qcm6490 idp and rb3 board Content-Language: en-US To: Krzysztof Kozlowski , Dmitry Baryshkov , Komal Bajaj CC: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , References: <20231103184655.23555-1-quic_kbajaj@quicinc.com> <20231103184655.23555-3-quic_kbajaj@quicinc.com> <1830fc44-7bac-4db5-af59-112410d73a64@linaro.org> From: Mukesh Ojha In-Reply-To: <1830fc44-7bac-4db5-af59-112410d73a64@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 6JF5azQjTaONYIU5iqCi5xWindgHQpdS X-Proofpoint-GUID: 6JF5azQjTaONYIU5iqCi5xWindgHQpdS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-06_09,2023-11-02_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 phishscore=0 priorityscore=1501 mlxlogscore=999 malwarescore=0 spamscore=0 mlxscore=0 suspectscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310240000 definitions=main-2311060096 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/5/2023 6:38 PM, Krzysztof Kozlowski wrote: > On 03/11/2023 23:22, Dmitry Baryshkov wrote: >> On Fri, 3 Nov 2023 at 20:49, Komal Bajaj wrote: >>> >>> Add qcm6490 devicetree file for QCM6490 IDP and QCM6490 RB3 >>> platform. QCM6490 is derived from SC7280 meant for various >>> form factor including IoT. >>> >>> Supported features are, as of now: >>> * Debug UART >>> * eMMC (only in IDP) >>> * USB >>> > > ... > >>> + >>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-iot-common.dtsi b/arch/arm64/boot/dts/qcom/qcm6490-iot-common.dtsi >>> new file mode 100644 >>> index 000000000000..01adc97789d0 >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-iot-common.dtsi >> >> I have mixed feelings towards this file. Usually we add such 'common' >> files only for the phone platforms where most of the devices are >> common. >> Do you expect that IDP and RB3 will have a lot of common code other >> than these regulator settings? > > I agree here. What exactly is common in the real hardware between IDP > and RB3? Commit msg does not explain it, so I do not see enough > justification for common file. Just because some DTS looks similar for > different hardware does not mean you should creat common file. @Dmitry/@Krzysztof, Thank you for reviewing the RFC, we wanted to continue the suggestion/discussion given on [1] , where we discussed that this qcm6490 is going to be targeted for IOT segment and will have different memory map and it is going to use some of co-processors like adsp/cdsp which chrome does not use. So to your question what is common between RB3 and IDP, mostly they will share common memory map(similar to [2]) and regulator settings and both will use adsp/cdsp etc., we will be posting the memory map changes as well in coming weeks once this RFC is acked. Thanks, Mukesh [1] https://lore.kernel.org/linux-arm-msm/d97ebf74-ad03-86d6-b826-b57be209b9e2@quicinc.com/ [2] commit 90c856602e0346ce9ff234062e86a198d71fa723 Author: Douglas Anderson Date: Tue Jan 25 14:44:20 2022 -0800 arm64: dts: qcom: sc7280: Factor out Chrome common fragment This factors out a device tree fragment from some sc7280 device trees. It represents the device tree bits that should be included for "Chrome" based sc7280 boards. On these boards the bootloader (Coreboot + Depthcharge) configures things slightly different than the bootloader that Qualcomm provides. The modem firmware on these boards also works differently than on other Qulacomm products and thus the reserved memory map needs to be adjusted. NOTES: - This is _not_ quite a no-op change. The "herobrine" and "idp" fragments here were different and it looks like someone simply forgot to update the herobrine version. This updates a few numbers to match IDP. This will also cause the `pmk8350_pon` to be disabled on idp/crd, which I belive is a correct change. - At the moment this assumes LTE skus. Once it's clearer how WiFi SKUs will work (how much of the memory map they can reclaim) we may add an extra fragment that will rejigger one way or the other. Signed-off-by: Douglas Anderson Reviewed-by: Stephen Boyd Reviewed-by: Matthias Kaehlcke Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20220125144316.v2.3.Iac012fa8d727be46448d47027a1813ea716423ce@changeid > > Best regards, > Krzysztof >