From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752212AbbJWPPH (ORCPT ); Fri, 23 Oct 2015 11:15:07 -0400 Received: from mta01.ornl.gov ([128.219.177.14]:31156 "EHLO mta01.ornl.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751225AbbJWPPF convert rfc822-to-8bit (ORCPT ); Fri, 23 Oct 2015 11:15:05 -0400 X-Greylist: delayed 578 seconds by postgrey-1.27 at vger.kernel.org; Fri, 23 Oct 2015 11:15:05 EDT X-SG: RELAYLIST X-IronPort-AV: E=Sophos;i="5.20,186,1444708800"; d="scan'208";a="114611754" From: "Simmons, James A." To: "'Nilesh Kokane'" , "oleg.drokin@intel.com" , "andreas.dilger@intel.com" CC: "devel@driverdev.osuosl.org" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "suneel.raikar@gmail.com" Subject: RE: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN) Thread-Topic: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN) Thread-Index: AQHRDUuVWsse4hXQq0OhXsleTHu70Z55LZZA Date: Fri, 23 Oct 2015 15:05:23 +0000 Message-ID: References: <1445574603-4023-1-git-send-email-Nilesh.Kokane05@gmail.com> In-Reply-To: <1445574603-4023-1-git-send-email-Nilesh.Kokane05@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [128.219.12.132] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >Fixed- Return of an errno should typically be negative (ie: return -EAGAIN) > >Signed-off-by: Nilesh Kokane >--- > drivers/staging/lustre/lnet/lnet/lib-move.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) Bad idea. I also made this mistake and it broke LNet really badly.