mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>
Cc: linux-doc@vger.kernel.org, Juri Lelli <juri.lelli@redhat.com>,
	William White <chwhite@redhat.com>,
	Daniel Bristot de Oliveira <bristot@kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>
Subject: [PATCH V3 08/11] rtla/hwnoise: Reduce runtime to 75%
Date: Tue,  6 Jun 2023 18:12:22 +0200	[thread overview]
Message-ID: <af0b7113ffc00031b9af4bb40ef5889a27dadf8c.1686066600.git.bristot@kernel.org> (raw)
In-Reply-To: <cover.1686066600.git.bristot@kernel.org>

osnoise runs 100% of time by default. It makes sense because osnoise
is preemptive. hwnoise checks preemption once a second, so it
reduces system progress.

Reduce runtime to 75% to avoid problems by default. I added a Fixes
as it might avoid problems for first time users as it lands on distros.

Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Daniel Bristot de Oliveira <bristot@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Fixes: 1f428356c38d ("rtla: Add hwnoise tool")
Signed-off-by: Daniel Bristot de Oliveira <bristot@kernel.org>
---
 tools/tracing/rtla/src/osnoise_top.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tools/tracing/rtla/src/osnoise_top.c b/tools/tracing/rtla/src/osnoise_top.c
index 85abba568faf..f7c959be8677 100644
--- a/tools/tracing/rtla/src/osnoise_top.c
+++ b/tools/tracing/rtla/src/osnoise_top.c
@@ -348,8 +348,14 @@ struct osnoise_top_params *osnoise_top_parse_args(int argc, char **argv)
 	if (!params)
 		exit(1);
 
-	if (strcmp(argv[0], "hwnoise") == 0)
+	if (strcmp(argv[0], "hwnoise") == 0) {
 		params->mode = MODE_HWNOISE;
+		/*
+		 * Reduce CPU usage for 75% to avoid killing the system.
+		 */
+		params->runtime = 750000;
+		params->period = 1000000;
+	}
 
 	while (1) {
 		static struct option long_options[] = {
-- 
2.38.1


  parent reply	other threads:[~2023-06-06 16:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06 16:12 [PATCH V3 00/11] rtla improvements Daniel Bristot de Oliveira
2023-06-06 16:12 ` [PATCH V3 01/11] rtla: Add -C cgroup support Daniel Bristot de Oliveira
2023-06-06 16:12 ` [PATCH V3 02/11] rtla: Add --house-keeping option Daniel Bristot de Oliveira
2023-06-12 14:06   ` Masami Hiramatsu
2023-06-12 14:21     ` Daniel Bristot de Oliveira
2023-06-13 20:27       ` Steven Rostedt
2023-06-06 16:12 ` [PATCH V3 03/11] rtla: Change monitored_cpus from char * to cpu_set_t Daniel Bristot de Oliveira
2023-06-06 16:12 ` [PATCH V3 04/11] rtla: Automatically move rtla to a house-keeping cpu Daniel Bristot de Oliveira
2023-06-06 16:12 ` [PATCH V3 05/11] rtla/timerlat: Give timerlat auto analysis its own instance Daniel Bristot de Oliveira
2023-06-06 16:12 ` [PATCH V3 06/11] rtla/timerlat_hist: Add auto-analysis support Daniel Bristot de Oliveira
2023-06-06 16:12 ` [PATCH V3 07/11] rtla: Start the tracers after creating all instances Daniel Bristot de Oliveira
2023-06-06 16:12 ` Daniel Bristot de Oliveira [this message]
2023-06-06 16:12 ` [PATCH V3 09/11] rtla/timerlat_top: Add timerlat user-space support Daniel Bristot de Oliveira
2023-06-06 16:12 ` [PATCH V3 10/11] rtla/timerlat_hist: " Daniel Bristot de Oliveira
2023-06-06 16:12 ` [PATCH V3 11/11] Documentation: Add tools/rtla timerlat -u option documentation Daniel Bristot de Oliveira
2023-06-12  9:41 ` [PATCH V3 00/11] rtla improvements Juri Lelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af0b7113ffc00031b9af4bb40ef5889a27dadf8c.1686066600.git.bristot@kernel.org \
    --to=bristot@kernel.org \
    --cc=chwhite@redhat.com \
    --cc=corbet@lwn.net \
    --cc=juri.lelli@redhat.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®