From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A22523F99D6 for ; Thu, 26 Mar 2026 14:26:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774535180; cv=none; b=Z7Ye9DkjdNIMJ1dT/QHW9C8vopdIt6AGRH7KA/xbDEKeS7UbDy56o4B+Wyq8PPvcwJZGw++gfOQJ46k2VcX0kW8YkQjiyq96oKWbP01wMLZvlJkthUwIVEe94APdqvE8NG/QaX7+ii47yCcYjh3d+ePV4eEIybc52CMaBvYhGVk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774535180; c=relaxed/simple; bh=6Hv9yoKIKwxTtz3CTjyWdTAt9zBbZOsdr/QjKnf0beI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OX9DpvHenzEL2e4Bmh9+yGcY/eQeO4izYEztjFc4F0f8NKVD/OwcDX+y6WkVuoXjOsl7SlA9LY+tCyVJGOATiDVZsIpXu+mxpGucBfxmNP2VV/8kUz4DK5ubnsm+aawffq3T4xQpxjNqjY/i13OmAzqPX3I4rmer0yutZmcWA90= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linbit.com; spf=pass smtp.mailfrom=linbit.com; dkim=pass (2048-bit key) header.d=linbit-com.20230601.gappssmtp.com header.i=@linbit-com.20230601.gappssmtp.com header.b=miiofPK1; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linbit-com.20230601.gappssmtp.com header.i=@linbit-com.20230601.gappssmtp.com header.b="miiofPK1" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-439c6fc2910so674796f8f.0 for ; Thu, 26 Mar 2026 07:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linbit-com.20230601.gappssmtp.com; s=20230601; t=1774535177; x=1775139977; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=D2Q2L6QPYD77pFkuLTamPUn8SCwVh3rf5WS9Lfg0NYM=; b=miiofPK1ysa6TeJaSG4fhhRa2ofxi/fWIPkBT7GE+L3kBoztwLURixxUIxP382VmKS LzjE0infn6o8jrwjjy0qdIwXLUBy7ayGQT/9MLNEboW5A4fv5LAQPyLKavzqg2cq5BDJ z9fzlMfKase65GyHnrWC4J+iDrKrPbtbkTwbapRqEiAKmZ4X5PJlLLM2y+LKbr4drA2/ wWDH1CzLR4h/IOttgkjbmnEmrb2tMdiA2kRIqbERgmceN68qobLKFst6W2xMaSg7tNAP ibNojiB52RthRAsHa1GBRC/I8K5RZAHCbjIWWViTHbmXaUbjef8axTuJLnEtOTlQmGFr WGFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774535177; x=1775139977; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=D2Q2L6QPYD77pFkuLTamPUn8SCwVh3rf5WS9Lfg0NYM=; b=VnckGR26wP+LbQf9ypRWpyGrRfZuvOCGn9h726jBcKxGFcFERNGOXFOliJQE58aYJo g1z3hI6d+yZhf4Zx1Pgd/a/9Z/vOrwjkIgPolYP8kbE6x5qnATfnAHj4t1qg8PYO4rTF xQlWHxl1YXnzbW4Xd2tZwvcemGgv4YNX+mYzNZufcvXzqChxf74L7TFQ3GwdAa5NDfhJ fLa/S0KeDZxKl3vi2QpxnaIUcXiq0I+JQs95L9bhpA8cGQPkrmkUhGYa3W2wE2VBysh+ sj7B7AEkeuUu2WMrEDp2e9BPf1SW01Q5fOdtnggSwmY+f9ammWN9m4/rIST8BuIH9f34 P7rg== X-Forwarded-Encrypted: i=1; AJvYcCVWagBhdTG/WHBoFqBt1EyswJybRPzppcHhEl+xDv7MjxLIr3ERdKN/FH8+sWD1Mxj/se7NbZYTyTYj0pg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxj+hB5nJWkS+tOhhQlimy1a8F6vgGdkuGtMNFZ9UpzVKU/yPpp peHo2ulNOMwSkHDNL32Z0T7ET6ONl0Nrav1YfPJK20i/CnvepqzhHxKJG1uGTgu65E0= X-Gm-Gg: ATEYQzw634G0GZhwAIsCWl0ovMnwMInzqp1hRRRwSNz5YI2c+tAOEVZeh+ol4UZ59Qc KkeOSQPznsceO4oaL9YLkuAb1qMaoNJtGF3lYOLxz7CLYSSKqgjVmUYtV8dHjvrPPsAHGYzUbYy WwXhOh6E+gsKy/KbXQs2NzxVs+GYkHjWsa9hsO/UqVcSuIlqbw0WZ5rYPsDaMFl4hua8yL9pjvC TVuAL1d1UhchUbv6nqUbBrG8agyAb5AfH4b+weKmCH6q9p6MOFY+62Lc1sp+7wckUqZtXPYV6xg k9c2rB4Z9CV0CS8Gr+R1v6VrCpZmBdFsGPhEZoKMTvmLtAahdiDrw40OeQmuhLXuvHmwuOFMFGp SCOX00TQvHGNKm+eakYk4vBDWLy9d4TWFdQODXLatgAv6BMGUJa4XqzigQiR+6su9YOVuPxnTrN BRRpZ1WsBBpF/+t75AgUO1UICMaHrs/QWqjoKWdwfOIjqieKowMzX3C7nlNdywPmlw4AbimaCYL qWQpDJ4vxhe8p7jiMY= X-Received: by 2002:a5d:5f83:0:b0:43b:4273:a6d2 with SMTP id ffacd0b85a97d-43b889af3f6mr11954568f8f.13.1774535176699; Thu, 26 Mar 2026 07:26:16 -0700 (PDT) Received: from [10.43.5.171] (62-99-137-214.static.upcbusiness.at. [62.99.137.214]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919df85csm11907248f8f.28.2026.03.26.07.26.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 07:26:16 -0700 (PDT) Message-ID: Date: Thu, 26 Mar 2026 15:26:14 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] drbd: Add check for error pointer To: Ethan Tidmore , Philipp Reisner , Lars Ellenberg , Jens Axboe Cc: drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260317232318.18923-1-ethantidmore06@gmail.com> <20260317232318.18923-5-ethantidmore06@gmail.com> Content-Language: en-US From: =?UTF-8?Q?Christoph_B=C3=B6hmwalder?= In-Reply-To: <20260317232318.18923-5-ethantidmore06@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/18/26 00:23, Ethan Tidmore wrote: > The function find_cfg_context_attr() can return an error pointer or NULL > in its error path. > > Change NULL check to IS_ERR_OR_NULL(). > > Detected by Smatch: > drivers/block/drbd/drbd_nl.c:6571 drbd_adm_dump_paths() error: > 'resource_filter' dereferencing possible ERR_PTR() > > Fixes: 626c95b0e2a23 ("drbd: rework netlink interface for DRBD 9 multi-peer config") > Signed-off-by: Ethan Tidmore > --- > drivers/block/drbd/drbd_nl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c > index c5e253820ccf..1f458eb972e9 100644 > --- a/drivers/block/drbd/drbd_nl.c > +++ b/drivers/block/drbd/drbd_nl.c > @@ -6566,7 +6566,7 @@ static int drbd_adm_dump_paths(struct sk_buff *skb, struct netlink_callback *cb) > resource = (struct drbd_resource *)cb->args[0]; > if (!cb->args[0]) { > resource_filter = find_cfg_context_attr(cb->nlh, T_ctx_resource_name); > - if (resource_filter) { > + if (!IS_ERR_OR_NULL(resource_filter)) { > retcode = ERR_RES_NOT_KNOWN; > resource = drbd_find_resource(nla_data(resource_filter)); > if (!resource) find_cfg_context_attr is also called identically in 3 other cases, so these have the same issue. I've also fixed these 3 cases in my squash. Regards, Christoph